#19 Tests

* adds tests for views in intervention app
* fixes bugs detected by test writing

intervention/views.py

@@ -93,6 +93,7 @@ def new_view(request: HttpRequest):
 
 
 @login_required
+@default_group_required
 def new_id_view(request: HttpRequest):
     """ JSON endpoint
 
@@ -111,6 +112,7 @@ def new_id_view(request: HttpRequest):
 
 
 @login_required
+@default_group_required
 def new_document_view(request: HttpRequest, id: str):
     """ Renders a form for uploading new documents
 
@@ -129,6 +131,7 @@ def new_document_view(request: HttpRequest, id: str):
 
 
 @login_required
+@default_group_required
 def get_revocation_view(request: HttpRequest, doc_id: str):
     """ Returns the revocation document as downloadable file
 
@@ -142,10 +145,18 @@ def get_revocation_view(request: HttpRequest, doc_id: str):
 
     """
     doc = get_object_or_404(RevocationDocument, id=doc_id)
+    # File download only possible if related instance is shared with user
+    if not doc.instance.users.filter(id=request.user.id):
+        messages.info(
+            request,
+            DATA_UNSHARED
+        )
+        return redirect("intervention:detail", id=doc.instance.id)
     return get_document(doc)
 
 
 @login_required
+@default_group_required
 def get_document_view(request: HttpRequest, doc_id: str):
     """ Returns the document as downloadable file
 
@@ -172,6 +183,7 @@ def get_document_view(request: HttpRequest, doc_id: str):
 
 
 @login_required
+@default_group_required
 def remove_document_view(request: HttpRequest, doc_id: str):
     """ Removes the document from the database and file system
 
@@ -251,6 +263,7 @@ def detail_view(request: HttpRequest, id: str):
 
 
 @login_required
+@default_group_required
 def edit_view(request: HttpRequest, id: str):
     """
     Renders a view for editing interventions
@@ -374,6 +387,7 @@ def share_view(request: HttpRequest, id: str, token: str):
 
 
 @login_required
+@default_group_required
 def create_share_view(request: HttpRequest, id: str):
     """ Renders sharing form for an intervention
 
@@ -393,6 +407,7 @@ def create_share_view(request: HttpRequest, id: str):
 
 
 @login_required
+@registration_office_group_required
 def run_check_view(request: HttpRequest, id: str):
     """ Renders check form for an intervention
 
@@ -413,6 +428,7 @@ def run_check_view(request: HttpRequest, id: str):
 
 
 @login_required
+@default_group_required
 def new_revocation_view(request: HttpRequest, id: str):
     """ Renders sharing form for an intervention
 
@@ -432,6 +448,7 @@ def new_revocation_view(request: HttpRequest, id: str):
 
 
 @login_required
+@default_group_required
 def log_view(request: HttpRequest, id: str):
     """ Renders a log view using modal