* fixes bug where quality checker for compensations would not check properly for state surface sums
pull/305/head
mpeltriaux 2 years ago
parent e600b78c74
commit 5551a513e9

@ -30,10 +30,8 @@ class CompensationQualityChecker(AbstractQualityChecker):
""" """
after_states = self.obj.get_surface_after_states() after_states = self.obj.get_surface_after_states()
before_states = self.obj.get_surface_before_states() before_states = self.obj.get_surface_before_states()
sum_after_states_surface = self.obj.get_surface_after_states()
sum_before_states_surface = self.obj.get_surface_before_states()
if sum_after_states_surface != sum_before_states_surface: if after_states != before_states:
self.messages.append( self.messages.append(
_("States unequal") _("States unequal")
) )

@ -74,7 +74,8 @@ class CheckModalForm(BaseModalForm):
"checked_comps", "checked_comps",
f"{comp.identifier}: {msg}" f"{comp.identifier}: {msg}"
) )
comps_valid = checker.valid if comps_valid and not checker.valid:
comps_valid = checker.valid
deductions_valid = self._are_deductions_valid() deductions_valid = self._are_deductions_valid()
return deductions_valid and comps_valid return deductions_valid and comps_valid

Loading…
Cancel
Save