# Refactoring team views

* refactors team views
* split views.py into users.py and teams.py in users app
* refactors method headers for _user_has_permission()
* adds method and class comments and documentation to base view classes

compensation/views/compensation/compensation.py

@@ -59,7 +59,7 @@ class NewCompensationFormView(BaseNewSpatialLocatedObjectFormView):
             intervention = get_object_or_404(Intervention, id=intervention_id)
             return intervention.is_shared_with(user)
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         # User has to be an ets user
         return user.is_default_user()
 
@@ -88,7 +88,7 @@ class EditCompensationFormView(BaseEditSpatialLocatedObjectFormView):
     _TEMPLATE = "compensation/form/view.html"
     _REDIRECT_URL = "compensation:detail"
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         # User has to be a default user
         return user.is_default_user()
 
@@ -170,5 +170,5 @@ class RemoveCompensationView(LoginRequiredMixin, BaseRemoveModalFormView):
     _FORM_CLS = RemoveModalForm
     _REDIRECT_URL = "compensation:index"
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         return user.is_default_user()

compensation/views/eco_account/eco_account.py

@@ -49,7 +49,7 @@ class NewEcoAccountFormView(BaseNewSpatialLocatedObjectFormView):
     _TAB_TITLE = _("New Eco-Account")
     _REDIRECT_URL = "compensation:acc:detail"
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         # User has to be a default user
         return user.is_default_user()
 
@@ -60,7 +60,7 @@ class EditEcoAccountFormView(BaseEditSpatialLocatedObjectFormView):
     _TEMPLATE = "compensation/form/view.html"
     _REDIRECT_URL = "compensation:acc:detail"
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         # User has to be a default user
         return user.is_default_user()
 
@@ -260,5 +260,5 @@ class RemoveEcoAccountView(LoginRequiredMixin, BaseRemoveModalFormView):
     _FORM_CLS = RemoveEcoAccountModalForm
     _REDIRECT_URL = "compensation:acc:index"
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         return user.is_default_user()

compensation/views/payment.py

@@ -24,7 +24,7 @@ class BasePaymentView(LoginRequiredMixin, BaseModalFormView):
         url = super()._get_redirect_url(*args, **kwargs)
         return f"{url}#related_data"
 
-    def _user_has_permission(self, user):
+    def _user_has_permission(self, user, **kwargs):
         return user.is_default_user()