# User view refactoring

* refactors majority of user views into class based views
* introduces BaseModalFormView and BaseView for even more generic usage
* renames url identifier user:index into user:detail for more clarity

user/views/views.py

@@ -1,8 +1,10 @@
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
 from django.urls import reverse
 
 from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
+from konova.views.base import BaseView, BaseModalFormView
 from user.forms.modals.team import NewTeamModalForm, EditTeamModalForm, RemoveTeamModalForm, LeaveTeamModalForm
 from user.forms.modals.user import UserContactForm
 from user.forms.team import TeamDataForm
@@ -13,129 +15,108 @@ from django.shortcuts import render, redirect, get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
 from konova.contexts import BaseContext
-from konova.decorators import any_group_check, login_required_modal
+from konova.decorators import login_required_modal
 
 
-@login_required
-@any_group_check
-def index_view(request: HttpRequest):
-    """ Renders the user's data index view
+class UserDetailView(LoginRequiredMixin, BaseView):
+    _TAB_TITLE = _("User settings")
+    _TEMPLATE = "user/index.html"
 
-    Args:
-        request ():
-
-    Returns:
-
-    """
-    template = "user/index.html"
-    context = {
-        "user": request.user,
-        TAB_TITLE_IDENTIFIER: _("User settings"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
+    def get(self, request: HttpRequest):
+        context = {
+            "user": request.user,
+            TAB_TITLE_IDENTIFIER: self._TAB_TITLE,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
 
 
-@login_required
-@any_group_check
-def notifications_view(request: HttpRequest):
-    """ Renders the notifications settings view
+class NotificationsView(LoginRequiredMixin, BaseView):
+    _TEMPLATE = "user/notifications.html"
+    _TAB_TITLE = _("User notifications")
 
-    Args:
-        request ():
+    def get(self, request: HttpRequest):
+        user = request.user
+        form = UserNotificationForm(user=user, data=None)
+        context = {
+            "user": user,
+            "form": form,
+            TAB_TITLE_IDENTIFIER: self._TAB_TITLE,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
 
-    Returns:
-
-    """
-    template = "user/notifications.html"
-    user = request.user
-
-    form = UserNotificationForm(user=user, data=request.POST or None)
-    if request.method == "POST":
+    def post(self, request: HttpRequest):
+        user = request.user
+        form = UserNotificationForm(user=user, data=request.POST)
         if form.is_valid():
             form.save()
             messages.success(
                 request,
                 _("Notifications edited")
             )
-            return redirect("user:index")
-    elif request.method == "GET":
-        # Implicit
-        pass
-    else:
-        raise NotImplementedError
-
-    context = {
-        "user": user,
-        "form": form,
-        TAB_TITLE_IDENTIFIER: _("User notifications"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
+            return redirect("user:detail")
+        context = {
+            "user": user,
+            "form": form,
+            TAB_TITLE_IDENTIFIER: self._TAB_TITLE,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
 
 
-@login_required_modal
-@login_required
-def contact_view(request: HttpRequest, id: str):
-    """ Renders contact modal view of a users contact data
+class ContactView(LoginRequiredMixin, BaseModalFormView):
+    def get(self, request: HttpRequest, id: str):
+        """ Renders contact modal view of a users contact data
 
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The user's id
+        Args:
+            request (HttpRequest): The incoming request
+            id (str): The user's id
 
-    Returns:
+        Returns:
 
-    """
-    user = get_object_or_404(User, id=id)
-    form = UserContactForm(request.POST or None, instance=user, request=request)
-    template = "modal/modal_form.html"
-    context = {
-        "form": form,
-    }
-    context = BaseContext(request, context).context
-    return render(
-        request,
-        template,
-        context
-    )
+        """
+        user = get_object_or_404(User, id=id)
+        form = UserContactForm(request.POST or None, instance=user, request=request)
+        context = {
+            "form": form,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
 
 
-@login_required_modal
-@login_required
-def data_team_view(request: HttpRequest, id: str):
-    """ Renders team data
+class TeamDetailModalView(LoginRequiredMixin, BaseModalFormView):
+    def get(self, request: HttpRequest, id: str):
+        """ Renders team data
 
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The team's id
+        Args:
+            request (HttpRequest): The incoming request
+            id (str): The team's id
 
-    Returns:
+        Returns:
 
-    """
-    team = get_object_or_404(Team, id=id)
-    form = TeamDataForm(request.POST or None, instance=team, request=request)
-    template = "modal/modal_form.html"
-    context = {
-        "form": form,
-    }
-    context = BaseContext(request, context).context
-    return render(
-        request,
-        template,
-        context
-    )
+        """
+        team = get_object_or_404(Team, id=id)
+        form = TeamDataForm(request.POST or None, instance=team, request=request)
+        context = {
+            "form": form,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
 
 
-@login_required
-def index_team_view(request: HttpRequest):
-    template = "user/team/index.html"
-    user = request.user
-    context = {
-        "teams": user.shared_teams,
-        "tab_title": _("Teams"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
+class TeamIndexView(LoginRequiredMixin, BaseView):
+    _TEMPLATE = "user/team/index.html"
+    _TAB_TITLE = _("Teams")
+
+    def get(self, request: HttpRequest):
+        user = request.user
+        context = {
+            "teams": user.shared_teams,
+            "tab_title": self._TAB_TITLE,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
 
 
 @login_required_modal