# Refactoring team views

* refactors team views
* split views.py into users.py and teams.py in users app
* refactors method headers for _user_has_permission()
* adds method and class comments and documentation to base view classes

api/tests/v1/update/test_api_update.py

@@ -12,7 +12,7 @@ from django.contrib.gis import geos
 from django.urls import reverse
 
 from api.tests.v1.share.test_api_sharing import BaseAPIV1TestCase
-from konova.sub_settings.lanis_settings import DEFAULT_SRID_RLP
+from konova.models import Geometry
 
 
 class APIV1UpdateTestCase(BaseAPIV1TestCase):
@@ -64,7 +64,7 @@ class APIV1UpdateTestCase(BaseAPIV1TestCase):
 
         put_props = put_body["properties"]
         put_geom = geos.fromstr(json.dumps(put_body))
-        put_geom.transform(DEFAULT_SRID_RLP)
+        put_geom = Geometry.cast_to_rlp_srid(put_geom)
         self.assertEqual(put_geom, self.intervention.geometry.geom)
         self.assertEqual(put_props["title"], self.intervention.title)
         self.assertNotEqual(modified_on, self.intervention.modified)
@@ -94,7 +94,7 @@ class APIV1UpdateTestCase(BaseAPIV1TestCase):
 
         put_props = put_body["properties"]
         put_geom = geos.fromstr(json.dumps(put_body))
-        put_geom.transform(DEFAULT_SRID_RLP)
+        put_geom = Geometry.cast_to_rlp_srid(put_geom)
         self.assertEqual(put_geom, self.compensation.geometry.geom)
         self.assertEqual(put_props["title"], self.compensation.title)
         self.assertNotEqual(modified_on, self.compensation.modified)
@@ -124,7 +124,7 @@ class APIV1UpdateTestCase(BaseAPIV1TestCase):
 
         put_props = put_body["properties"]
         put_geom = geos.fromstr(json.dumps(put_body))
-        put_geom.transform(DEFAULT_SRID_RLP)
+        put_geom = Geometry.cast_to_rlp_srid(put_geom)
         self.assertEqual(put_geom, self.eco_account.geometry.geom)
         self.assertEqual(put_props["title"], self.eco_account.title)
         self.assertNotEqual(modified_on, self.eco_account.modified)
@@ -156,7 +156,7 @@ class APIV1UpdateTestCase(BaseAPIV1TestCase):
 
         put_props = put_body["properties"]
         put_geom = geos.fromstr(json.dumps(put_body))
-        put_geom.transform(DEFAULT_SRID_RLP)
+        put_geom = Geometry.cast_to_rlp_srid(put_geom)
         self.assertEqual(put_geom, self.ema.geometry.geom)
         self.assertEqual(put_props["title"], self.ema.title)
         self.assertNotEqual(modified_on, self.ema.modified)

api/utils/serializer/serializer.py

@@ -13,7 +13,7 @@ from django.contrib.gis.geos import GEOSGeometry
 from django.core.paginator import Paginator
 from django.db.models import Q
 
-from konova.sub_settings.lanis_settings import DEFAULT_SRID_RLP
+from konova.models import Geometry
 from konova.utils.message_templates import DATA_UNSHARED
 
 
@@ -145,8 +145,8 @@ class AbstractModelAPISerializer:
         if isinstance(geojson, dict):
             geojson = json.dumps(geojson)
         geometry = geos.fromstr(geojson)
-        if geometry.srid != DEFAULT_SRID_RLP:
+        geometry = Geometry.cast_to_rlp_srid(geometry)
-            geometry.transform(DEFAULT_SRID_RLP)
+        geometry = Geometry.cast_to_multipolygon(geometry)
         return geometry
 
     def _get_obj_from_db(self, id, user):

compensation/forms/compensation.py

@@ -168,6 +168,17 @@ class NewCompensationForm(AbstractCompensationForm,
         comp.log.add(action)
         return comp, action
 
+    def is_valid(self):
+        valid = super().is_valid()
+        intervention = self.cleaned_data.get("intervention", None)
+        if intervention.is_recorded:
+            valid &= False
+            self.add_error(
+                "intervention",
+                _("This intervention is currently recorded. You cannot add further compensations as long as it is recorded.")
+            )
+        return valid
+
     def save(self, user: User, geom_form: SimpleGeomForm):
         with transaction.atomic():
             comp, action = self.__create_comp(user)

compensation/forms/modals/compensation_action.py

@@ -7,10 +7,12 @@ Created on: 18.08.22
 """
 from dal import autocomplete
 from django import forms
+from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
 from codelist.models import KonovaCode
 from codelist.settings import CODELIST_COMPENSATION_ACTION_ID, CODELIST_COMPENSATION_ACTION_DETAIL_ID
+from compensation.models import CompensationAction
 from intervention.inputs import CompensationActionTreeCheckboxSelectMultiple
 from konova.forms.modals import BaseModalForm, RemoveModalForm
 from konova.utils.message_templates import COMPENSATION_ACTION_EDITED, ADDED_COMPENSATION_ACTION
@@ -114,7 +116,8 @@ class EditCompensationActionModalForm(NewCompensationActionModalForm):
     action = None
 
     def __init__(self, *args, **kwargs):
-        self.action = kwargs.pop("action", None)
+        action_id = kwargs.pop("action_id", None)
+        self.action = get_object_or_404(CompensationAction, id=action_id)
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit action")
         form_data = {
@@ -147,8 +150,8 @@ class RemoveCompensationActionModalForm(RemoveModalForm):
     action = None
 
     def __init__(self, *args, **kwargs):
-        action = kwargs.pop("action", None)
+        action_id = kwargs.pop("action_id", None)
-        self.action = action
+        self.action = get_object_or_404(CompensationAction, id=action_id)
         super().__init__(*args, **kwargs)
 
     def save(self):

compensation/forms/modals/deadline.py

@@ -6,10 +6,11 @@ Created on: 18.08.22
 
 """
 from django import forms
+from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
 from konova.forms.modals import BaseModalForm
-from konova.models import DeadlineType
+from konova.models import DeadlineType, Deadline
 from konova.utils import validators
 from konova.utils.message_templates import DEADLINE_EDITED
 
@@ -90,7 +91,8 @@ class EditDeadlineModalForm(NewDeadlineModalForm):
     deadline = None
 
     def __init__(self, *args, **kwargs):
-        self.deadline = kwargs.pop("deadline", None)
+        deadline_id = kwargs.pop("deadline_id", None)
+        self.deadline = get_object_or_404(Deadline, id=deadline_id)
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit deadline")
         form_data = {

compensation/forms/modals/document.py

@@ -6,12 +6,27 @@ Created on: 18.08.22
 
 """
 from compensation.models import CompensationDocument, EcoAccountDocument
-from konova.forms.modals import NewDocumentModalForm
+from konova.forms.modals import NewDocumentModalForm, EditDocumentModalForm, RemoveDocumentModalForm
 
 
 class NewCompensationDocumentModalForm(NewDocumentModalForm):
-    document_model = CompensationDocument
+    _DOCUMENT_CLS = CompensationDocument
+
+
+class EditCompensationDocumentModalForm(EditDocumentModalForm):
+    _DOCUMENT_CLS = CompensationDocument
+
+
+class RemoveCompensationDocumentModalForm(RemoveDocumentModalForm):
+    _DOCUMENT_CLS = CompensationDocument
 
 
 class NewEcoAccountDocumentModalForm(NewDocumentModalForm):
-    document_model = EcoAccountDocument
+    _DOCUMENT_CLS = EcoAccountDocument
+
+class EditEcoAccountDocumentModalForm(EditDocumentModalForm):
+    _DOCUMENT_CLS = EcoAccountDocument
+
+class RemoveEcoAccountDocumentModalForm(RemoveDocumentModalForm):
+    _DOCUMENT_CLS = EcoAccountDocument
+

compensation/forms/modals/payment.py

@@ -6,8 +6,10 @@ Created on: 18.08.22
 
 """
 from django import forms
+from django.shortcuts import get_object_or_404
 from django.utils.translation import pgettext_lazy as _con, gettext_lazy as _
 
+from compensation.models import Payment
 from konova.forms.modals import RemoveModalForm, BaseModalForm
 from konova.utils import validators
 from konova.utils.message_templates import PAYMENT_EDITED
@@ -103,7 +105,8 @@ class EditPaymentModalForm(NewPaymentForm):
     payment = None
 
     def __init__(self, *args, **kwargs):
-        self.payment = kwargs.pop("payment", None)
+        payment_id = kwargs.pop("payment_id", None)
+        self.payment = get_object_or_404(Payment, id=payment_id)
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit payment")
         form_date = {
@@ -133,8 +136,8 @@ class RemovePaymentModalForm(RemoveModalForm):
     payment = None
 
     def __init__(self, *args, **kwargs):
-        payment = kwargs.pop("payment", None)
+        payment_id = kwargs.pop("payment_id", None)
-        self.payment = payment
+        self.payment = get_object_or_404(Payment, id=payment_id)
         super().__init__(*args, **kwargs)
 
     def save(self):

compensation/forms/modals/resubmission.py

@@ -0,0 +1,15 @@
+"""
+Author: Michel Peltriaux
+Created on: 21.10.25
+
+"""
+from compensation.models import Compensation, EcoAccount
+from konova.forms.modals import ResubmissionModalForm
+
+
+class CompensationResubmissionModalForm(ResubmissionModalForm):
+    _MODEL_CLS = Compensation
+
+
+class EcoAccountResubmissionModalForm(ResubmissionModalForm):
+    _MODEL_CLS = EcoAccount

compensation/forms/modals/state.py

@@ -5,21 +5,17 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 18.08.22
 
 """
-from bootstrap_modal_forms.mixins import is_ajax
 from dal import autocomplete
 from django import forms
-from django.contrib import messages
-from django.http import HttpResponseRedirect, HttpRequest
-from django.shortcuts import render
 from django.utils.translation import gettext_lazy as _
 
 from codelist.models import KonovaCode
 from codelist.settings import CODELIST_BIOTOPES_ID, \
     CODELIST_BIOTOPES_EXTRA_CODES_FULL_ID
+from compensation.models import CompensationState
 from intervention.inputs import CompensationStateTreeRadioSelect
-from konova.contexts import BaseContext
 from konova.forms.modals import RemoveModalForm, BaseModalForm
-from konova.utils.message_templates import COMPENSATION_STATE_EDITED, FORM_INVALID, ADDED_COMPENSATION_STATE
+from konova.utils.message_templates import COMPENSATION_STATE_EDITED, ADDED_COMPENSATION_STATE
 
 
 class NewCompensationStateModalForm(BaseModalForm):
@@ -68,10 +64,13 @@ class NewCompensationStateModalForm(BaseModalForm):
         )
     )
 
+    _is_before_state: bool = False
+
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.form_title = _("New state")
         self.form_caption = _("Insert data for the new state")
+        self._is_before_state = bool(self.request.GET.get("before", False))
         choices = KonovaCode.objects.filter(
             code_lists__in=[CODELIST_BIOTOPES_ID],
             is_archived=False,
@@ -83,65 +82,19 @@ class NewCompensationStateModalForm(BaseModalForm):
         ]
         self.fields["biotope_type"].choices = choices
 
-    def save(self, is_before_state: bool = False):
+    def save(self):
-        state = self.instance.add_state(self, is_before_state)
+        state = self.instance.add_state(self, self._is_before_state)
         self.instance.mark_as_edited(self.user, self.request, ADDED_COMPENSATION_STATE)
         return state
 
-    def process_request(self, request: HttpRequest, msg_success: str = _("Object removed"), msg_error: str = FORM_INVALID, redirect_url: str = None):
-        """ Generic processing of request
-
-        Wraps the request processing logic, so we don't need the same code everywhere a RemoveModalForm is being used
-
-        +++
-        The generic method from super class can not be used, since we need to do some request parameter check in here.
-        +++
-
-        Args:
-            request (HttpRequest): The incoming request
-            msg_success (str): The message in case of successful removing
-            msg_error (str): The message in case of an error
-
-        Returns:
-
-        """
-        redirect_url = redirect_url if redirect_url is not None else request.META.get("HTTP_REFERER", "home")
-        template = self.template
-        if request.method == "POST":
-            if self.is_valid():
-                # Modal forms send one POST for checking on data validity. This can be used to return possible errors
-                # on the form. A second POST (if no errors occured) is sent afterwards and needs to process the
-                # saving/commiting of the data to the database. is_ajax() performs this check. The first request is
-                # an ajax call, the second is a regular form POST.
-                if not is_ajax(request.META):
-                    is_before_state = bool(request.GET.get("before", False))
-                    self.save(is_before_state=is_before_state)
-                    messages.success(
-                        request,
-                        msg_success
-                    )
-                return HttpResponseRedirect(redirect_url)
-            else:
-                context = {
-                    "form": self,
-                }
-                context = BaseContext(request, context).context
-                return render(request, template, context)
-        elif request.method == "GET":
-            context = {
-                "form": self,
-            }
-            context = BaseContext(request, context).context
-            return render(request, template, context)
-        else:
-            raise NotImplementedError
-
 
 class EditCompensationStateModalForm(NewCompensationStateModalForm):
     state = None
 
     def __init__(self, *args, **kwargs):
-        self.state = kwargs.pop("state", None)
+        state_id = kwargs.pop("state_id", None)
+        self.state = CompensationState.objects.get(id=state_id)
+
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit state")
         biotope_type_id = self.state.biotope_type.id if self.state.biotope_type else None
@@ -172,8 +125,8 @@ class RemoveCompensationStateModalForm(RemoveModalForm):
     state = None
 
     def __init__(self, *args, **kwargs):
-        state = kwargs.pop("state", None)
+        state_id = kwargs.pop("state_id", None)
-        self.state = state
+        self.state = CompensationState.objects.get(id=state_id)
         super().__init__(*args, **kwargs)
 
     def save(self):

compensation/tests/compensation/test_workflow.py

@@ -54,7 +54,7 @@ class CompensationWorkflowTestCase(BaseWorkflowTestCase):
         post_data = {
             "identifier": test_id,
             "title": test_title,
-            "geom": geom_json,
+            "output": geom_json,
             "intervention": self.intervention.id,
         }
         pre_creation_intervention_log_count = self.intervention.log.count()
@@ -94,7 +94,7 @@ class CompensationWorkflowTestCase(BaseWorkflowTestCase):
         post_data = {
             "identifier": test_id,
             "title": test_title,
-            "geom": geom_json,
+            "output": geom_json,
         }
         pre_creation_intervention_log_count = self.intervention.log.count()
 
@@ -150,7 +150,7 @@ class CompensationWorkflowTestCase(BaseWorkflowTestCase):
             "title": new_title,
             "intervention": self.intervention.id,  # just keep the intervention as it is
             "comment": new_comment,
-            "geom": geojson,
+            "output": geojson,
         }
         self.client_user.post(url, post_data)
         self.compensation.refresh_from_db()

compensation/tests/compensation/unit/test_forms.py

@@ -80,7 +80,11 @@ class EditCompensationActionModalFormTestCase(NewCompensationActionModalFormTest
         self.compensation.actions.add(self.comp_action)
 
     def test_init(self):
-        form = EditCompensationActionModalForm(request=self.request, instance=self.compensation, action=self.comp_action)
+        form = EditCompensationActionModalForm(
+            request=self.request,
+            instance=self.compensation,
+            action_id=self.comp_action.id
+        )
         self.assertEqual(form.form_title, str(_("Edit action")))
         self.assertEqual(len(form.fields["action_type"].initial), self.comp_action.action_type.count())
         self.assertEqual(len(form.fields["action_type_details"].initial), self.comp_action.action_type_details.count())
@@ -101,7 +105,7 @@ class EditCompensationActionModalFormTestCase(NewCompensationActionModalFormTest
             "comment": comment,
         }
 
-        form = EditCompensationActionModalForm(data, request=self.request, instance=self.compensation, action=self.comp_action)
+        form = EditCompensationActionModalForm(data, request=self.request, instance=self.compensation, action_id=self.comp_action.id)
 
         self.assertTrue(form.is_valid())
         action = form.save()
@@ -126,7 +130,7 @@ class RemoveCompensationActionModalFormTestCase(EditCompensationActionModalFormT
         
     def test_init(self):
         self.assertIn(self.comp_action, self.compensation.actions.all())
-        form = RemoveCompensationActionModalForm(request=self.request, instance=self.compensation, action=self.comp_action)
+        form = RemoveCompensationActionModalForm(request=self.request, instance=self.compensation, action_id=self.comp_action.id)
         self.assertEqual(form.action, self.comp_action)
         
     def test_save(self):
@@ -137,7 +141,7 @@ class RemoveCompensationActionModalFormTestCase(EditCompensationActionModalFormT
             data, 
             request=self.request,
             instance=self.compensation,
-            action=self.comp_action
+            action_id=self.comp_action.id
         )
         self.assertTrue(form.is_valid())
         self.assertIn(self.comp_action, self.compensation.actions.all())
@@ -186,12 +190,20 @@ class NewCompensationStateModalFormTestCase(BaseTestCase):
         self.assertEqual(self.compensation.before_states.count(), 0)
         self.assertEqual(self.compensation.after_states.count(), 0)
 
-        form = NewCompensationStateModalForm(data, request=self.request, instance=self.compensation)
+        self.request.GET._mutable = True
-
+        self.request.GET.update(
+            {
+                "before": True,
+            }
+        )
+        self.request.GET._mutable = False
+        form = NewCompensationStateModalForm(
+            data,
+            request=self.request,
+            instance=self.compensation,
+        )
         self.assertTrue(form.is_valid(), msg=form.errors)
-
+        state = form.save()
-        is_before_state = True
-        state = form.save(is_before_state)
 
         self.assertEqual(self.compensation.before_states.count(), 1)
         self.assertEqual(self.compensation.after_states.count(), 0)
@@ -205,8 +217,16 @@ class NewCompensationStateModalFormTestCase(BaseTestCase):
         self.assertEqual(last_log.action, UserAction.EDITED)
         self.assertEqual(last_log.comment, ADDED_COMPENSATION_STATE)
 
-        is_before_state = False
+        self.request.GET._mutable = True
-        state = form.save(is_before_state)
+        del self.request.GET["before"]
+        self.request.GET._mutable = False
+        form = NewCompensationStateModalForm(
+            data,
+            request=self.request,
+            instance=self.compensation,
+        )
+        self.assertTrue(form.is_valid(), msg=form.errors)
+        state = form.save()
 
         self.assertEqual(self.compensation.before_states.count(), 1)
         self.assertEqual(self.compensation.after_states.count(), 1)
@@ -230,7 +250,11 @@ class EditCompensationStateModalFormTestCase(NewCompensationStateModalFormTestCa
         self.compensation.after_states.add(self.comp_state)
 
     def test_init(self):
-        form = EditCompensationStateModalForm(request=self.request, instance=self.compensation, state=self.comp_state)
+        form = EditCompensationStateModalForm(
+            request=self.request,
+            instance=self.compensation,
+            state_id=self.comp_state.id
+        )
 
         self.assertEqual(form.state, self.comp_state)
         self.assertEqual(form.form_title, str(_("Edit state")))
@@ -261,7 +285,7 @@ class EditCompensationStateModalFormTestCase(NewCompensationStateModalFormTestCa
             data,
             request=self.request,
             instance=self.compensation,
-            state=self.comp_state
+            state_id=self.comp_state.id
         )
         self.assertTrue(form.is_valid(), msg=form.errors)
 
@@ -282,7 +306,11 @@ class RemoveCompensationStateModalFormTestCase(EditCompensationStateModalFormTes
         super().setUp()
 
     def test_init(self):
-        form = RemoveCompensationStateModalForm(request=self.request, instance=self.compensation, state=self.comp_state)
+        form = RemoveCompensationStateModalForm(
+            request=self.request,
+            instance=self.compensation,
+            state_id=self.comp_state.id
+        )
 
         self.assertEqual(form.state, self.comp_state)
 
@@ -294,7 +322,7 @@ class RemoveCompensationStateModalFormTestCase(EditCompensationStateModalFormTes
             data,
             request=self.request,
             instance=self.compensation,
-            state=self.comp_state
+            state_id=self.comp_state.id
         )
         self.assertTrue(form.is_valid(), msg=form.errors)
 

compensation/tests/compensation/unit/test_models.py

@@ -36,7 +36,7 @@ class AbstractCompensationModelTestCase(BaseTestCase):
             data,
             request=self.request,
             instance=self.compensation,
-            deadline=self.finished_deadline,
+            deadline_id=self.finished_deadline.id,
         )
         self.assertTrue(form.is_valid(), msg=form.errors)
         self.assertIn(self.finished_deadline, self.compensation.deadlines.all())

compensation/tests/ecoaccount/test_workflow.py

@@ -46,7 +46,7 @@ class EcoAccountWorkflowTestCase(BaseWorkflowTestCase):
         post_data = {
             "identifier": test_id,
             "title": test_title,
-            "geom": geom_json,
+            "output": geom_json,
             "surface": test_deductable_surface,
             "conservation_office": test_conservation_office.id
         }
@@ -86,7 +86,7 @@ class EcoAccountWorkflowTestCase(BaseWorkflowTestCase):
         new_title = self.create_dummy_string()
         new_identifier = self.create_dummy_string()
         new_comment = self.create_dummy_string()
-        new_geometry = MultiPolygon(srid=4326)  # Create an empty geometry
+        new_geometry = self.create_dummy_geometry()
         test_conservation_office = self.get_conservation_office_code()
         test_deductable_surface = self.eco_account.deductable_surface + 100
 
@@ -103,7 +103,7 @@ class EcoAccountWorkflowTestCase(BaseWorkflowTestCase):
             "identifier": new_identifier,
             "title": new_title,
             "comment": new_comment,
-            "geom": new_geometry.geojson,
+            "output": self.create_geojson(new_geometry),
             "surface": test_deductable_surface,
             "conservation_office": test_conservation_office.id
         }

compensation/urls/compensation.py

@@ -10,27 +10,28 @@ from django.urls import path
 from compensation.views.compensation.document import EditCompensationDocumentView, NewCompensationDocumentView, \
     GetCompensationDocumentView, RemoveCompensationDocumentView
 from compensation.views.compensation.resubmission import CompensationResubmissionView
-from compensation.views.compensation.report import report_view
+from compensation.views.compensation.report import CompensationReportView
 from compensation.views.compensation.deadline import NewCompensationDeadlineView, EditCompensationDeadlineView, \
     RemoveCompensationDeadlineView
 from compensation.views.compensation.action import NewCompensationActionView, EditCompensationActionView, \
     RemoveCompensationActionView
 from compensation.views.compensation.state import NewCompensationStateView, EditCompensationStateView, \
     RemoveCompensationStateView
-from compensation.views.compensation.compensation import index_view, new_view, new_id_view, detail_view, edit_view, \
+from compensation.views.compensation.compensation import \
-    remove_view
+    CompensationIndexView, CompensationIdentifierGeneratorView, CompensationDetailView, \
+    NewCompensationFormView, EditCompensationFormView, RemoveCompensationView
 from compensation.views.compensation.log import CompensationLogView
 
 urlpatterns = [
     # Main compensation
-    path("", index_view, name="index"),
+    path("", CompensationIndexView.as_view(), name="index"),
-    path('new/id', new_id_view, name='new-id'),
+    path('new/id', CompensationIdentifierGeneratorView.as_view(), name='new-id'),
-    path('new/<intervention_id>', new_view, name='new'),
+    path('new/<intervention_id>', NewCompensationFormView.as_view(), name='new'),
-    path('new', new_view, name='new'),
+    path('new', NewCompensationFormView.as_view(), name='new'),
-    path('<id>', detail_view, name='detail'),
+    path('<id>', CompensationDetailView.as_view(), name='detail'),
     path('<id>/log', CompensationLogView.as_view(), name='log'),
-    path('<id>/edit', edit_view, name='edit'),
+    path('<id>/edit', EditCompensationFormView.as_view(), name='edit'),
-    path('<id>/remove', remove_view, name='remove'),
+    path('<id>/remove', RemoveCompensationView.as_view(), name='remove'),
 
     path('<id>/state/new', NewCompensationStateView.as_view(), name='new-state'),
     path('<id>/state/<state_id>/edit', EditCompensationStateView.as_view(), name='state-edit'),
@@ -43,7 +44,7 @@ urlpatterns = [
     path('<id>/deadline/new', NewCompensationDeadlineView.as_view(), name="new-deadline"),
     path('<id>/deadline/<deadline_id>/edit', EditCompensationDeadlineView.as_view(), name='deadline-edit'),
     path('<id>/deadline/<deadline_id>/remove', RemoveCompensationDeadlineView.as_view(), name='deadline-remove'),
-    path('<id>/report', report_view, name='report'),
+    path('<id>/report', CompensationReportView.as_view(), name='report'),
     path('<id>/resub', CompensationResubmissionView.as_view(), name='resubmission-create'),
 
     # Documents

compensation/urls/eco_account.py

@@ -8,11 +8,11 @@ Created on: 24.08.21
 from django.urls import path
 
 from compensation.autocomplete.eco_account import EcoAccountAutocomplete
-from compensation.views.eco_account.eco_account import index_view, new_view, new_id_view, edit_view, remove_view, \
+from compensation.views.eco_account.eco_account import EcoAccountIndexView, EcoAccountIdentifierGeneratorView, \
-    detail_view
+    EcoAccountDetailView, NewEcoAccountFormView, EditEcoAccountFormView, RemoveEcoAccountView
 from compensation.views.eco_account.log import EcoAccountLogView
 from compensation.views.eco_account.record import EcoAccountRecordView
-from compensation.views.eco_account.report import report_view
+from compensation.views.eco_account.report import EcoAccountReportView
 from compensation.views.eco_account.resubmission import EcoAccountResubmissionView
 from compensation.views.eco_account.state import NewEcoAccountStateView, EditEcoAccountStateView, \
     RemoveEcoAccountStateView
@@ -28,15 +28,15 @@ from compensation.views.eco_account.deduction import NewEcoAccountDeductionView,
 
 app_name = "acc"
 urlpatterns = [
-    path("", index_view, name="index"),
+    path("", EcoAccountIndexView.as_view(), name="index"),
-    path('new/', new_view, name='new'),
+    path('new/', NewEcoAccountFormView.as_view(), name='new'),
-    path('new/id', new_id_view, name='new-id'),
+    path('new/id', EcoAccountIdentifierGeneratorView.as_view(), name='new-id'),
-    path('<id>', detail_view, name='detail'),
+    path('<id>', EcoAccountDetailView.as_view(), name='detail'),
     path('<id>/log', EcoAccountLogView.as_view(), name='log'),
     path('<id>/record', EcoAccountRecordView.as_view(), name='record'),
-    path('<id>/report', report_view, name='report'),
+    path('<id>/report', EcoAccountReportView.as_view(), name='report'),
-    path('<id>/edit', edit_view, name='edit'),
+    path('<id>/edit', EditEcoAccountFormView.as_view(), name='edit'),
-    path('<id>/remove', remove_view, name='remove'),
+    path('<id>/remove', RemoveEcoAccountView.as_view(), name='remove'),
     path('<id>/resub', EcoAccountResubmissionView.as_view(), name='resubmission-create'),
 
     path('<id>/state/new', NewEcoAccountStateView.as_view(), name='new-state'),

compensation/urls/payment.py

@@ -6,11 +6,11 @@ Created on: 24.08.21
 
 """
 from django.urls import path
-from compensation.views.payment import *
+from compensation.views.payment import NewPaymentView, RemovePaymentView, EditPaymentView
 
 app_name = "pay"
 urlpatterns = [
-    path('<id>/new', new_payment_view, name='new'),
+    path('<id>/new', NewPaymentView.as_view(), name='new'),
-    path('<id>/remove/<payment_id>', payment_remove_view, name='remove'),
+    path('<id>/remove/<payment_id>', RemovePaymentView.as_view(), name='remove'),
-    path('<id>/edit/<payment_id>', payment_edit_view, name='edit'),
+    path('<id>/edit/<payment_id>', EditPaymentView.as_view(), name='edit'),
 ]

compensation/views/compensation/action.py

@@ -5,53 +5,23 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404
-from django.urls import reverse
-from django.utils.decorators import method_decorator
 
-from compensation.forms.modals.compensation_action import RemoveCompensationActionModalForm, \
+from compensation.models import Compensation
-    EditCompensationActionModalForm, NewCompensationActionModalForm
-from compensation.models import Compensation, CompensationAction
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
-from konova.utils.message_templates import COMPENSATION_ACTION_REMOVED, COMPENSATION_ACTION_EDITED, \
-    COMPENSATION_ACTION_ADDED
 from konova.views.action import AbstractNewCompensationActionView, AbstractEditCompensationActionView, \
     AbstractRemoveCompensationActionView
 
+_COMPENSATION_DETAIL_URL_NAME = "compensation:detail"
 
 class NewCompensationActionView(AbstractNewCompensationActionView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = _COMPENSATION_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditCompensationActionView(AbstractEditCompensationActionView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = _COMPENSATION_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveCompensationActionView(AbstractRemoveCompensationActionView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = _COMPENSATION_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/compensation/compensation.py

@@ -7,8 +7,8 @@ Created on: 19.08.22
 """
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
 from django.core.exceptions import ObjectDoesNotExist
-from django.db.models import Sum
 from django.http import HttpRequest, JsonResponse
 from django.shortcuts import get_object_or_404, render, redirect
 from django.urls import reverse
@@ -18,284 +18,157 @@ from compensation.forms.compensation import EditCompensationForm, NewCompensatio
 from compensation.models import Compensation
 from compensation.tables.compensation import CompensationTable
 from intervention.models import Intervention
-from konova.contexts import BaseContext
+from konova.decorators import shared_access_required, default_group_required, login_required_modal
-from konova.decorators import shared_access_required, default_group_required, any_group_check, login_required_modal, \
-    uuid_required
-from konova.forms import SimpleGeomForm
 from konova.forms.modals import RemoveModalForm
-from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
-from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
 from konova.utils.message_templates import COMPENSATION_REMOVED_TEMPLATE, DATA_CHECKED_PREVIOUSLY_TEMPLATE, \
-    RECORDED_BLOCKS_EDIT, CHECK_STATE_RESET, FORM_INVALID, PARAMS_INVALID, IDENTIFIER_REPLACED, \
+    RECORDED_BLOCKS_EDIT, PARAMS_INVALID
-    COMPENSATION_ADDED_TEMPLATE, DO_NOT_FORGET_TO_SHARE, GEOMETRY_SIMPLIFIED
+from konova.views.base import BaseIndexView, BaseIdentifierGeneratorView, BaseNewSpatialLocatedObjectFormView, \
+    BaseEditSpatialLocatedObjectFormView
+from konova.views.detail import BaseDetailView
+from konova.views.remove import BaseRemoveModalFormView
 
 
-@login_required
+class CompensationIndexView(LoginRequiredMixin, BaseIndexView):
-@any_group_check
+    _TAB_TITLE = _("Compensations - Overview")
-def index_view(request: HttpRequest):
+    _INDEX_TABLE_CLS = CompensationTable
-    """
-    Renders the index view for compensation
 
-    Args:
+    def _get_queryset(self):
-        request (HttpRequest): The incoming request
+        qs = Compensation.objects.filter(
-
+            deleted=None,  # only show those which are not deleted individually
-    Returns:
+            intervention__deleted=None,  # and don't show the ones whose intervention has been deleted
-        A rendered view
+        ).order_by(
-    """
+            "-modified__timestamp"
-    template = "generic_index.html"
+        )
-    compensations = Compensation.objects.filter(
+        return qs
-        deleted=None,  # only show those which are not deleted individually
-        intervention__deleted=None,  # and don't show the ones whose intervention has been deleted
-    ).order_by(
-        "-modified__timestamp"
-    )
-    table = CompensationTable(
-        request=request,
-        queryset=compensations
-    )
-    context = {
-        "table": table,
-        TAB_TITLE_IDENTIFIER: _("Compensations - Overview"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
-@login_required
+class NewCompensationFormView(BaseNewSpatialLocatedObjectFormView):
-@default_group_required
+    _FORM_CLS = NewCompensationForm
-@shared_access_required(Intervention, "intervention_id")
+    _MODEL_CLS = Compensation
-def new_view(request: HttpRequest, intervention_id: str = None):
+    _TEMPLATE = "compensation/form/view.html"
-    """
+    _TAB_TITLE = _("New Compensation")
-    Renders a view for a new compensation creation
+    _REDIRECT_URL = "compensation:detail"
 
-    Args:
+    def _user_has_shared_access(self, user, **kwargs):
-        request (HttpRequest): The incoming request
+        # On a new compensation make sure the intervention (if call came directly through an intervention's detail
+        # view) is shared with the user
+        intervention_id = kwargs.get("intervention_id", None)
+        if not intervention_id:
+            return True
+        else:
+            intervention = get_object_or_404(Intervention, id=intervention_id)
+            return intervention.is_shared_with(user)
 
-    Returns:
+    def _user_has_permission(self, user, **kwargs):
+        # User has to be an ets user
+        return user.is_default_user()
 
-    """
+    def dispatch(self, request, *args, **kwargs):
-    template = "compensation/form/view.html"
+        # Make sure there is an existing intervention based on the given id
-    if intervention_id is not None:
+        # Compensations can not exist without an intervention
-        try:
+        intervention_id = kwargs.get("intervention_id", None)
-            intervention = Intervention.objects.get(id=intervention_id)
+        if intervention_id:
-        except ObjectDoesNotExist:
+            try:
-            messages.error(request, PARAMS_INVALID)
+                intervention = Intervention.objects.get(id=intervention_id)
-            return redirect("home")
+                if intervention.is_recorded:
-        if intervention.is_recorded:
+                    messages.info(
-            messages.info(
+                        request,
-                request,
+                        RECORDED_BLOCKS_EDIT
-                RECORDED_BLOCKS_EDIT
-            )
-            return redirect("intervention:detail", id=intervention_id)
-
-    data_form = NewCompensationForm(request.POST or None, intervention_id=intervention_id)
-    geom_form = SimpleGeomForm(request.POST or None, read_only=False)
-    if request.method == "POST":
-        if data_form.is_valid() and geom_form.is_valid():
-            generated_identifier = data_form.cleaned_data.get("identifier", None)
-            comp = data_form.save(request.user, geom_form)
-            if generated_identifier != comp.identifier:
-                messages.info(
-                    request,
-                    IDENTIFIER_REPLACED.format(
-                        generated_identifier,
-                        comp.identifier
                     )
-                )
+                    return redirect("intervention:detail", id=intervention_id)
-            messages.success(request, COMPENSATION_ADDED_TEMPLATE.format(comp.identifier))
+            except ObjectDoesNotExist:
-            if geom_form.geometry_simplified:
+                messages.error(request, PARAMS_INVALID, extra_tags="danger")
-                messages.info(
+                return redirect("home")
-                    request,
+        return super().dispatch(request, *args, **kwargs)
-                    GEOMETRY_SIMPLIFIED
-                )
-            return redirect("compensation:detail", id=comp.id)
-        else:
-            messages.error(request, FORM_INVALID, extra_tags="danger",)
-    else:
-        # For clarification: nothing in this case
-        pass
-    context = {
-        "form": data_form,
-        "geom_form": geom_form,
-        TAB_TITLE_IDENTIFIER: _("New compensation"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
-@login_required
+class EditCompensationFormView(BaseEditSpatialLocatedObjectFormView):
-@default_group_required
+    _MODEL_CLS = Compensation
-def new_id_view(request: HttpRequest):
+    _FORM_CLS = EditCompensationForm
-    """ JSON endpoint
+    _TEMPLATE = "compensation/form/view.html"
+    _REDIRECT_URL = "compensation:detail"
 
-    Provides fetching of free identifiers for e.g. AJAX calls
+    def _user_has_permission(self, user, **kwargs):
+        # User has to be a default user
+        return user.is_default_user()
 
-    """
+
-    tmp = Compensation()
+class CompensationIdentifierGeneratorView(LoginRequiredMixin, BaseIdentifierGeneratorView):
-    identifier = tmp.generate_new_identifier()
+    _MODEL_CLS = Compensation
-    while Compensation.objects.filter(identifier=identifier).exists():
+    _REDIRECT_URL = "compensation:index"
-        identifier = tmp.generate_new_identifier()
+
-    return JsonResponse(
+
-        data={
+class CompensationDetailView(BaseDetailView):
-            "gen_data": identifier
+    _MODEL_CLS = Compensation
+    _TEMPLATE = "compensation/detail/compensation/view.html"
+
+    def _get_object(self, id: str):
+        """ Returns the compensation
+
+        Args:
+            id (str): The compensation's id
+
+        Returns:
+            obj (Compensation): The compensation
+        """
+        comp = get_object_or_404(
+            Compensation.objects.select_related(
+                "modified",
+                "created",
+                "geometry"
+            ),
+            id=id,
+            deleted=None,
+            intervention__deleted=None,
+        )
+        return comp
+
+    def _get_detail_context(self, obj: Compensation):
+        """ Generate object specific detail context for  view
+
+        Args:
+            obj (): The record
+
+        Returns:
+
+        """
+        # Order states according to surface
+        before_states = obj.before_states.all().prefetch_related("biotope_type").order_by("-surface")
+        after_states = obj.after_states.all().prefetch_related("biotope_type").order_by("-surface")
+        actions = obj.actions.all().prefetch_related("action_type")
+
+        # Precalculate logical errors between before- and after-states
+        # Sum() returns None in case of no states, so we catch that and replace it with 0 for easier handling
+        sum_before_states = obj.get_surface_before_states()
+        sum_after_states = obj.get_surface_after_states()
+        diff_states = abs(sum_before_states - sum_after_states)
+
+        last_checked = obj.intervention.get_last_checked_action()
+        last_checked_tooltip = ""
+        if last_checked:
+            last_checked_tooltip = DATA_CHECKED_PREVIOUSLY_TEMPLATE.format(
+                last_checked.get_timestamp_str_formatted(),
+                last_checked.user
+            )
+
+        context = {
+            "last_checked": last_checked,
+            "last_checked_tooltip": last_checked_tooltip,
+            "actions": actions,
+            "before_states": before_states,
+            "after_states": after_states,
+            "sum_before_states": sum_before_states,
+            "sum_after_states": sum_after_states,
+            "diff_states": diff_states,
+            "has_finished_deadlines": obj.get_finished_deadlines().exists(),
         }
-    )
+        return context
 
 
-@login_required
+class RemoveCompensationView(LoginRequiredMixin, BaseRemoveModalFormView):
-@default_group_required
+    _MODEL_CLS = Compensation
-@shared_access_required(Compensation, "id")
+    _FORM_CLS = RemoveModalForm
-def edit_view(request: HttpRequest, id: str):
+    _REDIRECT_URL = "compensation:index"
-    """
-    Renders a view for editing compensations
-
-    Args:
-        request (HttpRequest): The incoming request
-
-    Returns:
-
-    """
-    template = "compensation/form/view.html"
-    # Get object from db
-    comp = get_object_or_404(Compensation, id=id)
-    if comp.is_recorded:
-        messages.info(
-            request,
-            RECORDED_BLOCKS_EDIT
-        )
-        return redirect("compensation:detail", id=id)
-
-    # Create forms, initialize with values from db/from POST request
-    data_form = EditCompensationForm(request.POST or None, instance=comp)
-    geom_form = SimpleGeomForm(request.POST or None, read_only=False, instance=comp)
-    if request.method == "POST":
-        if data_form.is_valid() and geom_form.is_valid():
-            # Preserve state of intervention checked to determine whether the user must be informed or not
-            # about a change of the check state
-            intervention_is_checked = comp.intervention.checked is not None
-
-            # The data form takes the geom form for processing, as well as the performing user
-            comp = data_form.save(request.user, geom_form)
-            if intervention_is_checked:
-                messages.info(request, CHECK_STATE_RESET)
-            messages.success(request, _("Compensation {} edited").format(comp.identifier))
-            if geom_form.geometry_simplified:
-                messages.info(
-                    request,
-                    GEOMETRY_SIMPLIFIED
-                )
-            return redirect("compensation:detail", id=comp.id)
-        else:
-            messages.error(request, FORM_INVALID, extra_tags="danger",)
-    else:
-        # For clarification: nothing in this case
-        pass
-    context = {
-        "form": data_form,
-        "geom_form": geom_form,
-        TAB_TITLE_IDENTIFIER: _("Edit {}").format(comp.identifier),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
-
-
-@login_required
-@any_group_check
-@uuid_required
-def detail_view(request: HttpRequest, id: str):
-    """ Renders a detail view for a compensation
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The compensation's id
-
-    Returns:
-
-    """
-    template = "compensation/detail/compensation/view.html"
-    comp = get_object_or_404(
-        Compensation.objects.select_related(
-            "modified",
-            "created",
-            "geometry"
-        ),
-        id=id,
-        deleted=None,
-        intervention__deleted=None,
-    )
-    geom_form = SimpleGeomForm(instance=comp)
-    parcels = comp.get_underlying_parcels()
-    _user = request.user
-    is_data_shared = comp.intervention.is_shared_with(_user)
-
-    # Order states according to surface
-    before_states = comp.before_states.all().prefetch_related("biotope_type").order_by("-surface")
-    after_states = comp.after_states.all().prefetch_related("biotope_type").order_by("-surface")
-    actions = comp.actions.all().prefetch_related("action_type")
-
-    # Precalculate logical errors between before- and after-states
-    # Sum() returns None in case of no states, so we catch that and replace it with 0 for easier handling
-    sum_before_states = comp.get_surface_before_states()
-    sum_after_states = comp.get_surface_after_states()
-    diff_states = abs(sum_before_states - sum_after_states)
-
-    request = comp.set_status_messages(request)
-
-    last_checked = comp.intervention.get_last_checked_action()
-    last_checked_tooltip = ""
-    if last_checked:
-        last_checked_tooltip = DATA_CHECKED_PREVIOUSLY_TEMPLATE.format(last_checked.get_timestamp_str_formatted(), last_checked.user)
-
-    requesting_user_is_only_shared_user = comp.is_only_shared_with(_user)
-    if requesting_user_is_only_shared_user:
-        messages.info(
-            request,
-            DO_NOT_FORGET_TO_SHARE
-        )
-
-    context = {
-        "obj": comp,
-        "last_checked": last_checked,
-        "last_checked_tooltip": last_checked_tooltip,
-        "geom_form": geom_form,
-        "parcels": parcels,
-        "is_entry_shared": is_data_shared,
-        "actions": actions,
-        "before_states": before_states,
-        "after_states": after_states,
-        "sum_before_states": sum_before_states,
-        "sum_after_states": sum_after_states,
-        "diff_states": diff_states,
-        "is_default_member": _user.in_group(DEFAULT_GROUP),
-        "is_zb_member": _user.in_group(ZB_GROUP),
-        "is_ets_member": _user.in_group(ETS_GROUP),
-        "LANIS_LINK": comp.get_LANIS_link(),
-        TAB_TITLE_IDENTIFIER: f"{comp.identifier} - {comp.title}",
-        "has_finished_deadlines": comp.get_finished_deadlines().exists(),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
-
-
-@login_required_modal
-@login_required
-@default_group_required
-@shared_access_required(Compensation, "id")
-def remove_view(request: HttpRequest, id: str):
-    """ Renders a modal view for removing the compensation
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The compensation's id
-
-    Returns:
-
-    """
-    comp = get_object_or_404(Compensation, id=id)
-    form = RemoveModalForm(request.POST or None, instance=comp, request=request)
-    return form.process_request(
-        request=request,
-        msg_success=COMPENSATION_REMOVED_TEMPLATE.format(comp.identifier),
-        redirect_url=reverse("compensation:index"),
-    )
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()

compensation/views/compensation/deadline.py

@@ -5,45 +5,21 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from compensation.models import Compensation
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.deadline import AbstractRemoveDeadlineView, AbstractEditDeadlineView, AbstractNewDeadlineView
 
+_COMPENSATION_DETAIL_URL_NAME = "compensation:detail"
 
 class NewCompensationDeadlineView(AbstractNewDeadlineView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = _COMPENSATION_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditCompensationDeadlineView(AbstractEditDeadlineView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = _COMPENSATION_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveCompensationDeadlineView(AbstractRemoveDeadlineView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = _COMPENSATION_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/compensation/document.py

@@ -5,62 +5,33 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from compensation.forms.modals.document import NewCompensationDocumentModalForm, EditCompensationDocumentModalForm, \
-from django.utils.decorators import method_decorator
+    RemoveCompensationDocumentModalForm
-
-from compensation.forms.modals.document import NewCompensationDocumentModalForm
 from compensation.models import Compensation, CompensationDocument
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
-from konova.forms.modals import EditDocumentModalForm
 from konova.views.document import AbstractNewDocumentView, AbstractGetDocumentView, AbstractRemoveDocumentView, \
     AbstractEditDocumentView
 
 
 class NewCompensationDocumentView(AbstractNewDocumentView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    form = NewCompensationDocumentModalForm
+    _FORM_CLS = NewCompensationDocumentModalForm
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = "compensation:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class GetCompensationDocumentView(AbstractGetDocumentView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    document_model = CompensationDocument
+    _DOCUMENT_CLS = CompensationDocument
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveCompensationDocumentView(AbstractRemoveDocumentView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    document_model = CompensationDocument
+    _DOCUMENT_CLS = CompensationDocument
-
+    _FORM_CLS = RemoveCompensationDocumentModalForm
-    @method_decorator(login_required_modal)
+    _REDIRECT_URL = "compensation:detail"
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditCompensationDocumentView(AbstractEditDocumentView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    document_model = CompensationDocument
+    _DOCUMENT_CLS = CompensationDocument
-    form = EditDocumentModalForm
+    _FORM_CLS = EditCompensationDocumentModalForm
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = "compensation:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/compensation/log.py

@@ -5,20 +5,11 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from compensation.models import Compensation
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.log import AbstractLogView
 
 
-class CompensationLogView(AbstractLogView):
+class CompensationLogView(LoginRequiredMixin, AbstractLogView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/compensation/report.py

@@ -5,76 +5,48 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404, render
 from django.urls import reverse
-from django.utils.translation import gettext_lazy as _
 
 from compensation.models import Compensation
-from konova.contexts import BaseContext
+from konova.sub_settings.django_settings import BASE_URL
-from konova.forms import SimpleGeomForm
+from konova.utils.qrcode import QrCode
-from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
+from konova.views.report import BaseReportView
-from konova.utils.generators import generate_qr_code
 
 
-def report_view(request: HttpRequest, id: str):
+class BaseCompensationReportView(BaseReportView):
-    """ Renders the public report view
+    def _get_compensation_report_context(self, obj):
+        # Order states by surface
+        before_states = obj.before_states.all().order_by("-surface").prefetch_related("biotope_type")
+        after_states = obj.after_states.all().order_by("-surface").prefetch_related("biotope_type")
+        actions = obj.actions.all().prefetch_related("action_type")
 
-    Args:
+        return {
-        request (HttpRequest): The incoming request
+            "before_states": before_states,
-        id (str): The id of the intervention
+            "after_states": after_states,
-
+            "actions": actions,
-    Returns:
-
-    """
-    # Reuse the compensation report template since compensations are structurally identical
-    template = "compensation/report/compensation/report.html"
-    comp = get_object_or_404(Compensation, id=id)
-
-    tab_title = _("Report {}").format(comp.identifier)
-    # If intervention is not recorded (yet or currently) we need to render another template without any data
-    if not comp.is_ready_for_publish():
-        template = "report/unavailable.html"
-        context = {
-            TAB_TITLE_IDENTIFIER: tab_title,
         }
-        context = BaseContext(request, context).context
-        return render(request, template, context)
 
-    # Prepare data for map viewer
-    geom_form = SimpleGeomForm(
-        instance=comp
-    )
-    parcels = comp.get_underlying_parcels()
 
-    qrcode_url = request.build_absolute_uri(reverse("compensation:report", args=(id,)))
+class CompensationReportView(BaseCompensationReportView):
-    qrcode_img = generate_qr_code(qrcode_url, 10)
+    _MODEL = Compensation
-    qrcode_lanis_url = comp.get_LANIS_link()
+    _TEMPLATE = "compensation/report/compensation/report.html"
-    qrcode_img_lanis = generate_qr_code(qrcode_lanis_url, 7)
 
-    # Order states by surface
+    def _get_report_context(self, obj):
-    before_states = comp.before_states.all().order_by("-surface").prefetch_related("biotope_type")
+        report_url = BASE_URL + reverse("compensation:report", args=(obj.id,))
-    after_states = comp.after_states.all().order_by("-surface").prefetch_related("biotope_type")
+        qrcode_report = QrCode(report_url, 10)
-    actions = comp.actions.all().prefetch_related("action_type")
+        qrcode_lanis = QrCode(obj.get_LANIS_link(), 7)
 
-    context = {
+        report_context = {
-        "obj": comp,
+            "qrcode": {
-        "qrcode": {
+                "img": qrcode_report.get_img(),
-            "img": qrcode_img,
+                "url": qrcode_report.get_content(),
-            "url": qrcode_url,
+            },
-        },
+            "qrcode_lanis": {
-        "qrcode_lanis": {
+                "img": qrcode_lanis.get_img(),
-            "img": qrcode_img_lanis,
+                "url": qrcode_lanis.get_content(),
-            "url": qrcode_lanis_url,
+            },
-        },
+            "is_entry_shared": False,  # disables action buttons during rendering
-        "is_entry_shared": False,  # disables action buttons during rendering
+            "tables_scrollable": False,
-        "before_states": before_states,
+        }
-        "after_states": after_states,
+        report_context.update(self._get_compensation_report_context(obj))
-        "geom_form": geom_form,
+        return report_context
-        "parcels": parcels,
-        "actions": actions,
-        "tables_scrollable": False,
-        TAB_TITLE_IDENTIFIER: tab_title,
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)

compensation/views/compensation/resubmission.py

@@ -5,22 +5,12 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from compensation.forms.modals.resubmission import CompensationResubmissionModalForm
-from django.utils.decorators import method_decorator
-
 from compensation.models import Compensation
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.resubmission import AbstractResubmissionView
 
 
 class CompensationResubmissionView(AbstractResubmissionView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url_base = "compensation:detail"
+    _FORM_CLS = CompensationResubmissionModalForm
-    form_action_url_base = "compensation:resubmission-create"
+    _REDIRECT_URL = "compensation:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/compensation/state.py

@@ -5,46 +5,21 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from compensation.models import Compensation
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.state import AbstractNewCompensationStateView, AbstractEditCompensationStateView, \
     AbstractRemoveCompensationStateView
 
 
 class NewCompensationStateView(AbstractNewCompensationStateView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = "compensation:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditCompensationStateView(AbstractEditCompensationStateView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = "compensation:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveCompensationStateView(AbstractRemoveCompensationStateView):
-    model = Compensation
+    _MODEL_CLS = Compensation
-    redirect_url = "compensation:detail"
+    _REDIRECT_URL = "compensation:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Compensation, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/action.py

@@ -5,46 +5,22 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.action import AbstractNewCompensationActionView, AbstractEditCompensationActionView, \
     AbstractRemoveCompensationActionView
 
+_ECO_ACCOUNT_DETAIL_URL_NAME = "compensation:acc:detail"
 
 class NewEcoAccountActionView(AbstractNewCompensationActionView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditEcoAccountActionView(AbstractEditCompensationActionView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEcoAccountActionView(AbstractRemoveCompensationActionView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/deadline.py

@@ -5,45 +5,22 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.deadline import AbstractNewDeadlineView, AbstractEditDeadlineView, AbstractRemoveDeadlineView
 
+_ECO_ACCOUNT_DETAIL_URL_NAME = "compensation:acc:detail"
 
 class NewEcoAccountDeadlineView(AbstractNewDeadlineView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditEcoAccountDeadlineView(AbstractEditDeadlineView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEcoAccountDeadlineView(AbstractRemoveDeadlineView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIL_URL_NAME
 
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/deduction.py

@@ -5,54 +5,33 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
 from django.http import Http404
-from django.utils.decorators import method_decorator
 
 from compensation.models import EcoAccount
-from konova.decorators import default_group_required, login_required_modal
 from konova.views.deduction import AbstractNewDeductionView, AbstractEditDeductionView, AbstractRemoveDeductionView
 
+_ECO_ACCOUNT_DETAIl_URL_NAME = "compensation:acc:detail"
 
-class NewEcoAccountDeductionView(AbstractNewDeductionView):
+class NewEcoAccountDeductionView(LoginRequiredMixin, AbstractNewDeductionView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIl_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
     def _custom_check(self, obj):
+        # New deductions can only be created if the eco account has been recorded
         if not obj.recorded:
             raise Http404()
 
-
+    def _check_for_recorded_instance(self, obj):
-class EditEcoAccountDeductionView(AbstractEditDeductionView):
+        # Deductions can be created on recorded as well as on non-recorded entries
-    def _custom_check(self, obj):
+        return None
-        pass
-
-    model = EcoAccount
-    redirect_url = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
-class RemoveEcoAccountDeductionView(AbstractRemoveDeductionView):
+class EditEcoAccountDeductionView(LoginRequiredMixin, AbstractEditDeductionView):
-    def _custom_check(self, obj):
+    _MODEL_CLS = EcoAccount
-        pass
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIl_URL_NAME
 
-    model = EcoAccount
-    redirect_url = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
+class RemoveEcoAccountDeductionView(LoginRequiredMixin, AbstractRemoveDeductionView):
+    _MODEL_CLS = EcoAccount
+    _REDIRECT_URL = _ECO_ACCOUNT_DETAIl_URL_NAME

compensation/views/eco_account/document.py

@@ -5,65 +5,33 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from compensation.forms.modals.document import NewEcoAccountDocumentModalForm, RemoveEcoAccountDocumentModalForm, \
-from django.http import HttpRequest
+    EditEcoAccountDocumentModalForm
-from django.shortcuts import get_object_or_404
-from django.urls import reverse
-from django.utils.decorators import method_decorator
-
-from compensation.forms.modals.document import NewEcoAccountDocumentModalForm
 from compensation.models import EcoAccount, EcoAccountDocument
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
-from konova.forms.modals import EditDocumentModalForm
 from konova.views.document import AbstractNewDocumentView, AbstractGetDocumentView, AbstractRemoveDocumentView, \
     AbstractEditDocumentView
 
 
 class NewEcoAccountDocumentView(AbstractNewDocumentView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    form = NewEcoAccountDocumentModalForm
+    _FORM_CLS = NewEcoAccountDocumentModalForm
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class GetEcoAccountDocumentView(AbstractGetDocumentView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    document_model = EcoAccountDocument
+    _DOCUMENT_CLS = EcoAccountDocument
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEcoAccountDocumentView(AbstractRemoveDocumentView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    document_model = EcoAccountDocument
+    _DOCUMENT_CLS = EcoAccountDocument
-
+    _FORM_CLS = RemoveEcoAccountDocumentModalForm
-    @method_decorator(login_required_modal)
+    _REDIRECT_URL = "compensation:acc:detail"
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditEcoAccountDocumentView(AbstractEditDocumentView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    document_model = EcoAccountDocument
+    _DOCUMENT_CLS = EcoAccountDocument
-    form = EditDocumentModalForm
+    _FORM_CLS = EditEcoAccountDocumentModalForm
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/eco_account.py

@@ -7,8 +7,8 @@ Created on: 19.08.22
 """
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
-from django.db.models import Sum
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.http import HttpRequest, JsonResponse
+from django.http import HttpRequest
 from django.shortcuts import get_object_or_404, redirect, render
 from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
@@ -17,43 +17,52 @@ from compensation.forms.eco_account import EditEcoAccountForm, NewEcoAccountForm
 from compensation.models import EcoAccount
 from compensation.tables.eco_account import EcoAccountTable
 from konova.contexts import BaseContext
-from konova.decorators import shared_access_required, default_group_required, any_group_check, login_required_modal, \
+from konova.decorators import shared_access_required, default_group_required, login_required_modal
-    uuid_required
 from konova.forms import SimpleGeomForm
-from konova.settings import ETS_GROUP, DEFAULT_GROUP, ZB_GROUP
+from konova.settings import ETS_GROUP
 from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
 from konova.utils.message_templates import CANCEL_ACC_RECORDED_OR_DEDUCTED, RECORDED_BLOCKS_EDIT, FORM_INVALID, \
-    IDENTIFIER_REPLACED, DO_NOT_FORGET_TO_SHARE, GEOMETRY_SIMPLIFIED
+    IDENTIFIER_REPLACED, GEOMETRY_SIMPLIFIED, GEOMETRIES_IGNORED_TEMPLATE
+from konova.views.base import BaseIndexView, BaseIdentifierGeneratorView, BaseNewSpatialLocatedObjectFormView, \
+    BaseEditSpatialLocatedObjectFormView
+from konova.views.detail import BaseDetailView
+from konova.views.remove import BaseRemoveModalFormView
 
 
-@login_required
+class EcoAccountIndexView(LoginRequiredMixin, BaseIndexView):
-@any_group_check
+    _INDEX_TABLE_CLS = EcoAccountTable
-def index_view(request: HttpRequest):
+    _TAB_TITLE = _("Eco-account - Overview")
-    """
-    Renders the index view for eco accounts
 
-    Args:
+    def _get_queryset(self):
-        request (HttpRequest): The incoming request
+        qs = EcoAccount.objects.filter(
+            deleted=None,
+        ).order_by(
+            "-modified__timestamp"
+        )
+        return qs
 
-    Returns:
+
-        A rendered view
+class NewEcoAccountFormView(BaseNewSpatialLocatedObjectFormView):
-    """
+    _FORM_CLS = NewEcoAccountForm
-    template = "generic_index.html"
+    _MODEL_CLS = EcoAccount
-    eco_accounts = EcoAccount.objects.filter(
+    _TEMPLATE = "compensation/form/view.html"
-        deleted=None,
+    _TAB_TITLE = _("New Eco-Account")
-    ).order_by(
+    _REDIRECT_URL = "compensation:acc:detail"
-        "-modified__timestamp"
+
-    )
+    def _user_has_permission(self, user, **kwargs):
-    table = EcoAccountTable(
+        # User has to be a default user
-        request=request,
+        return user.is_default_user()
-        queryset=eco_accounts
+
-    )
+
-    context = {
+class EditEcoAccountFormView(BaseEditSpatialLocatedObjectFormView):
-        "table": table,
+    _FORM_CLS = EditEcoAccountForm
-        TAB_TITLE_IDENTIFIER: _("Eco-account - Overview"),
+    _MODEL_CLS = EcoAccount
-    }
+    _TEMPLATE = "compensation/form/view.html"
-    context = BaseContext(request, context).context
+    _REDIRECT_URL = "compensation:acc:detail"
-    return render(request, template, context)
+
+    def _user_has_permission(self, user, **kwargs):
+        # User has to be a default user
+        return user.is_default_user()
 
 
 @login_required
@@ -84,11 +93,19 @@ def new_view(request: HttpRequest):
                     )
                 )
             messages.success(request, _("Eco-Account {} added").format(acc.identifier))
-            if geom_form.geometry_simplified:
+            if geom_form.has_geometry_simplified():
                 messages.info(
                     request,
                     GEOMETRY_SIMPLIFIED
                 )
+
+            num_ignored_geometries = geom_form.get_num_geometries_ignored()
+            if num_ignored_geometries > 0:
+                messages.info(
+                    request,
+                    GEOMETRIES_IGNORED_TEMPLATE.format(num_ignored_geometries)
+                )
+
             return redirect("compensation:acc:detail", id=acc.id)
         else:
             messages.error(request, FORM_INVALID, extra_tags="danger",)
@@ -104,23 +121,9 @@ def new_view(request: HttpRequest):
     return render(request, template, context)
 
 
-@login_required
+class EcoAccountIdentifierGeneratorView(LoginRequiredMixin, BaseIdentifierGeneratorView):
-@default_group_required
+    _MODEL_CLS = EcoAccount
-def new_id_view(request: HttpRequest):
+    _REDIRECT_URL = "compensation:acc:index"
-    """ JSON endpoint
-
-    Provides fetching of free identifiers for e.g. AJAX calls
-
-    """
-    tmp = EcoAccount()
-    identifier = tmp.generate_new_identifier()
-    while EcoAccount.objects.filter(identifier=identifier).exists():
-        identifier = tmp.generate_new_identifier()
-    return JsonResponse(
-        data={
-            "gen_data": identifier
-        }
-    )
 
 
 @login_required
@@ -156,11 +159,19 @@ def edit_view(request: HttpRequest, id: str):
             # The data form takes the geom form for processing, as well as the performing user
             acc = data_form.save(request.user, geom_form)
             messages.success(request, _("Eco-Account {} edited").format(acc.identifier))
-            if geom_form.geometry_simplified:
+            if geom_form.has_geometry_simplified():
                 messages.info(
                     request,
                     GEOMETRY_SIMPLIFIED
                 )
+
+            num_ignored_geometries = geom_form.get_num_geometries_ignored()
+            if num_ignored_geometries > 0:
+                messages.info(
+                    request,
+                    GEOMETRIES_IGNORED_TEMPLATE.format(num_ignored_geometries)
+                )
+
             return redirect("compensation:acc:detail", id=acc.id)
         else:
             messages.error(request, FORM_INVALID, extra_tags="danger",)
@@ -176,116 +187,78 @@ def edit_view(request: HttpRequest, id: str):
     return render(request, template, context)
 
 
-@login_required
+class EcoAccountDetailView(BaseDetailView):
-@any_group_check
+    _MODEL_CLS = EcoAccount
-@uuid_required
+    _TEMPLATE = "compensation/detail/eco_account/view.html"
-def detail_view(request: HttpRequest, id: str):
-    """ Renders a detail view for a compensation
 
-    Args:
+    def _get_object(self, id: str):
-        request (HttpRequest): The incoming request
+        """ Fetch object for detail view
-        id (str): The compensation's id
 
-    Returns:
+        Args:
+            id (str): The record's id'
 
-    """
+        Returns:
-    template = "compensation/detail/eco_account/view.html"
-    acc = get_object_or_404(
-        EcoAccount.objects.prefetch_related(
-            "deadlines",
-        ).select_related(
-            'geometry',
-            'responsible',
-        ),
-        id=id,
-        deleted=None,
-    )
-    geom_form = SimpleGeomForm(instance=acc)
-    parcels = acc.get_underlying_parcels()
-    _user = request.user
-    is_data_shared = acc.is_shared_with(_user)
 
-    # Order states according to surface
+        """
-    before_states = acc.before_states.order_by("-surface")
+        acc = get_object_or_404(
-    after_states = acc.after_states.order_by("-surface")
+            EcoAccount.objects.prefetch_related(
-
+                "deadlines",
-    # Precalculate logical errors between before- and after-states
+            ).select_related(
-    # Sum() returns None in case of no states, so we catch that and replace it with 0 for easier handling
+                'geometry',
-    sum_before_states = acc.get_surface_before_states()
+                'responsible',
-    sum_after_states = acc.get_surface_after_states()
+            ),
-    diff_states = abs(sum_before_states - sum_after_states)
+            id=id,
-    # Calculate rest of available surface for deductions
+            deleted=None,
-    available_total = acc.deductable_rest
-    available_relative = acc.get_deductable_rest_relative()
-
-    # Prefetch related data to decrease the amount of db connections
-    deductions = acc.deductions.filter(
-        intervention__deleted=None,
-    )
-    actions = acc.actions.all()
-
-    request = acc.set_status_messages(request)
-
-    requesting_user_is_only_shared_user = acc.is_only_shared_with(_user)
-    if requesting_user_is_only_shared_user:
-        messages.info(
-            request,
-            DO_NOT_FORGET_TO_SHARE
         )
+        return acc
 
-    context = {
+    def _get_detail_context(self, obj: EcoAccount):
-        "obj": acc,
+        """ Generate object specific detail context for  view
-        "geom_form": geom_form,
+
-        "parcels": parcels,
+        Args:
-        "is_entry_shared": is_data_shared,
+            obj (): The record
-        "before_states": before_states,
+
-        "after_states": after_states,
+        Returns:
-        "sum_before_states": sum_before_states,
+
-        "sum_after_states": sum_after_states,
+        """
-        "diff_states": diff_states,
+        # Order states according to surface
-        "available": available_relative,
+        before_states = obj.before_states.order_by("-surface")
-        "available_total": available_total,
+        after_states = obj.after_states.order_by("-surface")
-        "is_default_member": _user.in_group(DEFAULT_GROUP),
+
-        "is_zb_member": _user.in_group(ZB_GROUP),
+        # Precalculate logical errors between before- and after-states
-        "is_ets_member": _user.in_group(ETS_GROUP),
+        # Sum() returns None in case of no states, so we catch that and replace it with 0 for easier handling
-        "LANIS_LINK": acc.get_LANIS_link(),
+        sum_before_states = obj.get_surface_before_states()
-        "deductions": deductions,
+        sum_after_states = obj.get_surface_after_states()
-        "actions": actions,
+        diff_states = abs(sum_before_states - sum_after_states)
-        TAB_TITLE_IDENTIFIER: f"{acc.identifier} - {acc.title}",
+        # Calculate rest of available surface for deductions
-        "has_finished_deadlines": acc.get_finished_deadlines().exists(),
+        available_total = obj.deductable_rest
-    }
+        available_relative = obj.get_deductable_rest_relative()
-    context = BaseContext(request, context).context
+
-    return render(request, template, context)
+        # Prefetch related data to decrease the amount of db connections
+        deductions = obj.deductions.filter(
+            intervention__deleted=None,
+        )
+        actions = obj.actions.all()
+
+        context = {
+            "before_states": before_states,
+            "after_states": after_states,
+            "sum_before_states": sum_before_states,
+            "sum_after_states": sum_after_states,
+            "diff_states": diff_states,
+            "available": available_relative,
+            "available_total": available_total,
+            "deductions": deductions,
+            "actions": actions,
+            "has_finished_deadlines": obj.get_finished_deadlines().exists(),
+        }
+        return context
 
 
-@login_required_modal
+class RemoveEcoAccountView(LoginRequiredMixin, BaseRemoveModalFormView):
-@login_required
+    _MODEL_CLS = EcoAccount
-@default_group_required
+    _FORM_CLS = RemoveEcoAccountModalForm
-@shared_access_required(EcoAccount, "id")
+    _REDIRECT_URL = "compensation:acc:index"
-def remove_view(request: HttpRequest, id: str):
-    """ Renders a modal view for removing the eco account
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The account's id
-
-    Returns:
-
-    """
-    acc = get_object_or_404(EcoAccount, id=id)
-
-    # If the eco account has already been recorded OR there are already deductions, it can not be deleted by a regular
-    # default group user
-    if acc.recorded is not None or acc.deductions.exists():
-        user = request.user
-        if not user.in_group(ETS_GROUP):
-            messages.info(request, CANCEL_ACC_RECORDED_OR_DEDUCTED)
-            return redirect("compensation:acc:detail", id=id)
-
-    form = RemoveEcoAccountModalForm(request.POST or None, instance=acc, request=request)
-    return form.process_request(
-        request=request,
-        msg_success=_("Eco-account removed"),
-        redirect_url=reverse("compensation:acc:index"),
-    )
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()

compensation/views/eco_account/log.py

@@ -5,20 +5,11 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.log import AbstractLogView
 
 
-class EcoAccountLogView(AbstractLogView):
+class EcoAccountLogView(LoginRequiredMixin, AbstractLogView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/record.py

@@ -5,20 +5,12 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
 from konova.views.record import AbstractRecordView
 
 
-class EcoAccountRecordView(AbstractRecordView):
+class EcoAccountRecordView(LoginRequiredMixin, AbstractRecordView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-
+    _REDIRECT_URL = "compensation:acc:detail"
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/report.py

@@ -5,83 +5,41 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404, render
 from django.urls import reverse
-from django.utils.translation import gettext_lazy as _
 
 from compensation.models import EcoAccount
-from konova.contexts import BaseContext
+from compensation.views.compensation.report import BaseCompensationReportView
-from konova.forms import SimpleGeomForm
+from konova.sub_settings.django_settings import BASE_URL
-from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
+from konova.utils.qrcode import QrCode
-from konova.utils.generators import generate_qr_code
 
 
-def report_view(request: HttpRequest, id: str):
+class EcoAccountReportView(BaseCompensationReportView):
-    """ Renders the public report view
+    _MODEL = EcoAccount
+    _TEMPLATE = "compensation/report/eco_account/report.html"
 
-    Args:
+    def _get_report_context(self, obj):
-        request (HttpRequest): The incoming request
+        report_url = BASE_URL + reverse("compensation:acc:report", args=(obj.id,))
-        id (str): The id of the intervention
+        qrcode_report = QrCode(report_url, 10)
+        qrcode_lanis = QrCode(obj.get_LANIS_link(), 7)
 
-    Returns:
+        # Reduce amount of db fetched data to the bare minimum we need in the template (deduction's intervention id and identifier)
+        deductions = obj.deductions.all() \
+            .distinct("intervention") \
+            .select_related("intervention") \
+            .values_list("intervention__id", "intervention__identifier", "intervention__title", named=True)
 
-    """
+        report_context = {
-    # Reuse the compensation report template since EcoAccounts are structurally identical
+            "qrcode": {
-    template = "compensation/report/eco_account/report.html"
+                "img": qrcode_report.get_img(),
-    acc = get_object_or_404(EcoAccount, id=id)
+                "url": qrcode_report.get_content(),
-
+            },
-    tab_title = _("Report {}").format(acc.identifier)
+            "qrcode_lanis": {
-    # If intervention is not recorded (yet or currently) we need to render another template without any data
+                "img": qrcode_lanis.get_img(),
-    if not acc.is_ready_for_publish():
+                "url": qrcode_lanis.get_content(),
-        template = "report/unavailable.html"
+            },
-        context = {
+            "is_entry_shared": False,  # disables action buttons during rendering
-            TAB_TITLE_IDENTIFIER: tab_title,
+            "deductions": deductions,
+            "tables_scrollable": False,
         }
-        context = BaseContext(request, context).context
+        report_context.update(self._get_compensation_report_context(obj))
-        return render(request, template, context)
+        return report_context
-
-    # Prepare data for map viewer
-    geom_form = SimpleGeomForm(
-        instance=acc
-    )
-    parcels = acc.get_underlying_parcels()
-
-    qrcode_url = request.build_absolute_uri(reverse("compensation:acc:report", args=(id,)))
-    qrcode_img = generate_qr_code(qrcode_url, 10)
-    qrcode_lanis_url = acc.get_LANIS_link()
-    qrcode_img_lanis = generate_qr_code(qrcode_lanis_url, 7)
-
-    # Order states by surface
-    before_states = acc.before_states.all().order_by("-surface").select_related("biotope_type__parent")
-    after_states = acc.after_states.all().order_by("-surface").select_related("biotope_type__parent")
-    actions = acc.actions.all().prefetch_related("action_type__parent")
-
-    # Reduce amount of db fetched data to the bare minimum we need in the template (deduction's intervention id and identifier)
-    deductions = acc.deductions.all()\
-        .distinct("intervention")\
-        .select_related("intervention")\
-        .values_list("intervention__id", "intervention__identifier", "intervention__title", named=True)
-
-    context = {
-        "obj": acc,
-        "qrcode": {
-            "img": qrcode_img,
-            "url": qrcode_url,
-        },
-        "qrcode_lanis": {
-            "img": qrcode_img_lanis,
-            "url": qrcode_lanis_url,
-        },
-        "is_entry_shared": False,  # disables action buttons during rendering
-        "before_states": before_states,
-        "after_states": after_states,
-        "geom_form": geom_form,
-        "parcels": parcels,
-        "actions": actions,
-        "deductions": deductions,
-        "tables_scrollable": False,
-        TAB_TITLE_IDENTIFIER: tab_title,
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)

compensation/views/eco_account/resubmission.py

@@ -5,22 +5,12 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from compensation.forms.modals.resubmission import EcoAccountResubmissionModalForm
-from django.utils.decorators import method_decorator
-
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.resubmission import AbstractResubmissionView
 
 
 class EcoAccountResubmissionView(AbstractResubmissionView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url_base = "compensation:acc:detail"
+    _FORM_CLS = EcoAccountResubmissionModalForm
-    form_action_url_base = "compensation:acc:resubmission-create"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/share.py

@@ -5,29 +5,15 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.share import AbstractShareByTokenView, AbstractShareFormView
 
 
 class EcoAccountShareByTokenView(AbstractShareByTokenView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required)
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EcoAccountShareFormView(AbstractShareFormView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-
+    _REDIRECT_URL = "compensation:acc:detail"
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/eco_account/state.py

@@ -5,46 +5,21 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from compensation.models import EcoAccount
-from konova.decorators import shared_access_required, default_group_required, login_required_modal
 from konova.views.state import AbstractNewCompensationStateView, AbstractEditCompensationStateView, \
     AbstractRemoveCompensationStateView
 
 
 class NewEcoAccountStateView(AbstractNewCompensationStateView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditEcoAccountStateView(AbstractEditCompensationStateView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEcoAccountStateView(AbstractRemoveCompensationStateView):
-    model = EcoAccount
+    _MODEL_CLS = EcoAccount
-    redirect_url = "compensation:acc:detail"
+    _REDIRECT_URL = "compensation:acc:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(EcoAccount, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

compensation/views/payment.py

@@ -5,84 +5,38 @@ Contact: michel.peltriaux@sgdnord.rlp.de
 Created on: 09.08.21
 
 """
-from django.urls import reverse
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.contrib.auth.decorators import login_required
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404
 
 from compensation.forms.modals.payment import NewPaymentForm, RemovePaymentModalForm, EditPaymentModalForm
-from compensation.models import Payment
 from intervention.models import Intervention
-from konova.decorators import default_group_required, shared_access_required
 from konova.utils.message_templates import PAYMENT_ADDED, PAYMENT_REMOVED, PAYMENT_EDITED
+from konova.views.base import BaseModalFormView
 
 
-@login_required
+class BasePaymentView(LoginRequiredMixin, BaseModalFormView):
-@default_group_required
+    _MODEL_CLS = Intervention
-@shared_access_required(Intervention, "id")
+    _REDIRECT_URL = "intervention:detail"
-def new_payment_view(request: HttpRequest, id: str):
-    """ Renders a modal view for adding new payments
 
-    Args:
+    class Meta:
-        request (HttpRequest): The incoming request
+        abstract = True
-        id (str): The intervention's id for which a new payment shall be added
 
-    Returns:
+    def _get_redirect_url(self, *args, **kwargs):
+        url = super()._get_redirect_url(*args, **kwargs)
+        return f"{url}#related_data"
 
-    """
+    def _user_has_permission(self, user, **kwargs):
-    intervention = get_object_or_404(Intervention, id=id)
+        return user.is_default_user()
-    form = NewPaymentForm(request.POST or None, instance=intervention, request=request)
-    return form.process_request(
-        request,
-        msg_success=PAYMENT_ADDED,
-        redirect_url=reverse("intervention:detail", args=(id,)) + "#related_data"
-    )
 
 
-@login_required
+class NewPaymentView(BasePaymentView):
-@default_group_required
+    _FORM_CLS = NewPaymentForm
-@shared_access_required(Intervention, "id")
+    _MSG_SUCCESS = PAYMENT_ADDED
-def payment_remove_view(request: HttpRequest, id: str, payment_id: str):
-    """ Renders a modal view for removing payments
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The intervention's id
-        payment_id (str): The payment's id
-
-    Returns:
-
-    """
-    intervention = get_object_or_404(Intervention, id=id)
-    payment = get_object_or_404(Payment, id=payment_id)
-    form = RemovePaymentModalForm(request.POST or None, instance=intervention, payment=payment, request=request)
-    return form.process_request(
-        request=request,
-        msg_success=PAYMENT_REMOVED,
-        redirect_url=reverse("intervention:detail", args=(payment.intervention_id,)) + "#related_data"
-    )
 
 
-@login_required
+class EditPaymentView(BasePaymentView):
-@default_group_required
+    _MSG_SUCCESS = PAYMENT_EDITED
-@shared_access_required(Intervention, "id")
+    _FORM_CLS = EditPaymentModalForm
-def payment_edit_view(request: HttpRequest, id: str, payment_id: str):
-    """ Renders a modal view for editing payments
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The intervention's id
-        payment_id (str): The payment's id
-
-    Returns:
-
-    """
-    intervention = get_object_or_404(Intervention, id=id)
-    payment = get_object_or_404(Payment, id=payment_id)
-    form = EditPaymentModalForm(request.POST or None, instance=intervention, payment=payment, request=request)
-    return form.process_request(
-        request=request,
-        msg_success=PAYMENT_EDITED,
-        redirect_url=reverse("intervention:detail", args=(payment.intervention_id,)) + "#related_data"
-    )
 
+class RemovePaymentView(BasePaymentView):
+    _MSG_SUCCESS = PAYMENT_REMOVED
+    _FORM_CLS = RemovePaymentModalForm

ema/forms.py

@@ -15,7 +15,8 @@ from compensation.forms.compensation import AbstractCompensationForm
 from ema.models import Ema, EmaDocument
 from intervention.models import Responsibility, Handler
 from konova.forms import SimpleGeomForm
-from konova.forms.modals import NewDocumentModalForm
+from konova.forms.modals import NewDocumentModalForm, EditDocumentModalForm, RemoveDocumentModalForm, \
+    ResubmissionModalForm
 from user.models import UserActionLogEntry
 
 
@@ -170,4 +171,13 @@ class EditEmaForm(NewEmaForm):
 
 
 class NewEmaDocumentModalForm(NewDocumentModalForm):
-    document_model = EmaDocument
+    _DOCUMENT_CLS = EmaDocument
+
+class EditEmaDocumentModalForm(EditDocumentModalForm):
+    _DOCUMENT_CLS = EmaDocument
+
+class RemoveEmaDocumentModalForm(RemoveDocumentModalForm):
+    _DOCUMENT_CLS = EmaDocument
+
+class EmaResubmissionModalForm(ResubmissionModalForm):
+    _MODEL_CLS = Ema

ema/tests/test_workflow.py

@@ -46,7 +46,7 @@ class EmaWorkflowTestCase(BaseWorkflowTestCase):
         post_data = {
             "identifier": test_id,
             "title": test_title,
-            "geom": geom_json,
+            "output": geom_json,
             "conservation_office": test_conservation_office.id
         }
         self.client_user.post(new_url, post_data)
@@ -84,7 +84,7 @@ class EmaWorkflowTestCase(BaseWorkflowTestCase):
         new_title = self.create_dummy_string()
         new_identifier = self.create_dummy_string()
         new_comment = self.create_dummy_string()
-        new_geometry = MultiPolygon(srid=4326)  # Create an empty geometry
+        new_geometry = self.create_dummy_geometry()  # Create an empty geometry
         test_conservation_office = self.get_conservation_office_code()
 
         check_on_elements = {
@@ -99,7 +99,7 @@ class EmaWorkflowTestCase(BaseWorkflowTestCase):
             "identifier": new_identifier,
             "title": new_title,
             "comment": new_comment,
-            "geom": new_geometry.geojson,
+            "output": self.create_geojson(new_geometry),
             "conservation_office": test_conservation_office.id
         }
         self.client_user.post(url, post_data)

ema/tests/unit/test_forms.py

@@ -48,7 +48,7 @@ class NewEmaFormTestCase(BaseTestCase):
         )
         geom_form_data = json.loads(geom_form_data)
         geom_form_data = {
-            "geom": json.dumps(geom_form_data)
+            "output": json.dumps(geom_form_data)
         }
 
         geom_form = SimpleGeomForm(geom_form_data)
@@ -116,7 +116,7 @@ class EditEmaFormTestCase(BaseTestCase):
         )
         geom_form_data = json.loads(geom_form_data)
         geom_form_data = {
-            "geom": json.dumps(geom_form_data)
+            "output": json.dumps(geom_form_data)
         }
 
         geom_form = SimpleGeomForm(geom_form_data)

ema/urls.py

@@ -10,25 +10,26 @@ from django.urls import path
 from ema.views.action import NewEmaActionView, EditEmaActionView, RemoveEmaActionView
 from ema.views.deadline import NewEmaDeadlineView, EditEmaDeadlineView, RemoveEmaDeadlineView
 from ema.views.document import NewEmaDocumentView, EditEmaDocumentView, RemoveEmaDocumentView, GetEmaDocumentView
-from ema.views.ema import index_view, new_view, new_id_view, detail_view, edit_view, remove_view
+from ema.views.ema import EmaIndexView, EmaIdentifierGeneratorView, EmaDetailView, EditEmaFormView, NewEmaFormView, \
+    RemoveEmaView
 from ema.views.log import EmaLogView
 from ema.views.record import EmaRecordView
-from ema.views.report import report_view
+from ema.views.report import EmaReportView
 from ema.views.resubmission import EmaResubmissionView
 from ema.views.share import EmaShareFormView, EmaShareByTokenView
 from ema.views.state import NewEmaStateView, EditEmaStateView, RemoveEmaStateView
 
 app_name = "ema"
 urlpatterns = [
-    path("", index_view, name="index"),
+    path("", EmaIndexView.as_view(), name="index"),
-    path("new/", new_view, name="new"),
+    path("new/", NewEmaFormView.as_view(), name="new"),
-    path("new/id", new_id_view, name="new-id"),
+    path("new/id", EmaIdentifierGeneratorView.as_view(), name="new-id"),
-    path("<id>", detail_view, name="detail"),
+    path("<id>", EmaDetailView.as_view(), name="detail"),
     path('<id>/log', EmaLogView.as_view(), name='log'),
-    path('<id>/edit', edit_view, name='edit'),
+    path('<id>/edit', EditEmaFormView.as_view(), name='edit'),
-    path('<id>/remove', remove_view, name='remove'),
+    path('<id>/remove', RemoveEmaView.as_view(), name='remove'),
     path('<id>/record', EmaRecordView.as_view(), name='record'),
-    path('<id>/report', report_view, name='report'),
+    path('<id>/report', EmaReportView.as_view(), name='report'),
     path('<id>/resub', EmaResubmissionView.as_view(), name='resubmission-create'),
 
     path('<id>/state/new', NewEmaStateView.as_view(), name='new-state'),

ema/views/action.py

@@ -5,46 +5,31 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
 
 from ema.models import Ema
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
 from konova.views.action import AbstractNewCompensationActionView, AbstractEditCompensationActionView, \
     AbstractRemoveCompensationActionView
 
+_EMA_ACCOUNT_DETAIL_URL_NAME = "ema:detail"
 
 class NewEmaActionView(AbstractNewCompensationActionView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = _EMA_ACCOUNT_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_ets_user()
 
 class EditEmaActionView(AbstractEditCompensationActionView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = _EMA_ACCOUNT_DETAIL_URL_NAME
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEmaActionView(AbstractRemoveCompensationActionView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = _EMA_ACCOUNT_DETAIL_URL_NAME
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

ema/views/deadline.py

@@ -5,46 +5,30 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from ema.models import Ema
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
 from konova.views.deadline import AbstractNewDeadlineView, AbstractRemoveDeadlineView, AbstractEditDeadlineView
 
+_EMA_DETAIL_URL_NAME = "ema:detail"
 
 class NewEmaDeadlineView(AbstractNewDeadlineView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = _EMA_DETAIL_URL_NAME
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditEmaDeadlineView(AbstractEditDeadlineView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = _EMA_DETAIL_URL_NAME
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEmaDeadlineView(AbstractRemoveDeadlineView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = _EMA_DETAIL_URL_NAME
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_ets_user()

ema/views/document.py

@@ -5,62 +5,41 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from ema.forms import NewEmaDocumentModalForm, RemoveEmaDocumentModalForm, EditEmaDocumentModalForm
-from django.utils.decorators import method_decorator
-
-from ema.forms import NewEmaDocumentModalForm
 from ema.models import Ema, EmaDocument
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
-from konova.forms.modals import EditDocumentModalForm
 from konova.views.document import AbstractEditDocumentView, AbstractRemoveDocumentView, AbstractGetDocumentView, \
     AbstractNewDocumentView
 
 
 class NewEmaDocumentView(AbstractNewDocumentView):
-    model = Ema
+    _MODEL_CLS = Ema
-    form = NewEmaDocumentModalForm
+    _FORM_CLS = NewEmaDocumentModalForm
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = "ema:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_ets_user()
 
 class GetEmaDocumentView(AbstractGetDocumentView):
-    model = Ema
+    _MODEL_CLS = Ema
-    document_model = EmaDocument
+    _DOCUMENT_CLS = EmaDocument
-
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_ets_user()
 
 class RemoveEmaDocumentView(AbstractRemoveDocumentView):
-    model = Ema
+    _MODEL_CLS = Ema
-    document_model = EmaDocument
+    _DOCUMENT_CLS = EmaDocument
-
+    _FORM_CLS = RemoveEmaDocumentModalForm
-    @method_decorator(login_required_modal)
+    _REDIRECT_URL = "ema:detail"
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_ets_user()
 
 class EditEmaDocumentView(AbstractEditDocumentView):
-    model = Ema
+    _MODEL_CLS = Ema
-    document_model = EmaDocument
+    _FORM_CLS = EditEmaDocumentModalForm
-    form = EditDocumentModalForm
+    _DOCUMENT_CLS = EmaDocument
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = "ema:detail"
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

ema/views/ema.py

@@ -5,255 +5,112 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib import messages
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.contrib.auth.decorators import login_required
+from django.shortcuts import get_object_or_404
-from django.db.models import Sum
-from django.http import HttpRequest, JsonResponse
-from django.shortcuts import get_object_or_404, redirect, render
-from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
 
 from ema.forms import NewEmaForm, EditEmaForm
 from ema.models import Ema
 from ema.tables import EmaTable
-from konova.contexts import BaseContext
+from konova.views.base import BaseIndexView, BaseIdentifierGeneratorView, BaseNewSpatialLocatedObjectFormView, \
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal, \
+    BaseEditSpatialLocatedObjectFormView
-    uuid_required
+from konova.views.detail import BaseDetailView
-from konova.forms import SimpleGeomForm
+from konova.views.remove import BaseRemoveModalFormView
-from konova.forms.modals import RemoveModalForm
-from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
-from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
-from konova.utils.message_templates import RECORDED_BLOCKS_EDIT, IDENTIFIER_REPLACED, FORM_INVALID, \
-    DO_NOT_FORGET_TO_SHARE, GEOMETRY_SIMPLIFIED
 
 
-@login_required
+class EmaIndexView(LoginRequiredMixin, BaseIndexView):
-def index_view(request: HttpRequest):
+    _TAB_TITLE = _("EMAs - Overview")
-    """ Renders the index view for EMAs
+    _INDEX_TABLE_CLS = EmaTable
 
-    Args:
+    def _get_queryset(self):
-        request (HttpRequest): The incoming request
+        qs = Ema.objects.filter(
-
+            deleted=None,
-    Returns:
+        ).order_by(
-
+            "-modified__timestamp"
-    """
+        )
-    template = "generic_index.html"
+        return qs
-    emas = Ema.objects.filter(
-        deleted=None,
-    ).order_by(
-        "-modified__timestamp"
-    )
-
-    table = EmaTable(
-        request,
-        queryset=emas
-    )
-    context = {
-        "table": table,
-        TAB_TITLE_IDENTIFIER: _("EMAs - Overview"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
-@login_required
+class NewEmaFormView(BaseNewSpatialLocatedObjectFormView):
-@conservation_office_group_required
+    _FORM_CLS = NewEmaForm
-def new_view(request: HttpRequest):
+    _MODEL_CLS = Ema
-    """
+    _TEMPLATE = "ema/form/view.html"
-    Renders a view for a new eco account creation
+    _TAB_TITLE = _("New EMA")
+    _REDIRECT_URL = "ema:detail"
 
-    Args:
+    def _user_has_permission(self, user, **kwargs):
-        request (HttpRequest): The incoming request
+        # User has to be an ets user
-
+        return user.is_ets_user()
-    Returns:
-
-    """
-    template = "ema/form/view.html"
-    data_form = NewEmaForm(request.POST or None)
-    geom_form = SimpleGeomForm(request.POST or None, read_only=False)
-    if request.method == "POST":
-        if data_form.is_valid() and geom_form.is_valid():
-            generated_identifier = data_form.cleaned_data.get("identifier", None)
-            ema = data_form.save(request.user, geom_form)
-            if generated_identifier != ema.identifier:
-                messages.info(
-                    request,
-                    IDENTIFIER_REPLACED.format(
-                        generated_identifier,
-                        ema.identifier
-                    )
-                )
-            messages.success(request, _("EMA {} added").format(ema.identifier))
-            if geom_form.geometry_simplified:
-                messages.info(
-                    request,
-                    GEOMETRY_SIMPLIFIED
-                )
-
-            return redirect("ema:detail", id=ema.id)
-        else:
-            messages.error(request, FORM_INVALID, extra_tags="danger",)
-    else:
-        # For clarification: nothing in this case
-        pass
-    context = {
-        "form": data_form,
-        "geom_form": geom_form,
-        TAB_TITLE_IDENTIFIER: _("New EMA"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
-@login_required
+class EditEmaFormView(BaseEditSpatialLocatedObjectFormView):
-@conservation_office_group_required
+    _MODEL_CLS = Ema
-def new_id_view(request: HttpRequest):
+    _FORM_CLS = EditEmaForm
-    """ JSON endpoint
+    _TEMPLATE = "ema/form/view.html"
+    _REDIRECT_URL = "ema:detail"
+    _TAB_TITLE = _("Edit {}")
 
-    Provides fetching of free identifiers for e.g. AJAX calls
+    def _user_has_permission(self, user, **kwargs):
+        # User has to be an ets user
+        return user.is_ets_user()
 
-    """
+
-    tmp = Ema()
+class EmaIdentifierGeneratorView(LoginRequiredMixin, BaseIdentifierGeneratorView):
-    identifier = tmp.generate_new_identifier()
+    _MODEL_CLS = Ema
-    while Ema.objects.filter(identifier=identifier).exists():
+    _REDIRECT_URL = "ema:index"
-        identifier = tmp.generate_new_identifier()
+
-    return JsonResponse(
+    def _user_has_permission(self, user, **kwargs):
-        data={
+        return user.is_ets_user()
-            "gen_data": identifier
+
+
+class EmaDetailView(BaseDetailView):
+    _MODEL_CLS = Ema
+    _TEMPLATE = "ema/detail/view.html"
+
+    def _get_object(self, id: str):
+        """ Fetch object for detail view
+
+        Args:
+            id (str): The record's id'
+
+        Returns:
+
+        """
+        ema = get_object_or_404(Ema, id=id, deleted=None)
+        return ema
+
+    def _get_detail_context(self, obj: Ema):
+        """ Generate object specific detail context for  view
+
+        Args:
+            obj (): The record
+
+        Returns:
+
+        """
+        # Order states according to surface
+        before_states = obj.before_states.all().order_by("-surface")
+        after_states = obj.after_states.all().order_by("-surface")
+
+        # Precalculate logical errors between before- and after-states
+        # Sum() returns None in case of no states, so we catch that and replace it with 0 for easier handling
+        sum_before_states = obj.get_surface_before_states()
+        sum_after_states = obj.get_surface_after_states()
+        diff_states = abs(sum_before_states - sum_after_states)
+
+        context = {
+            "before_states": before_states,
+            "after_states": after_states,
+            "sum_before_states": sum_before_states,
+            "sum_after_states": sum_after_states,
+            "diff_states": diff_states,
+            "has_finished_deadlines": obj.get_finished_deadlines().exists(),
         }
-    )
+        return context
 
+class RemoveEmaView(LoginRequiredMixin, BaseRemoveModalFormView):
+    _MODEL_CLS = Ema
+    _REDIRECT_URL = "ema:index"
 
-@login_required
+    def _user_has_permission(self, user, **kwargs):
-@uuid_required
+        return user.is_ets_user()
-def detail_view(request: HttpRequest, id: str):
-    """ Renders the detail view of an EMA
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The EMA id
-
-    Returns:
-
-    """
-    template = "ema/detail/view.html"
-    ema = get_object_or_404(Ema, id=id, deleted=None)
-
-    geom_form = SimpleGeomForm(instance=ema)
-    parcels = ema.get_underlying_parcels()
-    _user = request.user
-    is_entry_shared = ema.is_shared_with(_user)
-
-    # Order states according to surface
-    before_states = ema.before_states.all().order_by("-surface")
-    after_states = ema.after_states.all().order_by("-surface")
-
-    # Precalculate logical errors between before- and after-states
-    # Sum() returns None in case of no states, so we catch that and replace it with 0 for easier handling
-    sum_before_states = ema.get_surface_before_states()
-    sum_after_states = ema.get_surface_after_states()
-    diff_states = abs(sum_before_states - sum_after_states)
-
-    ema.set_status_messages(request)
-
-    requesting_user_is_only_shared_user = ema.is_only_shared_with(_user)
-    if requesting_user_is_only_shared_user:
-        messages.info(
-            request,
-            DO_NOT_FORGET_TO_SHARE
-        )
-
-    context = {
-        "obj": ema,
-        "geom_form": geom_form,
-        "parcels": parcels,
-        "is_entry_shared": is_entry_shared,
-        "before_states": before_states,
-        "after_states": after_states,
-        "sum_before_states": sum_before_states,
-        "sum_after_states": sum_after_states,
-        "diff_states": diff_states,
-        "is_default_member": _user.in_group(DEFAULT_GROUP),
-        "is_zb_member": _user.in_group(ZB_GROUP),
-        "is_ets_member": _user.in_group(ETS_GROUP),
-        "LANIS_LINK": ema.get_LANIS_link(),
-        TAB_TITLE_IDENTIFIER: f"{ema.identifier} - {ema.title}",
-        "has_finished_deadlines": ema.get_finished_deadlines().exists(),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
-
-
-@login_required
-@conservation_office_group_required
-@shared_access_required(Ema, "id")
-def edit_view(request: HttpRequest, id: str):
-    """
-    Renders a view for editing compensations
-
-    Args:
-        request (HttpRequest): The incoming request
-
-    Returns:
-
-    """
-    template = "compensation/form/view.html"
-    # Get object from db
-    ema = get_object_or_404(Ema, id=id)
-    if ema.is_recorded:
-        messages.info(
-            request,
-            RECORDED_BLOCKS_EDIT
-        )
-        return redirect("ema:detail", id=id)
-
-    # Create forms, initialize with values from db/from POST request
-    data_form = EditEmaForm(request.POST or None, instance=ema)
-    geom_form = SimpleGeomForm(request.POST or None, read_only=False, instance=ema)
-    if request.method == "POST":
-        if data_form.is_valid() and geom_form.is_valid():
-            # The data form takes the geom form for processing, as well as the performing user
-            ema = data_form.save(request.user, geom_form)
-            messages.success(request, _("EMA {} edited").format(ema.identifier))
-            if geom_form.geometry_simplified:
-                messages.info(
-                    request,
-                    GEOMETRY_SIMPLIFIED
-                )
-            return redirect("ema:detail", id=ema.id)
-        else:
-            messages.error(request, FORM_INVALID, extra_tags="danger",)
-    else:
-        # For clarification: nothing in this case
-        pass
-    context = {
-        "form": data_form,
-        "geom_form": geom_form,
-        TAB_TITLE_IDENTIFIER: _("Edit {}").format(ema.identifier),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
-
-
-@login_required_modal
-@login_required
-@conservation_office_group_required
-@shared_access_required(Ema, "id")
-def remove_view(request: HttpRequest, id: str):
-    """ Renders a modal view for removing the EMA
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The EMA's id
-
-    Returns:
-
-    """
-    ema = get_object_or_404(Ema, id=id)
-    form = RemoveModalForm(request.POST or None, instance=ema, request=request)
-    return form.process_request(
-        request=request,
-        msg_success=_("EMA removed"),
-        redirect_url=reverse("ema:index"),
-    )
-

ema/views/log.py

@@ -5,20 +5,14 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from ema.models import Ema
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
 from konova.views.log import AbstractLogView
 
 
-class EmaLogView(AbstractLogView):
+class EmaLogView(LoginRequiredMixin, AbstractLogView):
-    model = Ema
+    _MODEL_CLS = Ema
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

ema/views/record.py

@@ -5,20 +5,12 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from ema.models import Ema
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
 from konova.views.record import AbstractRecordView
 
 
-class EmaRecordView(AbstractRecordView):
+class EmaRecordView(LoginRequiredMixin, AbstractRecordView):
-    model = Ema
+    _MODEL_CLS = Ema
-
+    _REDIRECT_URL = "ema:detail"
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

ema/views/report.py

@@ -5,76 +5,36 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404, render
 from django.urls import reverse
-from django.utils.translation import gettext_lazy as _
 
+from compensation.views.compensation.report import BaseCompensationReportView
 from ema.models import Ema
-from konova.contexts import BaseContext
+from konova.sub_settings.django_settings import BASE_URL
-from konova.forms import SimpleGeomForm
+from konova.utils.qrcode import QrCode
-from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
-from konova.utils.generators import generate_qr_code
 
 
-def report_view(request:HttpRequest, id: str):
+class EmaReportView(BaseCompensationReportView):
-    """ Renders the public report view
+    _TEMPLATE = "ema/report/report.html"
+    _MODEL = Ema
 
-    Args:
+    def _get_report_context(self, obj):
-        request (HttpRequest): The incoming request
+        report_url = BASE_URL + reverse("ema:report", args=(obj.id,))
-        id (str): The id of the intervention
+        qrcode_report = QrCode(report_url, 10)
+        qrcode_lanis = QrCode(obj.get_LANIS_link(), 7)
 
-    Returns:
+        generic_compensation_report_context = self._get_compensation_report_context(obj)
 
-    """
+        report_context = {
-    # Reuse the compensation report template since EMAs are structurally identical
+            "qrcode": {
-    template = "ema/report/report.html"
+                "img": qrcode_report.get_img(),
-    ema = get_object_or_404(Ema, id=id)
+                "url": qrcode_report.get_content(),
-
+            },
-    tab_title = _("Report {}").format(ema.identifier)
+            "qrcode_lanis": {
-    # If intervention is not recorded (yet or currently) we need to render another template without any data
+                "img": qrcode_lanis.get_img(),
-    if not ema.is_ready_for_publish():
+                "url": qrcode_lanis.get_content(),
-        template = "report/unavailable.html"
+            },
-        context = {
+            "is_entry_shared": False,  # disables action buttons during rendering
-            TAB_TITLE_IDENTIFIER: tab_title,
+            "tables_scrollable": False,
         }
-        context = BaseContext(request, context).context
+        report_context.update(generic_compensation_report_context)
-        return render(request, template, context)
+        return report_context
-
-    # Prepare data for map viewer
-    geom_form = SimpleGeomForm(
-        instance=ema,
-    )
-    parcels = ema.get_underlying_parcels()
-
-    qrcode_url = request.build_absolute_uri(reverse("ema:report", args=(id,)))
-    qrcode_img = generate_qr_code(qrcode_url, 10)
-    qrcode_lanis_url = ema.get_LANIS_link()
-    qrcode_img_lanis = generate_qr_code(qrcode_lanis_url, 7)
-
-    # Order states by surface
-    before_states = ema.before_states.all().order_by("-surface").prefetch_related("biotope_type")
-    after_states = ema.after_states.all().order_by("-surface").prefetch_related("biotope_type")
-    actions = ema.actions.all().prefetch_related("action_type")
-
-    context = {
-        "obj": ema,
-        "qrcode": {
-            "img": qrcode_img,
-            "url": qrcode_url
-        },
-        "qrcode_lanis": {
-            "img": qrcode_img_lanis,
-            "url": qrcode_lanis_url
-        },
-        "is_entry_shared": False,  # disables action buttons during rendering
-        "before_states": before_states,
-        "after_states": after_states,
-        "geom_form": geom_form,
-        "parcels": parcels,
-        "actions": actions,
-        "tables_scrollable": False,
-        TAB_TITLE_IDENTIFIER: tab_title,
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)

ema/views/resubmission.py

@@ -5,22 +5,16 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from ema.forms import EmaResubmissionModalForm
-from django.utils.decorators import method_decorator
-
 from ema.models import Ema
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
 from konova.views.resubmission import AbstractResubmissionView
 
 
 class EmaResubmissionView(AbstractResubmissionView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url_base = "ema:detail"
+    _FORM_CLS = EmaResubmissionModalForm
-    form_action_url_base = "ema:resubmission-create"
+    _REDIRECT_URL = "ema:detail"
+    action_url = "ema:resubmission-create"
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

ema/views/share.py

@@ -5,29 +5,17 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from ema.models import Ema
-from konova.decorators import conservation_office_group_required, shared_access_required, login_required_modal
 from konova.views.share import AbstractShareByTokenView, AbstractShareFormView
 
 
 class EmaShareByTokenView(AbstractShareByTokenView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = "ema:detail"
-
-    @method_decorator(login_required)
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
-
 
 class EmaShareFormView(AbstractShareFormView):
-    model = Ema
+    _MODEL_CLS = Ema
+    _REDIRECT_URL = "ema:detail"
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

ema/views/state.py

@@ -5,46 +5,30 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from ema.models import Ema
-from konova.decorators import conservation_office_group_required, shared_access_required, login_required_modal
 from konova.views.state import AbstractNewCompensationStateView, AbstractEditCompensationStateView, \
     AbstractRemoveCompensationStateView
 
 
 class NewEmaStateView(AbstractNewCompensationStateView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = "ema:detail"
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class EditEmaStateView(AbstractEditCompensationStateView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = "ema:detail"
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveEmaStateView(AbstractRemoveCompensationStateView):
-    model = Ema
+    _MODEL_CLS = Ema
-    redirect_url = "ema:detail"
+    _REDIRECT_URL = "ema:detail"
 
-    @method_decorator(login_required_modal)
+    def _user_has_permission(self, user, **kwargs):
-    @method_decorator(login_required)
+        return user.is_ets_user()
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Ema, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

intervention/forms/modals/deduction.py

@@ -172,7 +172,8 @@ class EditEcoAccountDeductionModalForm(NewEcoAccountDeductionModalForm):
     deduction = None
 
     def __init__(self, *args, **kwargs):
-        self.deduction = kwargs.pop("deduction", None)
+        deduction_id = kwargs.pop("deduction_id", None)
+        self.deduction = EcoAccountDeduction.objects.get(id=deduction_id)
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit Deduction")
         form_data = {
@@ -252,19 +253,20 @@ class RemoveEcoAccountDeductionModalForm(RemoveModalForm):
     Can be used for anything, where removing shall be confirmed by the user a second time.
 
     """
-    deduction = None
+    _DEDUCTION_OBJ = None
 
     def __init__(self, *args, **kwargs):
-        deduction = kwargs.pop("deduction", None)
+        deduction_id = kwargs.pop("deduction_id", None)
-        self.deduction = deduction
+        deduction = EcoAccountDeduction.objects.get(id=deduction_id)
+        self._DEDUCTION_OBJ = deduction
         super().__init__(*args, **kwargs)
 
     def save(self):
         with transaction.atomic():
-            self.deduction.intervention.mark_as_edited(self.user, edit_comment=DEDUCTION_REMOVED)
+            self._DEDUCTION_OBJ.intervention.mark_as_edited(self.user, edit_comment=DEDUCTION_REMOVED)
-            self.deduction.account.mark_as_edited(self.user, edit_comment=DEDUCTION_REMOVED)
+            self._DEDUCTION_OBJ.account.mark_as_edited(self.user, edit_comment=DEDUCTION_REMOVED)
-            self.deduction.delete()
+            self._DEDUCTION_OBJ.delete()
 
     def check_for_recorded_instance(self):
-        if self.deduction.intervention.is_recorded:
+        if self._DEDUCTION_OBJ.intervention.is_recorded:
             self.block_form()

intervention/forms/modals/document.py

@@ -6,11 +6,11 @@ Created on: 18.08.22
 
 """
 from intervention.models import InterventionDocument
-from konova.forms.modals import NewDocumentModalForm
+from konova.forms.modals import NewDocumentModalForm, EditDocumentModalForm, RemoveDocumentModalForm
 
 
 class NewInterventionDocumentModalForm(NewDocumentModalForm):
-    document_model = InterventionDocument
+    _DOCUMENT_CLS = InterventionDocument
 
     def save(self, *args, **kwargs):
         """ Extension of regular NewDocumentModalForm
@@ -28,3 +28,31 @@ class NewInterventionDocumentModalForm(NewDocumentModalForm):
         self.instance.send_data_to_egon()
 
         return doc
+
+class EditInterventionDocumentModalForm(EditDocumentModalForm):
+    _DOCUMENT_CLS = InterventionDocument
+
+    def save(self, *args, **kwargs):
+        """ Extension of regular EditDocumentModalForm
+
+        Checks whether payments exist on the intervention and sends the data to EGON
+
+        Args:
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        doc = super().save(*args, **kwargs)
+        self.instance.send_data_to_egon()
+
+        return doc
+
+
+class RemoveInterventionDocumentModalForm(RemoveDocumentModalForm):
+    _DOCUMENT_CLS = InterventionDocument
+
+    def save(self, *args, **kwargs):
+        super().save(*args, **kwargs)
+        self.instance.send_data_to_egon()

intervention/forms/modals/resubmission.py

@@ -0,0 +1,11 @@
+"""
+Author: Michel Peltriaux
+Created on: 21.10.25
+
+"""
+from intervention.models import Intervention
+from konova.forms.modals import ResubmissionModalForm
+
+
+class InterventionResubmissionModalForm(ResubmissionModalForm):
+    _MODEL_CLS = Intervention

intervention/forms/modals/revocation.py

@@ -7,9 +7,10 @@ Created on: 18.08.22
 """
 from django import forms
 from django.core.exceptions import ObjectDoesNotExist
+from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
-from intervention.models import RevocationDocument
+from intervention.models import RevocationDocument, Revocation
 from konova.forms.modals import BaseModalForm, RemoveModalForm
 from konova.utils import validators
 from konova.utils.message_templates import REVOCATION_ADDED, REVOCATION_EDITED
@@ -75,7 +76,8 @@ class EditRevocationModalForm(NewRevocationModalForm):
     revocation = None
 
     def __init__(self, *args, **kwargs):
-        self.revocation = kwargs.pop("revocation", None)
+        revocation_id = kwargs.pop("revocation_id", None)
+        self.revocation = get_object_or_404(Revocation, id=revocation_id)
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit revocation")
         try:
@@ -104,8 +106,8 @@ class RemoveRevocationModalForm(RemoveModalForm):
     revocation = None
 
     def __init__(self, *args, **kwargs):
-        revocation = kwargs.pop("revocation", None)
+        revocation_id = kwargs.pop("revocation_id", None)
-        self.revocation = revocation
+        self.revocation = get_object_or_404(Revocation, id=revocation_id)
         super().__init__(*args, **kwargs)
 
     def save(self):

intervention/tests/test_workflow.py

@@ -60,7 +60,7 @@ class InterventionWorkflowTestCase(BaseWorkflowTestCase):
         post_data = {
             "identifier": test_id,
             "title": test_title,
-            "geom": geom_json,
+            "output": geom_json,
         }
         response = self.client_user.post(
             new_url,

intervention/tests/unit/test_forms.py

@@ -62,7 +62,7 @@ class NewInterventionFormTestCase(BaseTestCase):
         )
         geom_form_data = json.loads(geom_form_data)
         geom_form_data = {
-            "geom": json.dumps(geom_form_data)
+            "output": json.dumps(geom_form_data)
         }
         geom_form = SimpleGeomForm(geom_form_data)
 
@@ -104,7 +104,7 @@ class EditInterventionFormTestCase(NewInterventionFormTestCase):
         )
         geom_form_data = json.loads(geom_form_data)
         geom_form_data = {
-            "geom": json.dumps(geom_form_data)
+            "output": json.dumps(geom_form_data)
         }
 
         geom_form = SimpleGeomForm(geom_form_data)
@@ -124,7 +124,7 @@ class EditInterventionFormTestCase(NewInterventionFormTestCase):
         self.assertIsNotNone(obj.responsible.handler)
         self.assertEqual(obj.title, data["title"])
         self.assertEqual(obj.comment, data["comment"])
-        self.assertTrue(test_geom.equals_exact(obj.geometry.geom, 0.000001))
+        self.assert_equal_geometries(test_geom, obj.geometry.geom)
 
         self.assertEqual(obj.legal.binding_date, today)
         self.assertEqual(obj.legal.registration_date, today)
@@ -280,7 +280,7 @@ class EditRevocationModalFormTestCase(NewRevocationModalFormTestCase):
             data,
             request=self.request,
             instance=self.intervention,
-            revocation=self.revoc
+            revocation_id=self.revoc.id
         )
         self.assertTrue(form.is_valid(), msg=form.errors)
         obj = form.save()
@@ -302,7 +302,7 @@ class RemoveRevocationModalFormTestCase(EditRevocationModalFormTestCase):
         form = RemoveRevocationModalForm(
             request=self.request,
             instance=self.intervention,
-            revocation=self.revoc,
+            revocation_id=self.revoc.id,
         )
         self.assertEqual(form.instance, self.intervention)
         self.assertEqual(form.revocation, self.revoc)
@@ -317,7 +317,7 @@ class RemoveRevocationModalFormTestCase(EditRevocationModalFormTestCase):
             data,
             request=self.request,
             instance=self.intervention,
-            revocation=self.revoc
+            revocation_id=self.revoc.id
         )
         self.assertTrue(form.is_valid(), msg=form.errors)
         form.save()

intervention/urls.py

@@ -8,35 +8,36 @@ Created on: 30.11.20
 from django.urls import path
 
 from intervention.autocomplete.intervention import InterventionAutocomplete
-from intervention.views.check import check_view
+from intervention.views.check import InterventionCheckView
 from intervention.views.compensation import remove_compensation_view
 from intervention.views.deduction import NewInterventionDeductionView, EditInterventionDeductionView, \
     RemoveInterventionDeductionView
 from intervention.views.document import NewInterventionDocumentView, GetInterventionDocumentView, \
     RemoveInterventionDocumentView, EditInterventionDocumentView
-from intervention.views.intervention import index_view, new_view, new_id_view, detail_view, edit_view, remove_view
+from intervention.views.intervention import InterventionIndexView, InterventionIdentifierGeneratorView, \
+    InterventionDetailView, NewInterventionFormView, EditInterventionFormView, RemoveInterventionView
 from intervention.views.log import InterventionLogView
 from intervention.views.record import InterventionRecordView
-from intervention.views.report import report_view
+from intervention.views.report import InterventionReportView
 from intervention.views.resubmission import InterventionResubmissionView
-from intervention.views.revocation import new_revocation_view, edit_revocation_view, remove_revocation_view, \
+from intervention.views.revocation import NewRevocationView, GetRevocationDocumentView, EditRevocationView, \
-    get_revocation_view
+    RemoveRevocationView
 from intervention.views.share import InterventionShareFormView, InterventionShareByTokenView
 
 app_name = "intervention"
 urlpatterns = [
-    path("", index_view, name="index"),
+    path("", InterventionIndexView.as_view(), name="index"),
-    path('new/', new_view, name='new'),
+    path('new/', NewInterventionFormView.as_view(), name='new'),
-    path('new/id', new_id_view, name='new-id'),
+    path('new/id', InterventionIdentifierGeneratorView.as_view(), name='new-id'),
-    path('<id>', detail_view, name='detail'),
+    path('<id>', InterventionDetailView.as_view(), name='detail'),
     path('<id>/log', InterventionLogView.as_view(), name='log'),
-    path('<id>/edit', edit_view, name='edit'),
+    path('<id>/edit', EditInterventionFormView.as_view(), name='edit'),
-    path('<id>/remove', remove_view, name='remove'),
+    path('<id>/remove', RemoveInterventionView.as_view(), name='remove'),
     path('<id>/share/<token>', InterventionShareByTokenView.as_view(), name='share-token'),
     path('<id>/share', InterventionShareFormView.as_view(), name='share-form'),
-    path('<id>/check', check_view, name='check'),
+    path('<id>/check', InterventionCheckView.as_view(), name='check'),
     path('<id>/record', InterventionRecordView.as_view(), name='record'),
-    path('<id>/report', report_view, name='report'),
+    path('<id>/report', InterventionReportView.as_view(), name='report'),
     path('<id>/resub', InterventionResubmissionView.as_view(), name='resubmission-create'),
 
     # Compensations
@@ -54,10 +55,10 @@ urlpatterns = [
     path('<id>/deduction/<deduction_id>/remove', RemoveInterventionDeductionView.as_view(), name='remove-deduction'),
 
     # Revocation routes
-    path('<id>/revocation/new', new_revocation_view, name='new-revocation'),
+    path('<id>/revocation/new', NewRevocationView.as_view(), name='new-revocation'),
-    path('<id>/revocation/<revocation_id>/edit', edit_revocation_view, name='edit-revocation'),
+    path('<id>/revocation/<revocation_id>/edit', EditRevocationView.as_view(), name='edit-revocation'),
-    path('<id>/revocation/<revocation_id>/remove', remove_revocation_view, name='remove-revocation'),
+    path('<id>/revocation/<revocation_id>/remove', RemoveRevocationView.as_view(), name='remove-revocation'),
-    path('revocation/<doc_id>', get_revocation_view, name='get-doc-revocation'),
+    path('revocation/<doc_id>', GetRevocationDocumentView.as_view(), name='get-doc-revocation'),
 
     # Autocomplete
     path("atcmplt/interventions", InterventionAutocomplete.as_view(), name="autocomplete"),

intervention/views/check.py

@@ -5,35 +5,24 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
 from intervention.forms.modals.check import CheckModalForm
 from intervention.models import Intervention
-from konova.decorators import registration_office_group_required, shared_access_required
+from konova.views.base import BaseModalFormView
-from konova.utils.message_templates import INTERVENTION_INVALID
 
 
-@login_required
+class InterventionCheckView(LoginRequiredMixin, BaseModalFormView):
-@registration_office_group_required
+    _MODEL_CLS = Intervention
-@shared_access_required(Intervention, "id")
+    _FORM_CLS = CheckModalForm
-def check_view(request: HttpRequest, id: str):
+    _MSG_SUCCESS = _("Check performed")
-    """ Renders check form for an intervention
+    _REDIRECT_URL = "intervention:detail"
 
-    Args:
+    def _user_has_permission(self, user, **kwargs):
-        request (HttpRequest): The incoming request
+        return user.is_zb_user()
-        id (str): Intervention's id
-
-    Returns:
-
-    """
-    intervention = get_object_or_404(Intervention, id=id)
-    form = CheckModalForm(request.POST or None, instance=intervention, request=request)
-    return form.process_request(
-        request,
-        msg_success=_("Check performed"),
-        msg_error=INTERVENTION_INVALID
-    )
 
+    def _get_redirect_url(self, *args, **kwargs):
+        redirect_url = super()._get_redirect_url(*args, **kwargs)
+        redirect_url += "#related_data"
+        return redirect_url

intervention/views/deduction.py

@@ -5,51 +5,27 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from intervention.models import Intervention
-from konova.decorators import default_group_required, shared_access_required
+from konova.utils.message_templates import DEDUCTION_ADDED, DEDUCTION_EDITED, DEDUCTION_REMOVED
 from konova.views.deduction import AbstractNewDeductionView, AbstractEditDeductionView, AbstractRemoveDeductionView
 
+_INTERVENTION_DETAIL_URL_NAME = "intervention:detail"
 
-class NewInterventionDeductionView(AbstractNewDeductionView):
+class NewInterventionDeductionView(LoginRequiredMixin, AbstractNewDeductionView):
-    def _custom_check(self, obj):
+    _MODEL_CLS = Intervention
-        pass
+    _MSG_SUCCESS = DEDUCTION_ADDED
-
+    _REDIRECT_URL = _INTERVENTION_DETAIL_URL_NAME
-    model = Intervention
-    redirect_url = "intervention:detail"
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
-class EditInterventionDeductionView(AbstractEditDeductionView):
+class EditInterventionDeductionView(LoginRequiredMixin, AbstractEditDeductionView):
-    def _custom_check(self, obj):
+    _MODEL_CLS = Intervention
-        pass
+    _MSG_SUCCESS = DEDUCTION_EDITED
-
+    _REDIRECT_URL = _INTERVENTION_DETAIL_URL_NAME
-    model = Intervention
-    redirect_url = "intervention:detail"
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
-class RemoveInterventionDeductionView(AbstractRemoveDeductionView):
+class RemoveInterventionDeductionView(LoginRequiredMixin, AbstractRemoveDeductionView):
-    def _custom_check(self, obj):
+    _MODEL_CLS = Intervention
-        pass
+    _MSG_SUCCESS = DEDUCTION_REMOVED
-
+    _REDIRECT_URL = _INTERVENTION_DETAIL_URL_NAME
-    model = Intervention
-    redirect_url = "intervention:detail"
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

intervention/views/document.py

@@ -5,59 +5,33 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from intervention.forms.modals.document import NewInterventionDocumentModalForm, EditInterventionDocumentModalForm, \
-from django.utils.decorators import method_decorator
+    RemoveInterventionDocumentModalForm
-
-from intervention.forms.modals.document import NewInterventionDocumentModalForm
 from intervention.models import Intervention, InterventionDocument
-from konova.decorators import default_group_required, shared_access_required
-from konova.forms.modals import EditDocumentModalForm
 from konova.views.document import AbstractNewDocumentView, AbstractGetDocumentView, AbstractRemoveDocumentView, \
     AbstractEditDocumentView
 
 
 class NewInterventionDocumentView(AbstractNewDocumentView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-    form = NewInterventionDocumentModalForm
+    _DOCUMENT_MODEL = InterventionDocument
-    redirect_url = "intervention:detail"
+    _FORM_CLS = NewInterventionDocumentModalForm
-
+    _REDIRECT_URL = "intervention:detail"
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class GetInterventionDocumentView(AbstractGetDocumentView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-    document_model = InterventionDocument
+    _DOCUMENT_CLS = InterventionDocument
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class RemoveInterventionDocumentView(AbstractRemoveDocumentView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-    document_model = InterventionDocument
+    _DOCUMENT_CLS = InterventionDocument
-
+    _FORM_CLS = RemoveInterventionDocumentModalForm
-    @method_decorator(login_required)
+    _REDIRECT_URL = "intervention:detail"
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
-
 
 class EditInterventionDocumentView(AbstractEditDocumentView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-    document_model = InterventionDocument
+    _DOCUMENT_CLS = InterventionDocument
-    form = EditDocumentModalForm
+    _FORM_CLS = EditInterventionDocumentModalForm
-    redirect_url = "intervention:detail"
+    _REDIRECT_URL = "intervention:detail"
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

intervention/views/intervention.py

@@ -7,198 +7,115 @@ Created on: 19.08.22
 """
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
-from django.http import JsonResponse, HttpRequest
+from django.contrib.auth.mixins import LoginRequiredMixin
+from django.http import HttpRequest
 from django.shortcuts import get_object_or_404, render, redirect
-from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
 
 from intervention.forms.intervention import EditInterventionForm, NewInterventionForm
 from intervention.models import Intervention
 from intervention.tables import InterventionTable
 from konova.contexts import BaseContext
-from konova.decorators import default_group_required, shared_access_required, any_group_check, login_required_modal, \
+from konova.decorators import default_group_required, shared_access_required
-    uuid_required
 from konova.forms import SimpleGeomForm
-from konova.forms.modals import RemoveModalForm
-from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
 from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
 from konova.utils.message_templates import DATA_CHECKED_PREVIOUSLY_TEMPLATE, RECORDED_BLOCKS_EDIT, \
-    CHECK_STATE_RESET, FORM_INVALID, IDENTIFIER_REPLACED, DO_NOT_FORGET_TO_SHARE, GEOMETRY_SIMPLIFIED
+    CHECK_STATE_RESET, FORM_INVALID, GEOMETRY_SIMPLIFIED, GEOMETRIES_IGNORED_TEMPLATE
+from konova.views.base import BaseIndexView, BaseIdentifierGeneratorView, BaseNewSpatialLocatedObjectFormView, \
+    BaseEditSpatialLocatedObjectFormView
+from konova.views.detail import BaseDetailView
+from konova.views.remove import BaseRemoveModalFormView
 
 
-@login_required
+class InterventionIndexView(LoginRequiredMixin, BaseIndexView):
-@any_group_check
+    _INDEX_TABLE_CLS = InterventionTable
-def index_view(request: HttpRequest):
+    _TAB_TITLE = _("Interventions - Overview")
-    """
-    Renders the index view for Interventions
 
-    Args:
+    def _get_queryset(self):
-        request (HttpRequest): The incoming request
+        qs = Intervention.objects.filter(
-
+            deleted=None,
-    Returns:
+        ).select_related(
-        A rendered view
+            "legal"
-    """
+        ).order_by(
-    template = "generic_index.html"
+            "-modified__timestamp"
-
+        )
-    # Filtering by user access is performed in table filter inside InterventionTableFilter class
+        return qs
-    interventions = Intervention.objects.filter(
-        deleted=None,  # not deleted
-    ).select_related(
-        "legal"
-    ).order_by(
-        "-modified__timestamp"
-    )
-    table = InterventionTable(
-        request=request,
-        queryset=interventions
-    )
-    context = {
-        "table": table,
-        TAB_TITLE_IDENTIFIER: _("Interventions - Overview"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
-@login_required
+class NewInterventionFormView(BaseNewSpatialLocatedObjectFormView):
-@default_group_required
+    _MODEL_CLS = Intervention
-def new_view(request: HttpRequest):
+    _FORM_CLS = NewInterventionForm
-    """
+    _TEMPLATE = "intervention/form/view.html"
-    Renders a view for a new intervention creation
+    _REDIRECT_URL = "intervention:detail"
-
+    _TAB_TITLE = _("New intervention")
-    Args:
-        request (HttpRequest): The incoming request
-
-    Returns:
-
-    """
-    template = "intervention/form/view.html"
-    data_form = NewInterventionForm(request.POST or None)
-    geom_form = SimpleGeomForm(request.POST or None, read_only=False)
-    if request.method == "POST":
-        if data_form.is_valid() and geom_form.is_valid():
-            generated_identifier = data_form.cleaned_data.get("identifier", None)
-            intervention = data_form.save(request.user, geom_form)
-            if generated_identifier != intervention.identifier:
-                messages.info(
-                    request,
-                    IDENTIFIER_REPLACED.format(
-                        generated_identifier,
-                        intervention.identifier
-                    )
-                )
-            messages.success(request, _("Intervention {} added").format(intervention.identifier))
-            if geom_form.geometry_simplified:
-                messages.info(
-                    request,
-                    GEOMETRY_SIMPLIFIED
-                )
-            return redirect("intervention:detail", id=intervention.id)
-        else:
-            messages.error(request, FORM_INVALID, extra_tags="danger",)
-    else:
-        # For clarification: nothing in this case
-        pass
-    context = {
-        "form": data_form,
-        "geom_form": geom_form,
-        TAB_TITLE_IDENTIFIER: _("New intervention"),
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
-@login_required
+class EditInterventionFormView(BaseEditSpatialLocatedObjectFormView):
-@default_group_required
+    _MODEL_CLS = Intervention
-def new_id_view(request: HttpRequest):
+    _FORM_CLS = EditInterventionForm
-    """ JSON endpoint
+    _TEMPLATE = "intervention/form/view.html"
+    _REDIRECT_URL = "intervention:detail"
+    _TAB_TITLE = _("Edit {}")
 
-    Provides fetching of free identifiers for e.g. AJAX calls
 
-    """
+class InterventionIdentifierGeneratorView(LoginRequiredMixin, BaseIdentifierGeneratorView):
-    tmp_intervention = Intervention()
+    _MODEL_CLS = Intervention
-    identifier = tmp_intervention.generate_new_identifier()
+    _REDIRECT_URL = "intervention:index"
-    while Intervention.objects.filter(identifier=identifier).exists():
+
-        identifier = tmp_intervention.generate_new_identifier()
+
-    return JsonResponse(
+class InterventionDetailView(BaseDetailView):
-        data={
+    _MODEL_CLS = Intervention
-            "gen_data": identifier
+    _TEMPLATE = "intervention/detail/view.html"
+
+    def _get_object(self, id: str):
+        """ Returns the intervention
+
+        Args:
+            id (str): The intervention's id
+
+        Returns:
+            obj (Intervention): The intervention
+        """
+        # Fetch data, filter out deleted related data
+        obj = get_object_or_404(
+            self._MODEL_CLS.objects.select_related(
+                "geometry",
+                "legal",
+                "responsible",
+            ).prefetch_related(
+                "legal__revocations",
+            ),
+            id=id,
+            deleted=None
+        )
+        return obj
+
+    def _get_detail_context(self, obj: Intervention):
+        """ Generate object specific detail context for  view
+
+        Args:
+            obj (): The record
+
+        Returns:
+
+        """
+        compensations = obj.compensations.filter(deleted=None)
+        last_checked = obj.get_last_checked_action()
+        last_checked_tooltip = ""
+        if last_checked:
+            last_checked_tooltip = DATA_CHECKED_PREVIOUSLY_TEMPLATE.format(
+                last_checked.get_timestamp_str_formatted(),
+                last_checked.user
+            )
+
+        has_payment_without_document = obj.payments.exists() and not obj.get_documents()[1].exists()
+        context = {
+            "last_checked": last_checked,
+            "last_checked_tooltip": last_checked_tooltip,
+            "compensations": compensations,
+            "has_payment_without_document": has_payment_without_document,
         }
-    )
+        return context
-
-
-@login_required
-@any_group_check
-@uuid_required
-def detail_view(request: HttpRequest, id: str):
-    """ Renders a detail view for viewing an intervention's data
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The intervention's id
-
-    Returns:
-
-    """
-    template = "intervention/detail/view.html"
-
-    # Fetch data, filter out deleted related data
-    intervention = get_object_or_404(
-        Intervention.objects.select_related(
-            "geometry",
-            "legal",
-            "responsible",
-        ).prefetch_related(
-            "legal__revocations",
-        ),
-        id=id,
-        deleted=None
-    )
-    compensations = intervention.compensations.filter(
-        deleted=None,
-    )
-    _user = request.user
-    is_data_shared = intervention.is_shared_with(user=_user)
-
-    geom_form = SimpleGeomForm(
-        instance=intervention,
-    )
-    last_checked = intervention.get_last_checked_action()
-    last_checked_tooltip = ""
-    if last_checked:
-        last_checked_tooltip = DATA_CHECKED_PREVIOUSLY_TEMPLATE.format(
-            last_checked.get_timestamp_str_formatted(),
-            last_checked.user
-        )
-
-    has_payment_without_document = intervention.payments.exists() and not intervention.get_documents()[1].exists()
-
-    requesting_user_is_only_shared_user = intervention.is_only_shared_with(_user)
-    if requesting_user_is_only_shared_user:
-        messages.info(
-            request,
-            DO_NOT_FORGET_TO_SHARE
-        )
-
-    context = {
-        "obj": intervention,
-        "last_checked": last_checked,
-        "last_checked_tooltip": last_checked_tooltip,
-        "compensations": compensations,
-        "is_entry_shared": is_data_shared,
-        "geom_form": geom_form,
-        "is_default_member": _user.in_group(DEFAULT_GROUP),
-        "is_zb_member": _user.in_group(ZB_GROUP),
-        "is_ets_member": _user.in_group(ETS_GROUP),
-        "LANIS_LINK": intervention.get_LANIS_link(),
-        "has_payment_without_document": has_payment_without_document,
-        TAB_TITLE_IDENTIFIER: f"{intervention.identifier} - {intervention.title}",
-    }
-
-    request = intervention.set_status_messages(request)
-
-    context = BaseContext(request, context).context
-    return render(request, template, context)
 
 
 @login_required
@@ -236,11 +153,19 @@ def edit_view(request: HttpRequest, id: str):
             messages.success(request, _("Intervention {} edited").format(intervention.identifier))
             if intervention_is_checked:
                 messages.info(request, CHECK_STATE_RESET)
-            if geom_form.geometry_simplified:
+            if geom_form.has_geometry_simplified():
                 messages.info(
                     request,
                     GEOMETRY_SIMPLIFIED
                 )
+
+            num_ignored_geometries = geom_form.get_num_geometries_ignored()
+            if num_ignored_geometries > 0:
+                messages.info(
+                    request,
+                    GEOMETRIES_IGNORED_TEMPLATE.format(num_ignored_geometries)
+                )
+
             return redirect("intervention:detail", id=intervention.id)
         else:
             messages.error(request, FORM_INVALID, extra_tags="danger",)
@@ -255,26 +180,6 @@ def edit_view(request: HttpRequest, id: str):
     context = BaseContext(request, context).context
     return render(request, template, context)
 
-
+class RemoveInterventionView(LoginRequiredMixin, BaseRemoveModalFormView):
-@login_required_modal
+    _MODEL_CLS = Intervention
-@login_required
+    _REDIRECT_URL = "intervention:index"
-@default_group_required
-@shared_access_required(Intervention, "id")
-def remove_view(request: HttpRequest, id: str):
-    """ Renders a remove view for this intervention
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The uuid id as string
-
-    Returns:
-
-    """
-    obj = Intervention.objects.get(id=id)
-    identifier = obj.identifier
-    form = RemoveModalForm(request.POST or None, instance=obj, request=request)
-    return form.process_request(
-        request,
-        _("{} removed").format(identifier),
-        redirect_url=reverse("intervention:index")
-    )

intervention/views/log.py

@@ -5,19 +5,11 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from intervention.models import Intervention
-from konova.decorators import shared_access_required, default_group_required
 from konova.views.log import AbstractLogView
 
 
-class InterventionLogView(AbstractLogView):
+class InterventionLogView(LoginRequiredMixin, AbstractLogView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

intervention/views/record.py

@@ -5,19 +5,12 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.utils.decorators import method_decorator
 
 from intervention.models import Intervention
-from konova.decorators import conservation_office_group_required, shared_access_required
 from konova.views.record import AbstractRecordView
 
 
-class InterventionRecordView(AbstractRecordView):
+class InterventionRecordView(LoginRequiredMixin, AbstractRecordView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-
+    _REDIRECT_URL = "intervention:detail"
-    @method_decorator(login_required)
-    @method_decorator(conservation_office_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

intervention/views/report.py

@@ -5,72 +5,41 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.http import HttpRequest
-from django.shortcuts import get_object_or_404, render
 from django.urls import reverse
-from django.utils.translation import gettext_lazy as _
 
 from intervention.models import Intervention
-from konova.contexts import BaseContext
+from konova.sub_settings.django_settings import BASE_URL
-from konova.decorators import uuid_required
+from konova.utils.qrcode import QrCode
-from konova.forms import SimpleGeomForm
+from konova.views.report import BaseReportView
-from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
-from konova.utils.generators import generate_qr_code
 
 
-@uuid_required
+class InterventionReportView(BaseReportView):
-def report_view(request: HttpRequest, id: str):
+    _TEMPLATE = 'intervention/report/report.html'
-    """ Renders the public report view
+    _MODEL = Intervention
 
-    Args:
+    def _get_report_context(self, obj: Intervention):
-        request (HttpRequest): The incoming request
+        """ Returns the specific context needed for an intervention report
-        id (str): The id of the intervention
 
-    Returns:
+        Args:
+            obj (Intervention): The object for the report
 
-    """
+        Returns:
-    template = "intervention/report/report.html"
+            dict: The object specific context for rendering the report
-    intervention = get_object_or_404(Intervention, id=id)
+        """
+        distinct_deductions = obj.deductions.all().distinct("account")
+        report_url = BASE_URL + reverse("intervention:report", args=(obj.id,))
+        qrcode_report = QrCode(report_url, 10)
+        qrcode_lanis = QrCode(obj.get_LANIS_link(), 7)
 
-    tab_title = _("Report {}").format(intervention.identifier)
+        return {
-    # If intervention is not recorded (yet or currently) we need to render another template without any data
+            "deductions": distinct_deductions,
-    if not intervention.is_ready_for_publish():
+            "qrcode": {
-        template = "report/unavailable.html"
+                "img": qrcode_report.get_img(),
-        context = {
+                "url": qrcode_report.get_content(),
-            TAB_TITLE_IDENTIFIER: tab_title,
+            },
+            "qrcode_lanis": {
+                "img": qrcode_lanis.get_img(),
+                "url": qrcode_lanis.get_content(),
+            },
+            "tables_scrollable": False,
         }
-        context = BaseContext(request, context).context
-        return render(request, template, context)
-
-    # Prepare data for map viewer
-    geom_form = SimpleGeomForm(
-        instance=intervention
-    )
-    parcels = intervention.get_underlying_parcels()
-
-    distinct_deductions = intervention.deductions.all().distinct(
-        "account"
-    )
-    qrcode_url = request.build_absolute_uri(reverse("intervention:report", args=(id,)))
-    qrcode_img = generate_qr_code(qrcode_url, 10)
-    qrcode_lanis_url = intervention.get_LANIS_link()
-    qrcode_img_lanis = generate_qr_code(qrcode_lanis_url, 7)
-
-    context = {
-        "obj": intervention,
-        "deductions": distinct_deductions,
-        "qrcode": {
-            "img": qrcode_img,
-            "url": qrcode_url,
-        },
-        "qrcode_lanis": {
-            "img": qrcode_img_lanis,
-            "url": qrcode_lanis_url,
-        },
-        "geom_form": geom_form,
-        "parcels": parcels,
-        "tables_scrollable": False,
-        TAB_TITLE_IDENTIFIER: tab_title,
-    }
-    context = BaseContext(request, context).context
-    return render(request, template, context)

intervention/views/resubmission.py

@@ -5,22 +5,12 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
+from intervention.forms.modals.resubmission import InterventionResubmissionModalForm
-from django.utils.decorators import method_decorator
-
 from intervention.models import Intervention
-from konova.decorators import default_group_required, shared_access_required, login_required_modal
 from konova.views.resubmission import AbstractResubmissionView
 
 
 class InterventionResubmissionView(AbstractResubmissionView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-    redirect_url_base = "intervention:detail"
+    _FORM_CLS = InterventionResubmissionModalForm
-    form_action_url_base = "intervention:resubmission-create"
+    _REDIRECT_URL = "intervention:detail"
-
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

intervention/views/revocation.py

@@ -6,113 +6,71 @@ Created on: 19.08.22
 
 """
 from django.contrib import messages
-from django.contrib.auth.decorators import login_required
+from django.contrib.auth.mixins import LoginRequiredMixin
 from django.http import HttpRequest
 from django.shortcuts import get_object_or_404, redirect
-from django.urls import reverse
 
 from intervention.forms.modals.revocation import NewRevocationModalForm, EditRevocationModalForm, \
     RemoveRevocationModalForm
-from intervention.models import Intervention, RevocationDocument, Revocation
+from intervention.models import Intervention, RevocationDocument
-from konova.decorators import default_group_required, shared_access_required, login_required_modal
 from konova.utils.documents import get_document
-from konova.utils.message_templates import REVOCATION_ADDED, DATA_UNSHARED, REVOCATION_EDITED, REVOCATION_REMOVED
+from konova.utils.message_templates import DATA_UNSHARED, REVOCATION_EDITED, REVOCATION_REMOVED, REVOCATION_ADDED
+from konova.views.base import BaseModalFormView, BaseView
 
 
-@login_required
+class BaseRevocationView(LoginRequiredMixin, BaseModalFormView):
-@default_group_required
+    _MODEL_CLS = Intervention
-@shared_access_required(Intervention, "id")
+    _REDIRECT_URL = "intervention:detail"
-def new_revocation_view(request: HttpRequest, id: str):
-    """ Renders sharing form for an intervention
 
-    Args:
+    class Meta:
-        request (HttpRequest): The incoming request
+        abstract = True
-        id (str): Intervention's id
 
-    Returns:
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()
 
-    """
+    def _get_redirect_url(self, *args, **kwargs):
-    intervention = get_object_or_404(Intervention, id=id)
+        url = super()._get_redirect_url(*args, **kwargs)
-    form = NewRevocationModalForm(request.POST or None, request.FILES or None, instance=intervention, request=request)
+        return f"{url}#related_data"
-    return form.process_request(
-        request,
-        msg_success=REVOCATION_ADDED,
-        redirect_url=reverse("intervention:detail", args=(id,)) + "#related_data"
-    )
 
 
-@login_required
+class NewRevocationView(BaseRevocationView):
-@default_group_required
+    _FORM_CLS = NewRevocationModalForm
-def get_revocation_view(request: HttpRequest, doc_id: str):
+    _MSG_SUCCESS = REVOCATION_ADDED
-    """ Returns the revocation document as downloadable file
-
-    Wraps the generic document fetcher function from konova.utils.
-
-    Args:
-        request (HttpRequest): The incoming request
-        doc_id (str): The document id
-
-    Returns:
-
-    """
-    doc = get_object_or_404(RevocationDocument, id=doc_id)
-    # File download only possible if related instance is shared with user
-    if not doc.instance.legal.intervention.users.filter(id=request.user.id):
-        messages.info(
-            request,
-            DATA_UNSHARED
-        )
-        return redirect("intervention:detail", id=doc.instance.id)
-    return get_document(doc)
 
 
-@login_required
+class EditRevocationView(BaseRevocationView):
-@default_group_required
+    _FORM_CLS = EditRevocationModalForm
-@shared_access_required(Intervention, "id")
+    _MSG_SUCCESS = REVOCATION_EDITED
-def edit_revocation_view(request: HttpRequest, id: str, revocation_id: str):
-    """ Renders a edit view for a revocation
-
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The intervention's id as string
-        revocation_id (str): The revocation's id as string
-
-    Returns:
-
-    """
-    intervention = get_object_or_404(Intervention, id=id)
-    revocation = get_object_or_404(Revocation, id=revocation_id)
-
-    form = EditRevocationModalForm(request.POST or None, request.FILES or None, instance=intervention, revocation=revocation, request=request)
-    return form.process_request(
-        request,
-        REVOCATION_EDITED,
-        redirect_url=reverse("intervention:detail", args=(intervention.id,)) + "#related_data"
-    )
 
 
-@login_required_modal
+class RemoveRevocationView(BaseRevocationView):
-@login_required
+    _FORM_CLS = RemoveRevocationModalForm
-@default_group_required
+    _MSG_SUCCESS = REVOCATION_REMOVED
-@shared_access_required(Intervention, "id")
-def remove_revocation_view(request: HttpRequest, id: str, revocation_id: str):
-    """ Renders a remove view for a revocation
 
-    Args:
-        request (HttpRequest): The incoming request
-        id (str): The intervention's id as string
-        revocation_id (str): The revocation's id as string
 
-    Returns:
+class GetRevocationDocumentView(LoginRequiredMixin, BaseView):
+    _MODEL_CLS = RevocationDocument
+    _REDIRECT_URL = "intervention:detail"
 
-    """
+    def get(self, request: HttpRequest, doc_id: str):
-    intervention = get_object_or_404(Intervention, id=id)
+        doc = get_object_or_404(RevocationDocument, id=doc_id)
-    revocation = get_object_or_404(Revocation, id=revocation_id)
+        # File download only possible if related instance is shared with user
+        if not doc.instance.legal.intervention.users.filter(id=request.user.id):
+            messages.info(
+                request,
+                DATA_UNSHARED
+            )
+            return redirect("intervention:detail", id=doc.instance.id)
+        return get_document(doc)
 
-    form = RemoveRevocationModalForm(request.POST or None, instance=intervention, revocation=revocation, request=request)
+    def _user_has_permission(self, user, **kwargs):
-    return form.process_request(
+        return user.is_default_user()
-        request,
-        REVOCATION_REMOVED,
-        redirect_url=reverse("intervention:detail", args=(intervention.id,)) + "#related_data"
-    )
 
+    def _user_has_shared_access(self, user, **kwargs):
+        obj = get_object_or_404(self._MODEL_CLS, id=kwargs.get("doc_id"))
+        assert obj is not None
+        return obj.instance.intervention.is_shared_with(user)
+
+    def _get_redirect_url(self, *args, **kwargs):
+        url = super()._get_redirect_url(*args, **kwargs)
+        return f"{url}#related_data"

intervention/views/share.py

@@ -5,29 +5,15 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 19.08.22
 
 """
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
-
 from intervention.models import Intervention
-from konova.decorators import default_group_required, shared_access_required, login_required_modal
 from konova.views.share import AbstractShareByTokenView, AbstractShareFormView
 
 
 class InterventionShareByTokenView(AbstractShareByTokenView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-    redirect_url = "intervention:detail"
+    _REDIRECT_URL = "intervention:detail"
-
-    @method_decorator(login_required)
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)
 
 
 class InterventionShareFormView(AbstractShareFormView):
-    model = Intervention
+    _MODEL_CLS = Intervention
-
+    _REDIRECT_URL = "intervention:detail"
-    @method_decorator(login_required_modal)
-    @method_decorator(login_required)
-    @method_decorator(default_group_required)
-    @method_decorator(shared_access_required(Intervention, "id"))
-    def dispatch(self, request, *args, **kwargs):
-        return super().dispatch(request, *args, **kwargs)

konova/decorators.py

@@ -11,7 +11,7 @@ from uuid import UUID
 
 from bootstrap_modal_forms.mixins import is_ajax
 from django.contrib import messages
-from django.http import Http404
+from django.core.exceptions import BadRequest
 from django.shortcuts import redirect, get_object_or_404, render
 from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
@@ -185,7 +185,7 @@ def uuid_required(function):
         try:
             uuid = UUID(uuid)
         except ValueError:
-            raise Http404(
+            raise BadRequest(
                 "Invalid UUID"
             )
         return function(request, *args, **kwargs)

konova/forms/base_form.py

@@ -10,21 +10,18 @@ from abc import abstractmethod
 from django import forms
 from django.utils.translation import gettext_lazy as _
 
-from compensation.models import EcoAccount
-from konova.models import BaseObject
-
 
 class BaseForm(forms.Form):
     """
     Basic form for that holds attributes needed in all other forms
     """
-    template = None
     action_url = None
     action_btn_label = _("Save")
     form_title = None
     cancel_redirect = None
     form_caption = None
     instance = None  # The data holding model object
+    user = None  # The performing user
     request = None
     form_attrs = {}  # Holds additional attributes, that can be used in the template
     has_required_fields = False  # Automatically set. Triggers hint rendering in templates
@@ -33,6 +30,7 @@ class BaseForm(forms.Form):
 
     def __init__(self, *args, **kwargs):
         self.instance = kwargs.pop("instance", None)
+        self.user = kwargs.pop("user", None)
         super().__init__(*args, **kwargs)
         if self.request is not None:
             self.user = self.request.user
@@ -42,11 +40,10 @@ class BaseForm(forms.Form):
                 self.has_required_fields = True
                 break
 
-        self.check_for_recorded_instance()
         self.__check_valid_label_input_ratio()
 
     @abstractmethod
-    def save(self):
+    def save(self, *arg, **kwargs):
         # To be implemented in subclasses!
         pass
 
@@ -136,34 +133,3 @@ class BaseForm(forms.Form):
         set_class = self.fields[field].widget.attrs.get("class", "")
         set_class = set_class.replace(cls, "")
         self.fields[field].widget.attrs["class"] = set_class
-
-    def check_for_recorded_instance(self):
-        """ Checks if the instance is recorded and runs some special logic if yes
-
-        If the instance is recorded, the form shall not display any possibility to
-        edit any data. Instead, the users should get some information about why they can not edit anything.
-
-        There are situations where the form should be rendered regularly,
-        e.g deduction forms for (recorded) eco accounts.
-
-        Returns:
-
-        """
-        is_none = self.instance is None
-        is_other_data_type = not isinstance(self.instance, BaseObject)
-
-        if is_none or is_other_data_type:
-            # Do nothing
-            return
-
-        if self.instance.is_recorded:
-            self.block_form()
-
-    def block_form(self):
-        """
-        Overwrites template, providing no actions
-
-        Returns:
-
-        """
-        self.template = "form/recorded_no_edit.html"

konova/forms/geometry_form.py

@@ -25,15 +25,16 @@ class SimpleGeomForm(BaseForm):
     """ A geometry form for rendering geometry read-only using a widget
 
     """
-    read_only = True
+    read_only: bool = True
-    geometry_simplified = False
+    _geometry_simplified: bool = False
-    geom = JSONField(
+    output = JSONField(
         label=_("Geometry"),
         help_text=_(""),
         label_suffix="",
         required=False,
         disabled=False,
     )
+    _num_geometries_ignored: int = 0
 
     def __init__(self, *args, **kwargs):
         self.read_only = kwargs.pop("read_only", True)
@@ -48,33 +49,33 @@ class SimpleGeomForm(BaseForm):
                 raise AttributeError
 
             geojson = self.instance.geometry.as_feature_collection(srid=DEFAULT_SRID_RLP)
+            self._set_geojson_properties(geojson, title=self.instance.identifier or None)
             geom = json.dumps(geojson)
         except AttributeError:
             # If no geometry exists for this form, we simply set the value to None and zoom to the maximum level
             geom = ""
             self.empty = True
 
-        self.initialize_form_field("geom", geom)
+        self.initialize_form_field("output", geom)
 
     def is_valid(self):
         super().is_valid()
         is_valid = True
 
         # Get geojson from form
-        geom = self.data["geom"]
+        geom = self.data.get("output", None)
         if geom is None or len(geom) == 0:
             # empty geometry is a valid geometry
-            self.cleaned_data["geom"] = MultiPolygon(srid=DEFAULT_SRID_RLP).ewkt
+            self.cleaned_data["output"] = MultiPolygon(srid=DEFAULT_SRID_RLP).ewkt
             return is_valid
         geom = json.loads(geom)
 
         # Write submitted data back into form field to make sure invalid geometry
         # will be rendered again on failed submit
-        self.initialize_form_field("geom", self.data["geom"])
+        self.initialize_form_field("output", self.data["output"])
 
-        # Read geojson into gdal geometry
+        # Initialize features list with empty MultiPolygon, so that an empty input will result in a
-        # HINT: This can be simplified if the geojson format holds data in epsg:4326 (GDAL provides direct creation for
+        # proper empty MultiPolygon object
-        # this case)
         features = []
         features_json = geom.get("features", [])
         accepted_ogr_types = [
@@ -97,33 +98,41 @@ class SimpleGeomForm(BaseForm):
                 g = self.__flatten_geom_to_2D(g)
 
             if g.geom_type not in accepted_ogr_types:
-                self.add_error("geom", _("Only surfaces allowed. Points or lines must be buffered."))
+                self.add_error("output", _("Only surfaces allowed. Points or lines must be buffered."))
                 is_valid &= False
                 return is_valid
 
-            is_valid &= self.__is_area_valid(g)
+            is_area_valid = self.__is_area_valid(g)
+            if not is_area_valid:
+                # Geometries with an invalid size will not be saved to the db
+                # We assume these are malicious snippets which are not supposed to be in the geometry in the first place
+                self._num_geometries_ignored += 1
+                continue
 
-            polygon = Polygon.from_ewkt(g.ewkt)
+            g = Polygon.from_ewkt(g.ewkt)
-            is_valid &= polygon.valid
+            is_valid &= g.valid
-            if not polygon.valid:
+            if not g.valid:
-                self.add_error("geom", polygon.valid_reason)
+                self.add_error("output", g.valid_reason)
                 return is_valid
 
-            features.append(polygon)
+            if isinstance(g, Polygon):
+                features.append(g)
+            elif isinstance(g, MultiPolygon):
+                features.extend(list(g))
 
         # Unionize all geometry features into one new MultiPolygon
-        form_geom = MultiPolygon(srid=DEFAULT_SRID_RLP)
+        if features:
-        for feature in features:
+            form_geom = MultiPolygon(*features, srid=DEFAULT_SRID_RLP).unary_union
-            form_geom = form_geom.union(feature)
+        else:
+            form_geom = MultiPolygon(srid=DEFAULT_SRID_RLP)
 
         # Make sure to convert into a MultiPolygon. Relevant if a single Polygon is provided.
-        if form_geom.geom_type != "MultiPolygon":
+        form_geom = Geometry.cast_to_multipolygon(form_geom)
-            form_geom = MultiPolygon(form_geom, srid=DEFAULT_SRID_RLP)
 
         # Write unioned Multipolygon into cleaned data
         if self.cleaned_data is None:
             self.cleaned_data = {}
-        self.cleaned_data["geom"] = form_geom.ewkt
+        self.cleaned_data["output"] = form_geom.ewkt
 
         return is_valid
 
@@ -133,7 +142,7 @@ class SimpleGeomForm(BaseForm):
         Returns:
 
         """
-        geom = self.cleaned_data.get("geom")
+        geom = self.cleaned_data.get("output")
         g = gdal.OGRGeometry(geom, srs=DEFAULT_SRID_RLP)
         num_vertices = g.num_coords
 
@@ -146,15 +155,6 @@ class SimpleGeomForm(BaseForm):
 
         """
         is_area_valid = geom.area > 1  # > 1m² (SRID:25832)
-
-        if not is_area_valid:
-            self.add_error(
-                "geom",
-                _("Geometry must be greater than 1m². Currently is {}m²").format(
-                    float(geom.area)
-                )
-            )
-
         return is_area_valid
 
     def __simplify_geometry(self, geom, max_vert: int):
@@ -192,14 +192,14 @@ class SimpleGeomForm(BaseForm):
             if self.instance is None or self.instance.geometry is None:
                 raise LookupError
             geometry = self.instance.geometry
-            geometry.geom = self.cleaned_data.get("geom", MultiPolygon(srid=DEFAULT_SRID_RLP))
+            geometry.geom = self.cleaned_data.get("output", MultiPolygon(srid=DEFAULT_SRID_RLP))
             geometry.modified = action
 
             geometry.save()
         except LookupError:
             # No geometry or linked instance holding a geometry exist --> create a new one!
             geometry = Geometry.objects.create(
-                geom=self.cleaned_data.get("geom", MultiPolygon(srid=DEFAULT_SRID_RLP)),
+                geom=self.cleaned_data.get("output", MultiPolygon(srid=DEFAULT_SRID_RLP)),
                 created=action,
             )
 
@@ -207,13 +207,29 @@ class SimpleGeomForm(BaseForm):
         if not is_vertices_num_valid:
             geometry.geom = self.__simplify_geometry(geometry.geom, max_vert=GEOM_MAX_VERTICES)
             geometry.save()
-            self.geometry_simplified = True
+            self._geometry_simplified = True
 
         # Start parcel update and geometry conflict checking procedure in a background process
         celery_update_parcels.delay(geometry.id)
         celery_check_for_geometry_conflicts.delay(geometry.id)
         return geometry
 
+    def get_num_geometries_ignored(self):
+        """ Returns the number of geometries which had to be ignored for various reasons
+
+        Returns:
+
+        """
+        return self._num_geometries_ignored
+
+    def has_geometry_simplified(self):
+        """ Returns whether the geometry has been simplified or not.
+
+        Returns:
+
+        """
+        return self._geometry_simplified
+
     def __flatten_geom_to_2D(self, geom):
         """
         Enforces a given OGRGeometry from higher dimensions into 2D
@@ -223,3 +239,20 @@ class SimpleGeomForm(BaseForm):
         g_wkt = wkt_w.write(geom.geos).decode("utf-8")
         geom = gdal.OGRGeometry(g_wkt)
         return geom
+
+    def _set_geojson_properties(self, geojson: dict, title: str = None):
+        """ Toggles the editable property of the geojson for proper handling in map client
+
+        Args:
+            geojson (dict): The GeoJson
+            title (str): An alternative title for the geometry
+
+        Returns:
+            geojson (dict): The altered GeoJson
+        """
+        features = geojson.get("features", [])
+        for feature in features:
+            feature["properties"]["editable"] = not self.read_only
+            if title:
+                feature["properties"]["title"] = title
+        return geojson

konova/forms/modals/base_form.py

@@ -23,7 +23,7 @@ class BaseModalForm(BaseForm, BSModalForm):
     """
     is_modal_form = True
     render_submit = True
-    template = "modal/modal_form.html"
+    _TEMPLATE = "modal/modal_form.html"
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -43,7 +43,7 @@ class BaseModalForm(BaseForm, BSModalForm):
 
         """
         redirect_url = redirect_url if redirect_url is not None else request.META.get("HTTP_REFERER", "home")
-        template = self.template
+        template = self._TEMPLATE
         if request.method == "POST":
             if self.is_valid():
                 if not is_ajax(request.META):

konova/forms/modals/document_form.py

@@ -8,10 +8,10 @@ Created on: 15.08.22
 from django import forms
 from django.db import transaction
 from django.db.models.fields.files import FieldFile
+from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
 from konova.forms.modals.base_form import BaseModalForm
-from konova.models import AbstractDocument
 from konova.utils import validators
 from konova.utils.message_templates import DOCUMENT_EDITED, FILE_SIZE_TOO_LARGE, FILE_TYPE_UNSUPPORTED
 from user.models import UserActionLogEntry
@@ -69,7 +69,7 @@ class NewDocumentModalForm(BaseModalForm):
             }
         )
     )
-    document_model = None
+    _DOCUMENT_CLS = None
 
     class Meta:
         abstract = True
@@ -81,7 +81,7 @@ class NewDocumentModalForm(BaseModalForm):
         self.form_attrs = {
             "enctype": "multipart/form-data",  # important for file upload
         }
-        if not self.document_model:
+        if not self._DOCUMENT_CLS:
             raise NotImplementedError("Unsupported document type for {}".format(self.instance.__class__))
 
     def is_valid(self):
@@ -93,14 +93,14 @@ class NewDocumentModalForm(BaseModalForm):
             # FieldFile declares that no new file has been uploaded and we do not need to check on the file again
             return super_valid
 
-        mime_type_valid = self.document_model.is_mime_type_valid(_file)
+        mime_type_valid = self._DOCUMENT_CLS.is_mime_type_valid(_file)
         if not mime_type_valid:
             self.add_error(
                 "file",
                 FILE_TYPE_UNSUPPORTED
             )
 
-        file_size_valid = self.document_model.is_file_size_valid(_file)
+        file_size_valid = self._DOCUMENT_CLS.is_file_size_valid(_file)
         if not file_size_valid:
             self.add_error(
                 "file",
@@ -115,7 +115,7 @@ class NewDocumentModalForm(BaseModalForm):
             action = UserActionLogEntry.get_created_action(self.user)
             edited_action = UserActionLogEntry.get_edited_action(self.user, _("Added document"))
 
-            doc = self.document_model.objects.create(
+            doc = self._DOCUMENT_CLS.objects.create(
                 created=action,
                 title=self.cleaned_data["title"],
                 comment=self.cleaned_data["comment"],
@@ -133,10 +133,12 @@ class NewDocumentModalForm(BaseModalForm):
 
 class EditDocumentModalForm(NewDocumentModalForm):
     document = None
-    document_model = AbstractDocument
+    _DOCUMENT_CLS = None
 
     def __init__(self, *args, **kwargs):
-        self.document = kwargs.pop("document", None)
+        doc_id = kwargs.pop("doc_id", None)
+        self.document = get_object_or_404(self._DOCUMENT_CLS, id=doc_id)
+
         super().__init__(*args, **kwargs)
         self.form_title = _("Edit document")
         form_data = {

konova/forms/modals/remove_form.py

@@ -6,10 +6,11 @@ Created on: 15.08.22
 
 """
 from django import forms
+from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
 from konova.forms.modals.base_form import BaseModalForm
-from konova.models import BaseObject
+from konova.models import BaseObject, Deadline
 
 
 class RemoveModalForm(BaseModalForm):
@@ -51,9 +52,19 @@ class RemoveDeadlineModalForm(RemoveModalForm):
     deadline = None
 
     def __init__(self, *args, **kwargs):
-        deadline = kwargs.pop("deadline", None)
+        deadline_id = kwargs.pop("deadline_id", None)
-        self.deadline = deadline
+        self.deadline = get_object_or_404(Deadline, id=deadline_id)
         super().__init__(*args, **kwargs)
 
     def save(self):
-        self.instance.remove_deadline(self)
+        self.instance.remove_deadline(self)
+
+
+class RemoveDocumentModalForm(RemoveModalForm):
+    instance = None
+    _DOCUMENT_CLS = None
+
+    def __init__(self, *args, **kwargs):
+        document_id = kwargs.pop("doc_id", None)
+        super().__init__(*args, **kwargs)
+        self.instance = get_object_or_404(self._DOCUMENT_CLS, id=document_id)

konova/models/geometry.py

@@ -11,6 +11,7 @@ from django.contrib.gis.db.models import MultiPolygonField
 from django.core.exceptions import ObjectDoesNotExist, MultipleObjectsReturned
 from django.db import models, transaction
 from django.utils import timezone
+from django.contrib.gis.geos import MultiPolygon
 
 from konova.models import BaseResource, UuidModel
 from konova.sub_settings.lanis_settings import DEFAULT_SRID_RLP
@@ -342,6 +343,7 @@ class Geometry(BaseResource):
                 {
                     "type": "Feature",
                     "geometry": json.loads(p.json),
+                    "properties": {},
                  }
                 for p in polygons
             ]
@@ -383,6 +385,36 @@ class Geometry(BaseResource):
 
         return complexity_factor
 
+    @staticmethod
+    def cast_to_multipolygon(input_geom):
+        """ If input_geom is not a MultiPolygon, cast to MultiPolygon
+
+        Args:
+            input_geom ():
+
+        Returns:
+            output_geom
+        """
+        output_geom = input_geom
+        if not isinstance(input_geom, MultiPolygon):
+            output_geom = MultiPolygon(input_geom, srid=DEFAULT_SRID_RLP)
+        return output_geom
+
+    @staticmethod
+    def cast_to_rlp_srid(input_geom):
+        """ If input_geom is not of RLP SRID (25832), cast to RLP SRID
+
+        Args:
+            input_geom ():
+
+        Returns:
+            output_geom
+        """
+        output_geom = input_geom
+        if output_geom.srid != DEFAULT_SRID_RLP:
+            output_geom.transform(DEFAULT_SRID_RLP)
+        return output_geom
+
 
 class GeometryConflict(UuidModel):
     """

konova/static/css/konova.css

@@ -278,4 +278,18 @@ Similar to bootstraps 'shadow-lg'
 }
 .alert{
     margin-bottom: 0 !important;
+}
+
+/*
+Overwrites netgis.css attributes
+ */
+.netgis-gradient-a{
+    /*
+    Overwrites gradient used on default css of netgis map client
+     */
+    background: var(--rlp-red) !important;
+}
+
+.netgis-menu{
+    z-index: 100 !important;
 }

konova/sub_settings/django_settings.py

@@ -188,7 +188,6 @@ STATIC_ROOT = os.path.join(BASE_DIR, "static")
 STATICFILES_DIRS = [
     os.path.join(BASE_DIR, 'konova/static'),
     os.path.join(BASE_DIR, 'templates/map/client'),         # NETGIS map client files
-    os.path.join(BASE_DIR, 'templates/map/client/libs'),    # NETGIS map client files
 ]
 
 # EMAIL (see https://docs.djangoproject.com/en/dev/topics/email/)

konova/tests/test_geometries.py

@@ -124,6 +124,7 @@ class GeometryTestCase(BaseTestCase):
                 {
                     "type": "Feature",
                     "geometry": json.loads(p.json),
+                    "properties": {}
                 }
                 for p in polygons
             ]

konova/tests/test_views.py

@@ -469,7 +469,7 @@ class BaseTestCase(TestCase):
         eco_account.save()
         return eco_account
 
-    def assert_equal_geometries(self, geom1: MultiPolygon, geom2: MultiPolygon, tolerance = 0.001):
+    def assert_equal_geometries(self, geom1: MultiPolygon, geom2: MultiPolygon, tolerance=0.001):
         """ Assert for geometries to be equal
 
         Transforms the geometries to matching srids before checking
@@ -491,7 +491,10 @@ class BaseTestCase(TestCase):
             # transformation from one coordinate system into the other, which is valid
             geom1.transform(geom2.srid)
             geom2.transform(geom1.srid)
-        self.assertTrue(geom1.equals_exact(geom2, tolerance) or geom2.equals_exact(geom1, tolerance))
+        self.assertTrue(
+            geom1.equals_exact(geom2, tolerance=tolerance),
+            msg=f"Difference is {abs(geom1.area - geom2.area)} with {geom1.area} and {geom2.area} in a tolerance of {tolerance}"
+        )
 
 
 class BaseViewTestCase(BaseTestCase):
@@ -540,7 +543,7 @@ class BaseViewTestCase(BaseTestCase):
         for url, redirect_to in urls.items():
             response = client.get(url, follow=True)
             # Expect redirects to the landing page
-            self.assertEqual(response.redirect_chain[0], (redirect_to, 302), msg=f"Failed for {url}")
+            self.assertEqual(response.redirect_chain[0], (redirect_to, 302), msg=f"Failed for {url}. Expected {redirect_to}")
 
     def assert_url_fail(self, client: Client, urls: list):
         """ Assert for all given urls a direct 302 response

konova/tests/unit/test_deadline.py

@@ -103,7 +103,7 @@ class EditDeadlineModalFormTestCase(NewDeadlineModalFormTestCase):
             data,
             request=self.request,
             instance=self.compensation,
-            deadline=self.finished_deadline,
+            deadline_id=self.finished_deadline.id,
         )
 
         self.assertTrue(form.is_valid(), msg=form.errors)

konova/tests/unit/test_forms.py

@@ -17,9 +17,9 @@ from django.utils.timezone import now
 from compensation.forms.modals.document import NewEcoAccountDocumentModalForm, NewCompensationDocumentModalForm
 from compensation.models import Payment
 from ema.forms import NewEmaDocumentModalForm
-from intervention.forms.modals.document import NewInterventionDocumentModalForm
+from intervention.forms.modals.document import NewInterventionDocumentModalForm, EditInterventionDocumentModalForm
 from intervention.models import InterventionDocument
-from konova.forms.modals import EditDocumentModalForm, NewDocumentModalForm, RecordModalForm, RemoveModalForm, \
+from konova.forms.modals import NewDocumentModalForm, RecordModalForm, RemoveModalForm, \
     RemoveDeadlineModalForm, ResubmissionModalForm
 from konova.models import Resubmission
 from konova.tests.test_views import BaseTestCase
@@ -106,12 +106,12 @@ class EditDocumentModalFormTestCase(NewDocumentModalFormTestCase):
             InterventionDocument,
             instance=self.intervention
         )
-        self.form = EditDocumentModalForm(
+        self.form = EditInterventionDocumentModalForm(
             self.data,
             dummy_file_dict,
             request=self.request,
             instance=self.intervention,
-            document=self.doc
+            doc_id=self.doc.id
         )
 
     def test_init(self):
@@ -122,7 +122,6 @@ class EditDocumentModalFormTestCase(NewDocumentModalFormTestCase):
         self.assertEqual(self.form.fields["title"].initial, self.doc.title)
         self.assertEqual(self.form.fields["comment"].initial, self.doc.comment)
         self.assertEqual(self.form.fields["creation_date"].initial, self.doc.date_of_creation)
-        self.assertEqual(self.form.fields["file"].initial, self.doc.file)
 
     def test_save(self):
         self.assertTrue(self.form.is_valid(), msg=self.form.errors)
@@ -256,7 +255,7 @@ class RemoveDeadlineTestCase(BaseTestCase):
         form = RemoveDeadlineModalForm(
             request=self.request,
             instance=self.compensation,
-            deadline=self.finished_deadline
+            deadline_id=self.finished_deadline.id
         )
         self.assertEqual(form.form_title, str(_("Remove")))
         self.assertEqual(form.form_caption, str(_("Are you sure?")))
@@ -273,7 +272,7 @@ class RemoveDeadlineTestCase(BaseTestCase):
             data,
             request=self.request,
             instance=self.compensation,
-            deadline=self.finished_deadline
+            deadline_id=self.finished_deadline.id
         )
         self.assertTrue(form.is_valid(), msg=form.errors)
         form.save()

konova/urls.py

@@ -42,5 +42,6 @@ urlpatterns = [
     path('client/proxy/wfs', ClientProxyParcelWFS.as_view(), name="client-proxy-wfs"),
 ]
 
+handler400 = "konova.views.error.get_400_view"
 handler404 = "konova.views.error.get_404_view"
 handler500 = "konova.views.error.get_500_view"

konova/utils/documents.py

@@ -7,9 +7,7 @@ Created on: 01.09.21
 """
 from django.http import FileResponse, HttpRequest, Http404
 
-from konova.forms.modals import RemoveModalForm
 from konova.models import AbstractDocument
-from konova.utils.message_templates import DOCUMENT_REMOVED_TEMPLATE
 
 
 def get_document(doc: AbstractDocument):
@@ -26,28 +24,3 @@ def get_document(doc: AbstractDocument):
         return FileResponse(doc.file, as_attachment=True)
     except FileNotFoundError:
         raise Http404()
-
-
-def remove_document(request: HttpRequest, doc: AbstractDocument):
-    """ Renders a form for uploading new documents
-
-    This function works using a modal. We are not using the regular way, the django bootstrap modal forms are
-    intended to be used. Instead of View classes we work using the classic way of dealing with forms (see below).
-    It is important to mention, that modal forms, which should reload the page afterwards, must provide a
-    'reload_page' bool in the context. This way, the modal may reload the page or not.
-
-    For further details see the comments in templates/modal or
-    https://github.com/trco/django-bootstrap-modal-forms
-
-    Args:
-        request (HttpRequest): The incoming request
-
-    Returns:
-
-    """
-    title = doc.title
-    form = RemoveModalForm(request.POST or None, instance=doc, request=request)
-    return form.process_request(
-        request=request,
-        msg_success=DOCUMENT_REMOVED_TEMPLATE.format(title),
-    )

konova/utils/general.py

@@ -5,6 +5,11 @@ Contact: michel.peltriaux@sgdnord.rlp.de
 Created on: 17.09.21
 
 """
+from uuid import UUID
+
+from django.contrib import messages
+from django.utils.translation import gettext_lazy as _
+from django.http import HttpRequest, Http404
 
 
 def format_german_float(num) -> str:
@@ -19,3 +24,27 @@ def format_german_float(num) -> str:
         num (str): The number as german Gleitkommazahl
     """
     return format(num, "0,.2f").replace(",", "X").replace(".", ",").replace("X", ".")
+
+
+def check_user_is_in_any_group(request: HttpRequest):
+    """
+    Checks for any group membership. Adds a message in case of having none.
+
+    """
+    user = request.user
+    # Inform user about missing group privileges!
+    groups = user.groups.all()
+    if not groups:
+        messages.info(
+            request,
+            _("+++ Attention: You are not part of any group. You won't be able to create, edit or do anything. Please contact an administrator. +++")
+        )
+    return request
+
+def check_id_is_valid_uuid(uuid: str):
+    if uuid:
+        try:
+            # Check whether the id is a proper uuid or something that would break a db fetch
+            UUID(uuid)
+        except ValueError:
+            raise Http404

konova/utils/generators.py

@@ -7,10 +7,6 @@ Created on: 09.11.20
 """
 import random
 import string
-import qrcode
-import qrcode.image.svg
-
-from io import BytesIO
 
 
 def generate_token() -> str:
@@ -42,23 +38,3 @@ def generate_random_string(length: int, use_numbers: bool = False, use_letters_l
     ret_val = "".join(random.choice(elements) for i in range(length))
     return ret_val
 
-
-def generate_qr_code(content: str, size: int = 20) -> str:
-    """ Generates a qr code from given content
-
-    Args:
-        content (str): The content for the qr code
-        size (int): The image size
-
-    Returns:
-        qrcode_svg (str): The qr code as svg
-    """
-    qrcode_factory = qrcode.image.svg.SvgImage
-    qrcode_img = qrcode.make(
-        content,
-        image_factory=qrcode_factory,
-        box_size=size
-    )
-    stream = BytesIO()
-    qrcode_img.save(stream)
-    return stream.getvalue().decode()

konova/utils/message_templates.py

@@ -19,7 +19,20 @@ IDENTIFIER_REPLACED = _("The identifier '{}' had to be changed to '{}' since ano
 ENTRY_REMOVE_MISSING_PERMISSION = _("Only conservation or registration office users are allowed to remove entries.")
 MISSING_GROUP_PERMISSION = _("You need to be part of another user group.")
 CHECK_STATE_RESET = _("Status of Checked reset")
+
+# USER | TEAM
+TEAM_ADDED = _("New team added")
+TEAM_EDITED = _("Team edited")
+TEAM_REMOVED = _("Team removed")
+TEAM_LEFT = _("Left Team")
+
+# REMOVED
+GENERIC_REMOVED_TEMPLATE = _("{} removed")
+
+# RECORDING
 RECORDED_BLOCKS_EDIT = _("Entry is recorded. To edit data, the entry first needs to be unrecorded.")
+ENTRY_RECORDED = _("{} recorded")
+ENTRY_UNRECORDED = _("{} unrecorded")
 
 # SHARE
 DATA_UNSHARED = _("This data is not shared with you")
@@ -83,6 +96,7 @@ EDITED_GENERAL_DATA = _("Edited general data")
 # Geometry
 GEOMETRY_CONFLICT_WITH_TEMPLATE = _("Geometry conflict detected with {}")
 GEOMETRY_SIMPLIFIED = _("The geometry contained more than {} vertices. It had to be simplified to match the allowed limit of {} vertices.").format(GEOM_MAX_VERTICES, GEOM_MAX_VERTICES)
+GEOMETRIES_IGNORED_TEMPLATE = _("The geometry contained {} parts which have been detected as invalid (e.g. too small to be valid). These parts have been removed. Please check the stored geometry.")
 
 # INTERVENTION
 INTERVENTION_HAS_REVOCATIONS_TEMPLATE = _("This intervention has {} revocations")
@@ -93,4 +107,7 @@ DATA_CHECKED_PREVIOUSLY_TEMPLATE = _("Data has changed since last check on {} by
 DATA_IS_UNCHECKED = _("Current data not checked yet")
 
 # API TOKEN SETTINGS
-NEW_API_TOKEN_GENERATED = _("New token generated. Administrators need to validate.")
+NEW_API_TOKEN_GENERATED = _("New token generated. Administrators need to validate.")
+
+# RESUBMISSION
+NEW_RESUBMISSION_CREATED = _("Resubmission set")

konova/utils/qrcode.py

@@ -0,0 +1,47 @@
+"""
+Author: Michel Peltriaux
+Created on: 17.10.25
+
+"""
+from io import BytesIO
+
+import qrcode
+import qrcode.image.svg as svg
+
+
+class QrCode:
+    """ A wrapping class for creating a qr code with content
+
+    """
+    _content = None
+    _img = None
+
+    def __init__(self, content: str, size: int):
+        self._content = content
+        self._img = self._generate_qr_code(content, size)
+
+    def _generate_qr_code(self, content: str, size: int = 20) -> str:
+        """ Generates a qr code from given content
+
+        Args:
+            content (str): The content for the qr code
+            size (int): The image size
+
+        Returns:
+            qrcode_svg (str): The qr code as svg
+        """
+        img_factory = svg.SvgImage
+        qrcode_img = qrcode.make(
+            content,
+            image_factory=img_factory,
+            box_size=size
+        )
+        stream = BytesIO()
+        qrcode_img.save(stream)
+        return stream.getvalue().decode()
+
+    def get_img(self):
+        return self._img
+
+    def get_content(self):
+        return self._content

konova/utils/schneider/fetcher.py

@@ -11,6 +11,7 @@ from json import JSONDecodeError
 import requests
 
 from konova.sub_settings import schneider_settings
+from konova.sub_settings.lanis_settings import DEFAULT_SRID
 from konova.sub_settings.proxy_settings import PROXIES
 
 
@@ -34,6 +35,7 @@ class ParcelFetcher:
         if geom.area < buffer_threshold:
             # Fallback for malicious geometries which are way too small and would disappear on negative buffering
             geom = geometry.geom
+        geom.transform(DEFAULT_SRID)
         self.geojson = geom.ewkt
         self.results = []
 

konova/views/action.py

@@ -5,104 +5,47 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 22.08.22
 
 """
-from django.shortcuts import get_object_or_404
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.urls import reverse
-from django.views import View
 
 from compensation.forms.modals.compensation_action import NewCompensationActionModalForm, \
     EditCompensationActionModalForm, RemoveCompensationActionModalForm
-from compensation.models import CompensationAction
 from konova.utils.message_templates import COMPENSATION_STATE_ADDED, COMPENSATION_STATE_EDITED, \
     COMPENSATION_STATE_REMOVED
+from konova.views.base import BaseModalFormView
 
 
-class AbstractCompensationActionView(View):
+class AbstractCompensationActionView(LoginRequiredMixin, BaseModalFormView):
-    model = None
+    _MODEL_CLS = None
-    redirect_url = None
+    _REDIRECT_URL = None
     
     class Meta:
         abstract = True
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()
+
+    def _get_redirect_url(self, *args, **kwargs):
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"
 
 class AbstractNewCompensationActionView(AbstractCompensationActionView):
+    _FORM_CLS =  NewCompensationActionModalForm
+    _MSG_SUCCESS = COMPENSATION_STATE_ADDED
+
     class Meta:
         abstract = True
 
-    def get(self, request, id: str):
-        """ Renders a form for adding new actions 
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The object's id to which the new action will be related
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        form = NewCompensationActionModalForm(request.POST or None, instance=obj, request=request)
-        return form.process_request(
-            request,
-            msg_success=COMPENSATION_STATE_ADDED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str):
-        return self.get(request, id)
-    
 
 class AbstractEditCompensationActionView(AbstractCompensationActionView):
+    _FORM_CLS = EditCompensationActionModalForm
+    _MSG_SUCCESS = COMPENSATION_STATE_EDITED
+
     class Meta:
         abstract = True
-
-    def get(self, request, id: str, action_id: str):
-        """ Renders a form for editing a action
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The object id
-            action_id (str): The action's id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        action = get_object_or_404(CompensationAction, id=action_id)
-        form = EditCompensationActionModalForm(request.POST or None, instance=obj, action=action, request=request)
-        return form.process_request(
-            request,
-            msg_success=COMPENSATION_STATE_EDITED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, action_id: str):
-        return self.get(request, id, action_id)
     
 
 class AbstractRemoveCompensationActionView(AbstractCompensationActionView):
+    _FORM_CLS = RemoveCompensationActionModalForm
+    _MSG_SUCCESS = COMPENSATION_STATE_REMOVED
+
     class Meta:
         abstract = True
-
-    def get(self, request, id: str, action_id: str):
-        """ Renders a form for removing aaction
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The object id
-            action_id (str): The action's id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        action = get_object_or_404(CompensationAction, id=action_id)
-        form = RemoveCompensationActionModalForm(request.POST or None, instance=obj, action=action, request=request)
-        return form.process_request(
-            request,
-            msg_success=COMPENSATION_STATE_REMOVED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, action_id: str):
-        return self.get(request, id, action_id)
-    
-

konova/views/base.py

@@ -0,0 +1,641 @@
+"""
+Author: Michel Peltriaux
+Created on: 15.10.25
+
+"""
+from abc import abstractmethod
+
+from bootstrap_modal_forms.mixins import is_ajax
+from django.contrib import messages
+from django.contrib.auth.mixins import LoginRequiredMixin
+from django.core.exceptions import ObjectDoesNotExist
+from django.http import HttpRequest, JsonResponse, HttpResponseRedirect
+from django.shortcuts import render, redirect, get_object_or_404
+from django.urls import reverse
+from django.views import View
+from django.utils.translation import gettext_lazy as _
+
+from konova.contexts import BaseContext
+from konova.forms import BaseForm, SimpleGeomForm
+from konova.models import BaseObject
+from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
+from konova.utils.general import check_user_is_in_any_group
+from konova.utils.message_templates import MISSING_GROUP_PERMISSION, DATA_UNSHARED, IDENTIFIER_REPLACED, \
+    GEOMETRY_SIMPLIFIED, GEOMETRIES_IGNORED_TEMPLATE, RECORDED_BLOCKS_EDIT, FORM_INVALID
+
+
+class BaseView(View):
+    """ An abstract base view
+
+    This class represents the root of all views on this project. It defines private variables which have to be used
+    by inheriting classes for proper generic inheriting.
+
+    """
+    _TEMPLATE: str = "CHANGE_ME"        # Path to template file
+    _TAB_TITLE: str = "CHANGE_ME"       # Title displayed on browser tab
+    _REDIRECT_URL: str = "CHANGE_ME"    # Default URL to redirect after processing (notation as django url "namespace:endpoint")
+    _REDIRECT_URL_ERROR: str = "home"   # Default URL to redirect in case of an error (same notation)
+
+    class Meta:
+        abstract = True
+
+    def dispatch(self, request, *args, **kwargs):
+        """ Dispatching requests before forwarding them into GET or POST endpoints.
+
+        Defines basic checks which need to be done before a user can get access to any view inheriting from
+        this class.
+
+        Args:
+            request (HttpRequest): The incoming request
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        request = check_user_is_in_any_group(request)
+
+        if not self._user_has_permission(request.user, **kwargs):
+            messages.info(request, MISSING_GROUP_PERMISSION)
+            return redirect(reverse(self._REDIRECT_URL_ERROR))
+
+        if not self._user_has_shared_access(request.user, **kwargs):
+            messages.info(request, DATA_UNSHARED)
+            return redirect(reverse(self._REDIRECT_URL_ERROR))
+
+        return super().dispatch(request, *args, **kwargs)
+
+    @abstractmethod
+    def _user_has_permission(self, user, **kwargs):
+        """ Checks whether the user has permission to get this view rendered.
+
+        If no specific check is needed, this method can be overwritten with a simple True returning.
+
+        Args:
+            user (User): The performing user
+            **kwargs ():
+
+        Returns:
+            has_permission (bool): Whether the user has permission to see this view
+        """
+        raise NotImplementedError("User permission not checked!")
+
+    @abstractmethod
+    def _user_has_shared_access(self, user, **kwargs):
+        """ Checks whether the user has shared access to this object.
+
+        If no shared-access-check is needed, this method can be overwritten with a simple True returning.
+
+        Args:
+            user (User): The performing user
+            **kwargs ():
+
+        Returns:
+            has_shared_access (bool): Whether the user has shared access
+        """
+        raise NotImplementedError("Shared access not checked!")
+
+    def _get_redirect_url(self, *args, **kwargs):
+        """ Getter to construct a more specific, data dependant redirect URL
+
+        By default the method simply returns the pre-defined redirect URL.
+
+        Args:
+            *args ():
+            **kwargs ():
+
+        Returns:
+            url (str): Reversed redirect url
+        """
+        return self._REDIRECT_URL
+
+    def _get_redirect_url_error(self, *args, **kwargs):
+        """ Getter to construct a more specific, data dependant redirect URL in error cases
+
+        By default the method simply returns the pre-defined redirect URL for errors.
+
+        Args:
+            *args ():
+            **kwargs ():
+
+        Returns:
+            url (str): Reversed redirect url
+        """
+        return self._REDIRECT_URL_ERROR
+
+class BaseModalFormView(BaseView):
+    """ Abstract base view providing logic to perform most modal form based view renderings
+
+    """
+    _TEMPLATE: str = "modal/modal_form.html"
+    _MODEL_CLS = None
+    _FORM_CLS = None
+    _MSG_SUCCESS = None
+
+    class Meta:
+        abstract = True
+
+    def _user_has_shared_access(self, user, **kwargs):
+        """ Checks whether the user has shared access to this object.
+
+        For objects inheriting from BaseObject class the method 'is_shared_with()' is a handy
+        wrapper for checking shared access. For any other circumstances this method should be overwritten
+        to provide custom shared-access-checking logic.
+
+        If no shared-access-check is needed, this method can be overwritten with a simple True returning.
+
+        Args:
+            user (User): The performing user
+            **kwargs ():
+
+        Returns:
+            has_shared_access (bool): Whether the user has shared access
+        """
+        obj = get_object_or_404(self._MODEL_CLS, id=kwargs.get("id"))
+        return obj.is_shared_with(user)
+
+    def get(self, request: HttpRequest, *args, **kwargs):
+        """ GET endpoint for rendering a view holding a modal form
+
+        Args:
+            request (HttpRequest): The incoming request
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        # If there is an id provided as mapped parameter from the URL take it ...
+        _id = kwargs.pop("id", None)
+        try:
+            # ... and try to resolve it into a record
+            obj = self._MODEL_CLS.objects.get(id=_id)
+            self._check_for_recorded_instance(obj)
+        except ObjectDoesNotExist:
+            # ... If there is none, maybe we are currently processing
+            # the creation of a new object (therefore no id yet), so let's continue
+            obj = None
+        form = self._FORM_CLS(
+            request.POST or None,
+            request.FILES or None,
+            instance=obj,
+            request=request,
+            **kwargs
+        )
+        context = {
+            "form": form,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
+
+    def post(self, request: HttpRequest, *args, **kwargs):
+        """ POST endpoint for processing form contents of a view
+
+        Args:
+            request (HttpRequest): The incoming request
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        # If there is an id provided as mapped parameter from the URL take it ...
+        _id = kwargs.pop("id", None)
+        try:
+            # ... and try to resolve it into a record
+            obj = self._MODEL_CLS.objects.get(id=_id)
+            self._check_for_recorded_instance(obj)
+        except ObjectDoesNotExist:
+            # ... If there is none, maybe we are currently processing
+            # the creation of a new object (therefore no id yet), so let's continue
+            obj = None
+        form = self._FORM_CLS(
+            request.POST or None,
+            request.FILES or None,
+            instance=obj,
+            request=request,
+            **kwargs
+        )
+        # Get now the redirect url and take specifics of the obj into account for that.
+        # We do not do this after saving the form to avoid side effects due to possibly changed data
+        redirect_url = self._get_redirect_url(obj=obj)
+        if form.is_valid():
+            # Modal forms send one POST for checking on data validity. This is used to evaluate possible errors
+            # on the form. The second POST (if no errors have been found) is the 'proper' one,
+            # which we want to process by saving/commiting of the data to the database.
+            if not is_ajax(request.META):
+                # Get now the success message and take specifics of the obj into account for that
+                msg_success = self._get_msg_success(obj=obj, *args, **kwargs)
+                form.save()
+                messages.success(
+                    request,
+                    msg_success
+                )
+            return HttpResponseRedirect(redirect_url)
+        else:
+            context = {
+                "form": form,
+            }
+            context = BaseContext(request, context).context
+            return render(request, self._TEMPLATE, context)
+
+    def _get_redirect_url(self, *args, **kwargs):
+        """ Getter to construct a more specific, data dependant redirect URL (if needed)
+
+        Args:
+            *args ():
+            **kwargs ():
+
+        Returns:
+            url (str): Reversed redirect url
+        """
+        obj = kwargs.get("obj", None)
+        if obj:
+            return reverse(self._REDIRECT_URL, args=(obj.id,))
+        else:
+            return reverse(self._REDIRECT_URL)
+
+    def _get_msg_success(self, *args, **kwargs):
+        """ Getter to construct a more specific, data dependant success message
+
+        Args:
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        return self._MSG_SUCCESS
+
+    def _check_for_recorded_instance(self, obj):
+        """ Checks if the object on this view is recorded and runs some special logic if so
+
+        If the instance is recorded, the view should provide some information about why the user can not edit anything.
+        This behaviour is only intended to mask any form for instances based on the BaseObject class.
+
+        There are situations where the form should be rendered regularly, despite the instance being recorded,
+        e.g. for rendering deduction form contents on (recorded) eco accounts.
+
+        Returns:
+
+        """
+        is_none = obj is None
+        is_other_data_type = not isinstance(obj, BaseObject)
+
+        if is_none or is_other_data_type:
+            # Do nothing
+            return
+
+        if obj.is_recorded:
+            # Replace default template with a blocking one
+            self._TEMPLATE = "form/recorded_no_edit.html"
+
+
+class BaseIndexView(BaseView):
+    """ Abstract base class for index views
+
+    """
+    _TEMPLATE: str = "generic_index.html"
+    _INDEX_TABLE_CLS = None
+    _REDIRECT_URL: str = "home"
+
+    class Meta:
+        abstract = True
+
+    def get(self, request: HttpRequest, *args, **kwargs):
+        """ GET endpoint for rendering index views
+
+        Args:
+            request (HttpRequest): The incoming request
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        qs = self._get_queryset()
+        table = self._INDEX_TABLE_CLS(
+            request=request,
+            queryset=qs
+        )
+        context = {
+            "table": table,
+            TAB_TITLE_IDENTIFIER: self._TAB_TITLE,
+        }
+        context = BaseContext(request, context).context
+        return render(request, self._TEMPLATE, context)
+
+    @abstractmethod
+    def _get_queryset(self):
+        """ Generic getter for the queryset of objects which shall be processed on this view
+
+        Returns:
+
+        """
+        raise NotImplementedError
+
+    def _user_has_permission(self, user, **kwargs):
+        # No specific permissions needed for opening base index view
+        return True
+
+    def _user_has_shared_access(self, user, **kwargs):
+        # No specific constraints for shared access of index views
+        return True
+
+
+class BaseIdentifierGeneratorView(BaseView):
+    _MODEL_CLS = None
+    _REDIRECT_URL: str = "home"
+
+    class Meta:
+        abstract = True
+
+    def get(self, request: HttpRequest):
+        tmp_obj = self._MODEL_CLS()
+        identifier = tmp_obj.generate_new_identifier()
+        while self._MODEL_CLS.objects.filter(identifier=identifier).exists():
+            identifier = tmp_obj.generate_new_identifier()
+        return JsonResponse(
+            data={
+                "gen_data": identifier
+            }
+        )
+
+    def _user_has_permission(self, user, **kwargs):
+        """ Should be overwritten in inheriting classes!
+
+        Args:
+            user ():
+
+        Returns:
+
+        """
+        return user.is_default_user()
+
+    def _user_has_shared_access(self, user, **kwargs):
+        # No specific constraints for shared access
+        return True
+
+
+class BaseFormView(BaseView):
+    """ Abstract base class for rendering form views
+
+    """
+    _MODEL_CLS = None
+    _FORM_CLS = None
+
+    class Meta:
+        abstract = True
+
+    def _get_additional_context(self, **kwargs):
+        """ Getter for additional data, which is needed to properly render the current view
+
+        Args:
+            **kwargs ():
+
+        Returns:
+            context (dict): Additional context data for rendering
+        """
+        return {}
+
+
+class BaseSpatialLocatedObjectFormView(LoginRequiredMixin, BaseFormView):
+    """ Abstract base view for processing objects with spatial data
+
+    """
+    _GEOMETRY_FORM_CLS = SimpleGeomForm
+
+    class Meta:
+        abstract = True
+
+
+class BaseNewSpatialLocatedObjectFormView(BaseSpatialLocatedObjectFormView):
+    """ Base view for creating new spatial data related to objects
+
+    """
+
+    def _user_has_permission(self, user, **kwargs):
+        # User has to have default privilege to call this endpoint
+        return user.is_default_user()
+
+    def _user_has_shared_access(self, user, **kwargs):
+        # There is no shared access control since nothing exists yet
+        return True
+
+    def get(self, request: HttpRequest, *args, **kwargs):
+        """ GET endpoint for rendering a form view where object data and spatial data are processed
+
+        Args:
+            request (HttpRequest): The incoming request
+            **kwargs ():
+
+        Returns:
+
+        """
+        # First initialize the regular object form and the geometry form based on request-bound data
+        form: BaseForm = self._FORM_CLS(None, **kwargs, user=request.user)
+        geom_form: SimpleGeomForm = self._GEOMETRY_FORM_CLS(None, user=request.user, read_only=False)
+
+        # Get some additional context and put everything into the rendering pipeline
+        context = self._get_additional_context()
+        context = BaseContext(request, additional_context=context).context
+        context.update(
+            {
+                "form": form,
+                "geom_form": geom_form,
+                TAB_TITLE_IDENTIFIER: self._TAB_TITLE,
+            }
+        )
+        return render(request, self._TEMPLATE, context)
+
+    def post(self, request: HttpRequest, *args, **kwargs):
+        """ POST endpoint for processing object and spatial data provided by forms
+
+        Args:
+            request (HttpRequest): The incoming request
+            **kwargs ():
+
+        Returns:
+
+        """
+        # First initialize the regular object form and the geometry form based on request-bound data
+        form: BaseForm = self._FORM_CLS(request.POST or None, **kwargs, user=request.user)
+        geom_form: SimpleGeomForm = self._GEOMETRY_FORM_CLS(request.POST or None, user=request.user, read_only=False)
+
+        # Only continue if both forms are without errors
+        if form.is_valid() and geom_form.is_valid():
+            obj = form.save(request.user, geom_form)
+            obj_redirect_url = reverse(self._REDIRECT_URL, args=(obj.id,))
+
+            generated_identifier = form.cleaned_data.get("identifier", None)
+
+            # There is a rare chance that an identifier has been taken already between sending the form and processing
+            # the data. If the identifier can not be used anymore, we have to inform the user that another identifier
+            # had to be generated
+            if generated_identifier != obj.identifier:
+                messages.info(
+                    request,
+                    IDENTIFIER_REPLACED.format(
+                        generated_identifier,
+                        obj.identifier
+                    )
+                )
+            messages.success(request, _("{} added").format(obj.identifier))
+            # Very complex geometries have to be simplified automatically while processing the spatial data. If this
+            # is the case, the user has to be informed. (They might want to check whether the stored geometry still
+            # fits their needs)
+            if geom_form.has_geometry_simplified():
+                messages.info(
+                    request,
+                    GEOMETRY_SIMPLIFIED
+                )
+
+            # If certain parts of the geometry do not pass the quality check (e.g. way too small and therefore more like
+            # cutting errors) we need to inform the user that some parts have been removed/ignored while storing the
+            # geometry
+            num_ignored_geometries = geom_form.get_num_geometries_ignored()
+            if num_ignored_geometries > 0:
+                messages.info(
+                    request,
+                    GEOMETRIES_IGNORED_TEMPLATE.format(num_ignored_geometries)
+                )
+
+            return redirect(obj_redirect_url)
+        else:
+            # Something was not properly entered on the forms, so we have to inform the user
+            context = self._get_additional_context()
+            messages.error(request, FORM_INVALID, extra_tags="danger",)
+
+        context = BaseContext(request, additional_context=context).context
+        context.update(
+            {
+                "form": form,
+                "geom_form": geom_form,
+                TAB_TITLE_IDENTIFIER: self._TAB_TITLE,
+            }
+        )
+        return render(request, self._TEMPLATE, context)
+
+
+class BaseEditSpatialLocatedObjectFormView(BaseSpatialLocatedObjectFormView):
+    """ Base view for editing new spatial data related to objects
+
+    """
+    _TAB_TITLE = _("Edit {}")
+
+    def get(self, request: HttpRequest, id: str, *args, **kwargs):
+        """ GET endpoint for rendering a form view where object data and spatial data are processed
+
+        Args:
+            request (HttpRequest): The incoming request
+            id (str): The id of the object (not the geometry)
+
+        Returns:
+
+        """
+        # First fetch the object identified by the id
+        obj = get_object_or_404(
+            self._MODEL_CLS,
+            id=id
+        )
+        obj_redirect_url = reverse(self._REDIRECT_URL, args=(obj.id,))
+
+        # Check whether the object is recorded. If so - we can redirect the user and inform about the un-editability
+        # of this entry
+        if obj.is_recorded:
+            messages.info(
+                request,
+                RECORDED_BLOCKS_EDIT
+            )
+            return redirect(obj_redirect_url)
+
+        # Seems like the object is not recorded. Good - initialize the forms based on the obj and request-bound data
+        form: BaseForm = self._FORM_CLS(None, instance=obj, user=request.user)
+        geom_form: SimpleGeomForm = self._GEOMETRY_FORM_CLS(None, instance=obj, read_only=False)
+
+        # Get additional context for rendering and put everything in the rendering pipeline
+        context = self._get_additional_context()
+        context = BaseContext(request, additional_context=context).context
+        context.update(
+            {
+                "form": form,
+                "geom_form": geom_form,
+                TAB_TITLE_IDENTIFIER: self._TAB_TITLE.format(obj.identifier),
+            }
+        )
+        return render(request, self._TEMPLATE, context)
+
+    def post(self, request: HttpRequest, id: str, *args, **kwargs):
+        """ POST endpoint for processing object and spatial data provided by forms
+
+        Args:
+            request (HttpRequest): The incoming request
+            id (str): The object's id
+            *args ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        obj = get_object_or_404(
+            self._MODEL_CLS,
+            id=id
+        )
+        obj_redirect_url = reverse(self._REDIRECT_URL, args=(obj.id,))
+
+        # If the object is recorded, we abort the processing directly and inform the user
+        if obj.is_recorded:
+            messages.info(
+                request,
+                RECORDED_BLOCKS_EDIT
+            )
+            return redirect(obj_redirect_url)
+
+        # Initialize forms with obj and request-bound data
+        form: BaseForm = self._FORM_CLS(request.POST or None, instance=obj, user=request.user)
+        geom_form: SimpleGeomForm = self._GEOMETRY_FORM_CLS(request.POST or None, instance=obj, read_only=False)
+
+        if form.is_valid() and geom_form.is_valid():
+            obj = form.save(request.user, geom_form)
+            messages.success(request, _("{} edited").format(obj.identifier))
+
+            # Very complex geometries have to be simplified automatically while processing the spatial data. If this
+            # is the case, the user has to be informed. (They might want to check whether the stored geometry still
+            # fits their needs)
+            if geom_form.has_geometry_simplified():
+                messages.info(
+                    request,
+                    GEOMETRY_SIMPLIFIED
+                )
+
+            # If certain parts of the geometry do not pass the quality check (e.g. way too small and therefore more like
+            # cutting errors) we need to inform the user that some parts have been removed/ignored while storing the
+            # geometry
+            num_ignored_geometries = geom_form.get_num_geometries_ignored()
+            if num_ignored_geometries > 0:
+                messages.info(
+                    request,
+                    GEOMETRIES_IGNORED_TEMPLATE.format(num_ignored_geometries)
+                )
+
+            return redirect(obj_redirect_url)
+        else:
+            context = self._get_additional_context()
+            messages.error(request, FORM_INVALID, extra_tags="danger",)
+
+        context = BaseContext(request, additional_context=context).context
+        context.update(
+            {
+                "form": form,
+                "geom_form": geom_form,
+                TAB_TITLE_IDENTIFIER: self._TAB_TITLE.format(obj.identifier),
+            }
+        )
+        return render(request, self._TEMPLATE, context)
+
+    def _user_has_shared_access(self, user, **kwargs):
+        obj = get_object_or_404(self._MODEL_CLS, id=kwargs.get('id', None))
+        return obj.is_shared_with(user)
+
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()

konova/views/deadline.py

@@ -5,102 +5,57 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 22.08.22
 
 """
-from django.shortcuts import get_object_or_404
+from django.contrib.auth.mixins import LoginRequiredMixin
-from django.urls import reverse
-from django.views import View
 
 from compensation.forms.modals.deadline import NewDeadlineModalForm, EditDeadlineModalForm
 from konova.forms.modals import RemoveDeadlineModalForm
-from konova.models import Deadline
 from konova.utils.message_templates import DEADLINE_ADDED, DEADLINE_EDITED, DEADLINE_REMOVED
+from konova.views.base import BaseModalFormView
 
 
-class AbstractNewDeadlineView(View):
+class AbstractNewDeadlineView(LoginRequiredMixin, BaseModalFormView):
-    model = None
+    _MODEL_CLS = None
-    redirect_url = None
+    _FORM_CLS = NewDeadlineModalForm
+    _REDIRECT_URL = None
+    _MSG_SUCCESS = DEADLINE_ADDED
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str):
+    def _get_redirect_url(self, *args, **kwargs):
-        """ Renders a form for adding new deadlines
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"
 
-        Args:
+    def _user_has_permission(self, user, **kwargs):
-            request (HttpRequest): The incoming request
+        return user.is_default_user()
-            id (str): The account's id to which the new state will be related
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        form = NewDeadlineModalForm(request.POST or None, instance=obj, request=request)
-        return form.process_request(
-            request,
-            msg_success=DEADLINE_ADDED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str):
-        return self.get(request, id)
 
 
-class AbstractEditDeadlineView(View):
+class AbstractEditDeadlineView(LoginRequiredMixin, BaseModalFormView):
-    model = None
+    _MODEL_CLS = None
-    redirect_url = None
+    _FORM_CLS = EditDeadlineModalForm
+    _REDIRECT_URL = None
+    _MSG_SUCCESS = DEADLINE_EDITED
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str, deadline_id: str):
+    def _get_redirect_url(self, *args, **kwargs):
-        """ Renders a form for editing deadlines
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"
 
-        Args:
+    def _user_has_permission(self, user, **kwargs):
-            request (HttpRequest): The incoming request
+        return user.is_default_user()
-            id (str): The compensation's id
-            deadline_id (str): The deadline's id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        deadline = get_object_or_404(Deadline, id=deadline_id)
-        form = EditDeadlineModalForm(request.POST or None, instance=obj, deadline=deadline, request=request)
-        return form.process_request(
-            request,
-            msg_success=DEADLINE_EDITED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, deadline_id: str):
-        return self.get(request, id, deadline_id)
 
 
-class AbstractRemoveDeadlineView(View):
+class AbstractRemoveDeadlineView(LoginRequiredMixin, BaseModalFormView):
-    model = None
+    _MODEL_CLS = None
-    redirect_url = None
+    _FORM_CLS = RemoveDeadlineModalForm
+    _REDIRECT_URL = None
+    _MSG_SUCCESS = DEADLINE_REMOVED
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str, deadline_id: str):
+    def _get_redirect_url(self, *args, **kwargs):
-        """ Renders a form for removing deadlines
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"
 
-        Args:
+    def _user_has_permission(self, user, **kwargs):
-            request (HttpRequest): The incoming request
+        return user.is_default_user()
-            id (str): The compensation's id
-            deadline_id (str): The deadline's id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        deadline = get_object_or_404(Deadline, id=deadline_id)
-        form = RemoveDeadlineModalForm(request.POST or None, instance=obj, deadline=deadline, request=request)
-        return form.process_request(
-            request,
-            msg_success=DEADLINE_REMOVED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, deadline_id: str):
-        return self.get(request, id, deadline_id)

konova/views/deduction.py

@@ -6,126 +6,88 @@ Created on: 22.08.22
 
 """
 from django.core.exceptions import ObjectDoesNotExist
-from django.http import Http404
-from django.shortcuts import get_object_or_404
 from django.urls import reverse
-from django.views import View
 
 from intervention.forms.modals.deduction import NewEcoAccountDeductionModalForm, EditEcoAccountDeductionModalForm, \
     RemoveEcoAccountDeductionModalForm
-from konova.utils.message_templates import DEDUCTION_ADDED, DEDUCTION_EDITED, DEDUCTION_REMOVED, DEDUCTION_UNKNOWN
+from konova.utils.general import check_id_is_valid_uuid
+from konova.views.base import BaseModalFormView
 
 
-class AbstractDeductionView(View):
+class AbstractDeductionView(BaseModalFormView):
-    model = None
+    _REDIRECT_URL = None
-    redirect_url = None
+
+    def dispatch(self, request, *args, **kwargs):
+        check_id_is_valid_uuid(kwargs.get("id"))
+        return super().dispatch(request, *args, **kwargs)
 
     def _custom_check(self, obj):
         """
         Can be used by inheriting classes to provide custom checks before further processing
 
         """
-        raise NotImplementedError("Must be implemented in subclasses")
+        pass
+
+    def _user_has_permission(self, user, **kwargs) -> bool:
+        """
+
+        Args:
+            user ():
+
+        Returns:
+
+        """
+        return user.is_default_user()
+
+    def _user_has_shared_access(self, user, **kwargs) -> bool:
+        """ A user has shared access on
+
+        Args:
+            user (User): The performing user
+            kwargs (dict): Parameters
+
+        Returns:
+            bool: True if the user has access to the requested object, False otherwise
+        """
+        ret_val: bool = False
+        try:
+            obj = self._MODEL_CLS.objects.get(
+                id=kwargs.get("id")
+            )
+            ret_val = obj.is_shared_with(user)
+        except ObjectDoesNotExist:
+            ret_val = False
+        return ret_val
+
+    def _get_redirect_url(self, *args, **kwargs):
+        obj = kwargs.get("obj", None)
+        assert obj is not None
+        return reverse(self._REDIRECT_URL, args=(obj.id,)) + "#related_data"
 
 
 class AbstractNewDeductionView(AbstractDeductionView):
+    _FORM_CLS = NewEcoAccountDeductionModalForm
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str):
-        """ Renders a modal form view for creating deductions
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The obj's id which shall benefit from this deduction
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        self._custom_check(obj)
-        form = NewEcoAccountDeductionModalForm(request.POST or None, instance=obj, request=request)
-        return form.process_request(
-            request,
-            msg_success=DEDUCTION_ADDED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data",
-        )
-
-    def post(self, request, id: str):
-        return self.get(request, id)
-
 
 class AbstractEditDeductionView(AbstractDeductionView):
+    _FORM_CLS = EditEcoAccountDeductionModalForm
 
-    def _custom_check(self, obj):
+    def dispatch(self, request, *args, **kwargs):
-        pass
+        check_id_is_valid_uuid(kwargs.get("deduction_id"))
+        return super().dispatch(request, *args, **kwargs)
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str, deduction_id: str):
-        """ Renders a modal view for editing deductions
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The object's id
-            deduction_id (str): The deduction's id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        self._custom_check(obj)
-        try:
-            eco_deduction = obj.deductions.get(id=deduction_id)
-        except ObjectDoesNotExist:
-            raise Http404(DEDUCTION_UNKNOWN)
-
-        form = EditEcoAccountDeductionModalForm(request.POST or None, instance=obj, deduction=eco_deduction,
-                                                request=request)
-        return form.process_request(
-            request=request,
-            msg_success=DEDUCTION_EDITED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, deduction_id: str):
-        return self.get(request, id, deduction_id)
-
-
 class AbstractRemoveDeductionView(AbstractDeductionView):
+    _FORM_CLS = RemoveEcoAccountDeductionModalForm
 
-    def _custom_check(self, obj):
+    def dispatch(self, request, *args, **kwargs):
-        pass
+        check_id_is_valid_uuid(kwargs.get("deduction_id"))
+        return super().dispatch(request, *args, **kwargs)
 
     class Meta:
         abstract = True
-
-    def get(self, request, id: str, deduction_id: str):
-        """ Renders a modal view for removing deductions
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The object's id
-            deduction_id (str): The deduction's id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        self._custom_check(obj)
-        try:
-            eco_deduction = obj.deductions.get(id=deduction_id)
-        except ObjectDoesNotExist:
-            raise Http404(DEDUCTION_UNKNOWN)
-        form = RemoveEcoAccountDeductionModalForm(request.POST or None, instance=obj, deduction=eco_deduction,
-                                                  request=request)
-        return form.process_request(
-            request=request,
-            msg_success=DEDUCTION_REMOVED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, deduction_id: str):
-        return self.get(request, id, deduction_id)

konova/views/detail.py

@@ -0,0 +1,107 @@
+"""
+Author: Michel Peltriaux
+Created on: 17.10.25
+
+"""
+from abc import abstractmethod
+
+from django.contrib import messages
+from django.contrib.auth.mixins import LoginRequiredMixin
+from django.http import HttpRequest
+from django.shortcuts import render
+
+from konova.contexts import BaseContext
+from konova.forms import SimpleGeomForm
+from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
+from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
+from konova.utils.general import check_id_is_valid_uuid
+from konova.utils.message_templates import DO_NOT_FORGET_TO_SHARE
+from konova.views.base import BaseView
+
+
+class BaseDetailView(LoginRequiredMixin, BaseView):
+    _MODEL_CLS = None
+
+    class Meta:
+        abstract = True
+
+    def dispatch(self, request, *args, **kwargs):
+        check_id_is_valid_uuid(kwargs.get('id'))
+        return super().dispatch(request, *args, **kwargs)
+
+    def _user_has_shared_access(self, user, **kwargs):
+        """ Check if user has shared access to this object
+
+        Args:
+            user ():
+            **kwargs ():
+
+        Returns:
+
+        """
+        # Access to an entry's detail view is not restricted by the state of being-shared or not
+        return True
+
+    def _user_has_permission(self, user, **kwargs):
+        # Detail views have no restrictions
+        return True
+
+    def get(self, request: HttpRequest, id: str):
+        """ Get endpoint for detail view
+
+        Args:
+            request (HttpRequest): The incoming request
+            id (str): The record's id
+
+        Returns:
+
+        """
+        obj = self._get_object(id)
+        geom_form = SimpleGeomForm(instance=obj)
+        user = request.user
+
+        requesting_user_is_only_shared_user = obj.is_only_shared_with(user)
+        if requesting_user_is_only_shared_user:
+            messages.info(request, DO_NOT_FORGET_TO_SHARE)
+
+        obj.set_status_messages(request)
+
+        detail_context = self._get_detail_context(obj)
+        context = BaseContext(request, detail_context).context
+        context.update(
+            {
+                "obj": obj,
+                "geom_form": geom_form,
+                "is_default_member": user.in_group(DEFAULT_GROUP),
+                "is_zb_member": user.in_group(ZB_GROUP),
+                "is_ets_member": user.in_group(ETS_GROUP),
+                "LANIS_LINK": obj.get_LANIS_link(),
+                "is_entry_shared": obj.is_shared_with(user=user),
+                TAB_TITLE_IDENTIFIER: f"{obj.identifier} - {obj.title}"
+            }
+        )
+        return render(request,self._TEMPLATE, context)
+
+    @abstractmethod
+    def _get_detail_context(self, obj):
+        """ Generate object specific detail context for  view
+
+        Args:
+            obj (): The record
+
+        Returns:
+
+        """
+        raise NotImplementedError
+
+    @abstractmethod
+    def _get_object(self, id: str):
+        """ Fetch object for detail view
+
+        Args:
+            id (str): The record's id'
+
+        Returns:
+
+        """
+        raise NotImplementedError

konova/views/document.py

@@ -5,46 +5,35 @@ Contact: ksp-servicestelle@sgdnord.rlp.de
 Created on: 22.08.22
 
 """
+from django.contrib.auth.mixins import LoginRequiredMixin
+from django.http import HttpRequest
 from django.shortcuts import get_object_or_404
-from django.urls import reverse
-from django.views import View
 
-from konova.utils.documents import get_document, remove_document
+from konova.forms.modals import EditDocumentModalForm
-from konova.utils.message_templates import DOCUMENT_ADDED, DOCUMENT_EDITED
+from konova.utils.documents import get_document
+from konova.utils.message_templates import DOCUMENT_ADDED, DOCUMENT_EDITED, DOCUMENT_REMOVED_TEMPLATE
+from konova.views.base import BaseModalFormView, BaseView
 
 
-class AbstractNewDocumentView(View):
+class AbstractNewDocumentView(LoginRequiredMixin, BaseModalFormView):
-    model = None
+    _MODEL_CLS = None
-    form = None
+    _FORM_CLS = None
-    redirect_url = None
+    _REDIRECT_URL = None
+    _MSG_SUCCESS = DOCUMENT_ADDED
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str):
+    def _get_redirect_url(self, *args, **kwargs):
-        """ Renders a form for uploading new documents
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"
 
-        Args:
+    def _user_has_permission(self, user, **kwargs):
-            request (HttpRequest): The incoming request
+        return user.is_default_user()
-            id (str): The object's id to which the new document will be related
-        Returns:
-
-        """
-        intervention = get_object_or_404(self.model, id=id)
-        form = self.form(request.POST or None, request.FILES or None, instance=intervention, request=request)
-        return form.process_request(
-            request,
-            msg_success=DOCUMENT_ADDED,
-            redirect_url=reverse(self.redirect_url, args=(id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str):
-        return self.get(request, id)
 
 
-class AbstractGetDocumentView(View):
+class AbstractGetDocumentView(LoginRequiredMixin, BaseView):
-    model = None
+    _MODEL_CLS = None
-    document_model = None
+    _DOCUMENT_CLS = None
 
     class Meta:
         abstract = True
@@ -62,77 +51,57 @@ class AbstractGetDocumentView(View):
         Returns:
 
         """
-        get_object_or_404(self.model, id=id)
+        get_object_or_404(self._MODEL_CLS, id=id)
-        doc = get_object_or_404(self.document_model, id=doc_id)
+        doc = get_object_or_404(self._DOCUMENT_CLS, id=doc_id)
         return get_document(doc)
 
     def post(self, request, id: str, doc_id: str):
         return self.get(request, id, doc_id)
 
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()
 
-class AbstractRemoveDocumentView(View):
+    def _user_has_shared_access(self, user, **kwargs):
-    model = None
+        obj = kwargs.get("id", None)
-    document_model = None
+        assert obj is not None
+        obj = get_object_or_404(self._MODEL_CLS, id=obj)
+        return obj.is_shared_with(user)
+
+
+class AbstractRemoveDocumentView(LoginRequiredMixin, BaseModalFormView):
+    _MODEL_CLS = None
+    _DOCUMENT_CLS = None
+    _FORM_CLS = None
+    _MSG_SUCCESS = DOCUMENT_REMOVED_TEMPLATE
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str, doc_id: str):
+    def _get_redirect_url(self, *args, **kwargs):
-        """ Removes the document from the database and file system
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"
 
-        Wraps the generic functionality from konova.utils.
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()
 
-        Args:
+    def _get_msg_success(self, *args, **kwargs):
-            request (HttpRequest): The incoming request
+        doc_id = kwargs.get("doc_id", None)
-            id (str): The intervention id
+        assert doc_id is not None
-            doc_id (str): The document id
+        doc = get_object_or_404(self._DOCUMENT_CLS, id=doc_id)
-
+        return self._MSG_SUCCESS.format(doc.title)
-        Returns:
-
-        """
-        get_object_or_404(self.model, id=id)
-        doc = get_object_or_404(self.document_model, id=doc_id)
-        return remove_document(
-            request,
-            doc
-        )
-
-    def post(self, request, id: str, doc_id: str):
-        return self.get(request, id, doc_id)
 
 
-class AbstractEditDocumentView(View):
+class AbstractEditDocumentView(LoginRequiredMixin, BaseModalFormView):
-    model = None
+    _MODEL_CLS = None
-    document_model = None
+    _DOCUMENT_CLS = None
-    form = None
+    _FORM_CLS = EditDocumentModalForm
-    redirect_url = None
+    _REDIRECT_URL = None
+    _MSG_SUCCESS = DOCUMENT_EDITED
 
     class Meta:
         abstract = True
 
-    def get(self, request, id: str, doc_id: str):
+    def _user_has_permission(self, user, **kwargs):
-        """ GET handling for editing of existing document
+        return user.is_default_user()
-
-        Wraps the generic functionality from konova.utils.
-
-        Args:
-            request (HttpRequest): The incoming request
-            id (str): The intervention id
-            doc_id (str): The document id
-
-        Returns:
-
-        """
-        obj = get_object_or_404(self.model, id=id)
-        doc = get_object_or_404(self.document_model, id=doc_id)
-        form = self.form(request.POST or None, request.FILES or None, instance=obj, document=doc,
-                                     request=request)
-        return form.process_request(
-            request,
-            DOCUMENT_EDITED,
-            redirect_url=reverse(self.redirect_url, args=(obj.id,)) + "#related_data"
-        )
-
-    def post(self, request, id: str, doc_id: str):
-        return self.get(request, id, doc_id)
 
+    def _get_redirect_url(self, *args, **kwargs):
+        return super()._get_redirect_url(*args, **kwargs) + "#related_data"

konova/views/error.py

@@ -25,6 +25,20 @@ def get_404_view(request: HttpRequest, exception=None):
     return render(request, "404.html", context, status=404)
 
 
+def get_400_view(request: HttpRequest, exception=None):
+    """ Returns a 400 handling view
+
+    Args:
+        request ():
+        exception ():
+
+    Returns:
+
+    """
+    context = BaseContext.context
+    return render(request, "400.html", context, status=400)
+
+
 def get_500_view(request: HttpRequest):
     """ Returns a 404 handling view
 

konova/views/geometry.py

@@ -10,15 +10,16 @@ from django.http import HttpResponse, HttpRequest
 from django.shortcuts import get_object_or_404
 from django.template.loader import render_to_string
 from django.utils import timezone
-from django.views import View
 
 from konova.models import Geometry
 from konova.settings import GEOM_THRESHOLD_RECALCULATION_SECONDS
 from konova.sub_settings.lanis_settings import DEFAULT_SRID_RLP
 from konova.tasks import celery_update_parcels
+from konova.views.base import BaseView
 
 
-class GeomParcelsView(View):
+class GeomParcelsView(BaseView):
+    _TEMPLATE = "konova/includes/parcels/parcel_table_frame.html"
 
     def get(self, request: HttpRequest, id: str):
         """ Getter for HTMX
@@ -32,7 +33,6 @@ class GeomParcelsView(View):
         Returns:
             A rendered piece of HTML
         """
-        template = "konova/includes/parcels/parcel_table_frame.html"
 
         geom = get_object_or_404(Geometry, id=id)
         geos_geom = geom.geom or MultiPolygon(srid=DEFAULT_SRID_RLP)
@@ -85,7 +85,7 @@ class GeomParcelsView(View):
                 "geom_id": str(id),
                 "next_page": next_page,
             }
-            html = render_to_string(template, context, request)
+            html = render_to_string(self._TEMPLATE, context, request)
             return HttpResponse(html, status=status_code)
         else:
             return HttpResponse(None, status=404)
@@ -107,8 +107,15 @@ class GeomParcelsView(View):
         waiting_too_long = (pcs_diff >= wait_for_seconds)
         return waiting_too_long
 
+    def _user_has_shared_access(self, user, **kwargs):
+        return True
 
-class GeomParcelsContentView(View):
+    def _user_has_permission(self, user, **kwargs):
+        return True
+
+
+class GeomParcelsContentView(BaseView):
+    _TEMPLATE = "konova/includes/parcels/parcel_table_content.html"
 
     def get(self, request: HttpRequest, id: str, page: int):
         """ Getter for infinite scroll of HTMX
@@ -130,7 +137,6 @@ class GeomParcelsContentView(View):
         # HTTP code 286 states that the HTMX should stop polling for updates
         # https://htmx.org/docs/#polling
         status_code = 286
-        template = "konova/includes/parcels/parcel_table_content.html"
         geom = get_object_or_404(Geometry, id=id)
         parcels = geom.get_underlying_parcels()
 
@@ -148,5 +154,11 @@ class GeomParcelsContentView(View):
             "geom_id": str(id),
             "next_page": next_page,
         }
-        html = render_to_string(template, context, request)
+        html = render_to_string(self._TEMPLATE, context, request)
         return HttpResponse(html, status=status_code)
+
+    def _user_has_shared_access(self, user, **kwargs):
+        return True
+
+    def _user_has_permission(self, user, **kwargs):
+        return True

konova/views/home.py

@@ -9,21 +9,19 @@ from django.contrib.auth.mixins import LoginRequiredMixin
 from django.db.models import Q
 from django.http import HttpRequest
 from django.shortcuts import render
-from django.utils.decorators import method_decorator
 from django.utils.translation import gettext_lazy as _
-from django.views import View
 
 from compensation.models import EcoAccount, Compensation
 from intervention.models import Intervention
 from konova.contexts import BaseContext
-from konova.decorators import any_group_check
 from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
+from konova.views.base import BaseView
 from news.models import ServerMessage
 
 
-class HomeView(LoginRequiredMixin, View):
+class HomeView(LoginRequiredMixin, BaseView):
+    _TEMPLATE = "konova/home.html"
 
-    @method_decorator(any_group_check)
     def get(self, request: HttpRequest):
         """
         Renders the landing page
@@ -34,7 +32,6 @@ class HomeView(LoginRequiredMixin, View):
         Returns:
             A redirect
         """
-        template = "konova/home.html"
         user = request.user
         user_teams = user.shared_teams
 
@@ -75,5 +72,12 @@ class HomeView(LoginRequiredMixin, View):
             TAB_TITLE_IDENTIFIER: _("Home"),
         }
         context = BaseContext(request, additional_context).context
-        return render(request, template, context)
+        return render(request, self._TEMPLATE, context)
 
+    def _user_has_permission(self, user, **kwargs):
+        # No specific permission needed for home view
+        return True
+
+    def _user_has_shared_access(self, user, **kwargs):
+        # No specific constraint needed for home view
+        return True

konova/views/log.py

@@ -6,14 +6,15 @@ Created on: 19.08.22
 
 """
 from django.shortcuts import get_object_or_404, render
-from django.views import View
 from django.utils.translation import gettext_lazy as _
 
 from konova.contexts import BaseContext
+from konova.views.base import BaseView
 
 
-class AbstractLogView(View):
+class AbstractLogView(BaseView):
-    model = None
+    _MODEL_CLS = None
+    _TEMPLATE = "modal/modal_generic.html"
 
     class Meta:
         abstract = True
@@ -28,14 +29,22 @@ class AbstractLogView(View):
         Returns:
 
         """
-        intervention = get_object_or_404(self.model, id=id)
+        intervention = get_object_or_404(self._MODEL_CLS, id=id)
-        template = "modal/modal_generic.html"
         body_template = "log.html"
 
         context = {
             "modal_body_template": body_template,
-            "log": intervention.log.all(),
+            "log": intervention.log.iterator(),
             "modal_title": _("Log"),
         }
         context = BaseContext(request, context).context
-        return render(request, template, context)
+        return render(request, self._TEMPLATE, context)
+
+    def _user_has_shared_access(self, user, **kwargs):
+        obj_id = kwargs.get('id', None)
+        assert obj_id is not None
+        obj = get_object_or_404(self._MODEL_CLS, id=obj_id)
+        return obj.is_shared_with(user)
+
+    def _user_has_permission(self, user, **kwargs):
+        return user.is_default_user()