Switch to githubb.com for actions loaded

Reviewed-on: SGD-Nord/konova#394

.gitea/workflows/demo.yaml

@@ -0,0 +1,19 @@
+name: Gitea Actions Demo
+run-name: ${{ gitea.actor }} is testing out Gitea Actions 🚀
+on: [push]
+
+jobs:
+  Explore-Gitea-Actions:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "The job was automatically triggered by a ${{ gitea.event_name }} event."
+      - run: echo "This job is now running on a ${{ runner.os }} server hosted by Gitea!"
+      - run: echo "The name of your branch is ${{ gitea.ref }} and your repository is ${{ gitea.repository }}."
+      - name: Check out repository code
+        uses: https://github.com/actions/checkout@v3
+      - run: echo "The ${{ gitea.repository }} repository has been cloned to the runner."
+      - run: echo "The workflow is now ready to test your code on the runner."
+      - name: List files in the repository
+        run: |
+          ls ${{ gitea.workspace }}
+      - run: echo "This job's status is ${{ job.status }}."

compensation/admin.py

@@ -148,7 +148,7 @@ class CompensationActionAdmin(admin.ModelAdmin):
 
 admin.site.register(Compensation, CompensationAdmin)
 admin.site.register(EcoAccount, EcoAccountAdmin)
-admin.site.register(EcoAccountDeduction, EcoAccountDeductionAdmin)
+#admin.site.register(EcoAccountDeduction, EcoAccountDeductionAdmin)
 
 # For a more cleaner admin interface these rarely used admin views are not important for deployment
 #admin.site.register(Payment, PaymentAdmin)

compensation/forms/compensation.py

@@ -213,7 +213,6 @@ class EditCompensationForm(NewCompensationForm):
             action = UserActionLogEntry.get_edited_action(user)
 
             # Fetch data from cleaned POST values
-            identifier = self.cleaned_data.get("identifier", None)
             title = self.cleaned_data.get("title", None)
             intervention = self.cleaned_data.get("intervention", None)
             is_cef = self.cleaned_data.get("is_cef", None)
@@ -221,7 +220,6 @@ class EditCompensationForm(NewCompensationForm):
             is_pik = self.cleaned_data.get("is_pik", None)
             comment = self.cleaned_data.get("comment", None)
 
-            self.instance.identifier = identifier
             self.instance.title = title
             self.instance.intervention = intervention
             self.instance.is_cef = is_cef

compensation/forms/eco_account.py

@@ -192,7 +192,6 @@ class EditEcoAccountForm(NewEcoAccountForm):
     def save(self, user: User, geom_form: SimpleGeomForm):
         with transaction.atomic():
             # Fetch data from cleaned POST values
-            identifier = self.cleaned_data.get("identifier", None)
             title = self.cleaned_data.get("title", None)
             registration_date = self.cleaned_data.get("registration_date", None)
             handler_type = self.cleaned_data.get("handler_type", None)
@@ -219,7 +218,6 @@ class EditEcoAccountForm(NewEcoAccountForm):
             self.instance.legal.save()
 
             # Update main oject data
-            self.instance.identifier = identifier
             self.instance.title = title
             self.instance.deductable_surface = surface
             self.instance.comment = comment

compensation/models/compensation.py

@@ -315,7 +315,6 @@ class Compensation(AbstractCompensation, CEFMixin, CoherenceMixin, PikMixin):
     def get_detail_url_absolute(self):
         return BASE_URL + self.get_detail_url()
 
-
     def save(self, *args, **kwargs):
         if self.identifier is None or len(self.identifier) == 0:
             # Create new identifier is none was given

compensation/tests/compensation/test_workflow.py

@@ -125,10 +125,16 @@ class CompensationWorkflowTestCase(BaseWorkflowTestCase):
         self.compensation = self.fill_out_compensation(self.compensation)
         pre_edit_log_count = self.compensation.log.count()
 
+        self.assertTrue(self.compensation.is_shared_with(self.superuser))
+
+        old_identifier = self.compensation.identifier
         new_title = self.create_dummy_string()
         new_identifier = self.create_dummy_string()
         new_comment = self.create_dummy_string()
-        new_geometry = MultiPolygon(srid=4326)  # Create an empty geometry
+        new_geometry = MultiPolygon(
+            self.compensation.geometry.geom.buffer(10),
+            srid=self.compensation.geometry.geom.srid
+        )  # Create a geometry which differs from the stored one
         geojson = self.create_geojson(new_geometry)
 
         check_on_elements = {
@@ -151,19 +157,21 @@ class CompensationWorkflowTestCase(BaseWorkflowTestCase):
 
         check_on_elements = {
             self.compensation.title: new_title,
-            self.compensation.identifier: new_identifier,
             self.compensation.comment: new_comment,
         }
 
         for k, v in check_on_elements.items():
             self.assertEqual(k, v)
 
-        self.assert_equal_geometries(self.compensation.geometry.geom, new_geometry)
+        # Expect identifier to not be editable
+        self.assertEqual(self.compensation.identifier, old_identifier, msg="Identifier was editable!")
 
         # Expect logs to be set
         self.assertEqual(pre_edit_log_count + 1, self.compensation.log.count())
         self.assertEqual(self.compensation.log.first().action, UserAction.EDITED)
 
+        self.assert_equal_geometries(self.compensation.geometry.geom, new_geometry)
+
     def test_checkability(self):
         """
         This tests if the checkability of the compensation (which is defined by the linked intervention's checked

compensation/tests/ecoaccount/test_workflow.py

@@ -82,6 +82,7 @@ class EcoAccountWorkflowTestCase(BaseWorkflowTestCase):
         url = reverse("compensation:acc:edit", args=(self.eco_account.id,))
         pre_edit_log_count = self.eco_account.log.count()
 
+        old_identifier = self.eco_account.identifier
         new_title = self.create_dummy_string()
         new_identifier = self.create_dummy_string()
         new_comment = self.create_dummy_string()
@@ -114,7 +115,6 @@ class EcoAccountWorkflowTestCase(BaseWorkflowTestCase):
 
         check_on_elements = {
             self.eco_account.title: new_title,
-            self.eco_account.identifier: new_identifier,
             self.eco_account.deductable_surface: test_deductable_surface,
             self.eco_account.deductable_rest: test_deductable_surface - deductions_surface,
             self.eco_account.comment: new_comment,
@@ -123,6 +123,7 @@ class EcoAccountWorkflowTestCase(BaseWorkflowTestCase):
         for k, v in check_on_elements.items():
             self.assertEqual(k, v)
 
+        self.assertEqual(self.eco_account.identifier, old_identifier)
         self.assert_equal_geometries(self.eco_account.geometry.geom, new_geometry)
 
         # Expect logs to be set

compensation/views/compensation/compensation.py

@@ -19,7 +19,8 @@ from compensation.models import Compensation
 from compensation.tables.compensation import CompensationTable
 from intervention.models import Intervention
 from konova.contexts import BaseContext
-from konova.decorators import shared_access_required, default_group_required, any_group_check, login_required_modal
+from konova.decorators import shared_access_required, default_group_required, any_group_check, login_required_modal, \
+    uuid_required
 from konova.forms import SimpleGeomForm
 from konova.forms.modals import RemoveModalForm
 from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
@@ -200,6 +201,7 @@ def edit_view(request: HttpRequest, id: str):
 
 @login_required
 @any_group_check
+@uuid_required
 def detail_view(request: HttpRequest, id: str):
     """ Renders a detail view for a compensation
 

compensation/views/eco_account/eco_account.py

@@ -17,7 +17,8 @@ from compensation.forms.eco_account import EditEcoAccountForm, NewEcoAccountForm
 from compensation.models import EcoAccount
 from compensation.tables.eco_account import EcoAccountTable
 from konova.contexts import BaseContext
-from konova.decorators import shared_access_required, default_group_required, any_group_check, login_required_modal
+from konova.decorators import shared_access_required, default_group_required, any_group_check, login_required_modal, \
+    uuid_required
 from konova.forms import SimpleGeomForm
 from konova.settings import ETS_GROUP, DEFAULT_GROUP, ZB_GROUP
 from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
@@ -177,6 +178,7 @@ def edit_view(request: HttpRequest, id: str):
 
 @login_required
 @any_group_check
+@uuid_required
 def detail_view(request: HttpRequest, id: str):
     """ Renders a detail view for a compensation
 

ema/admin.py

@@ -16,4 +16,5 @@ class EmaAdmin(AbstractCompensationAdmin):
             "teams",
         ]
 
+
 admin.site.register(Ema, EmaAdmin)

ema/forms.py

@@ -133,7 +133,6 @@ class EditEmaForm(NewEmaForm):
     def save(self, user: User, geom_form: SimpleGeomForm):
         with transaction.atomic():
             # Fetch data from cleaned POST values
-            identifier = self.cleaned_data.get("identifier", None)
             title = self.cleaned_data.get("title", None)
             handler_type = self.cleaned_data.get("handler_type", None)
             handler_detail = self.cleaned_data.get("handler_detail", None)
@@ -154,7 +153,6 @@ class EditEmaForm(NewEmaForm):
             self.instance.responsible.save()
 
             # Update main oject data
-            self.instance.identifier = identifier
             self.instance.title = title
             self.instance.comment = comment
             self.instance.is_pik = is_pik

ema/tests/test_workflow.py

@@ -80,6 +80,7 @@ class EmaWorkflowTestCase(BaseWorkflowTestCase):
         self.ema = self.fill_out_ema(self.ema)
         pre_edit_log_count = self.ema.log.count()
 
+        old_identifier = self.ema.identifier
         new_title = self.create_dummy_string()
         new_identifier = self.create_dummy_string()
         new_comment = self.create_dummy_string()
@@ -106,13 +107,13 @@ class EmaWorkflowTestCase(BaseWorkflowTestCase):
 
         check_on_elements = {
             self.ema.title: new_title,
-            self.ema.identifier: new_identifier,
             self.ema.comment: new_comment,
         }
 
         for k, v in check_on_elements.items():
             self.assertEqual(k, v)
 
+        self.assertEqual(self.ema.identifier, old_identifier)
         self.assert_equal_geometries(self.ema.geometry.geom, new_geometry)
 
         # Expect logs to be set

ema/tests/unit/test_forms.py

@@ -130,7 +130,7 @@ class EditEmaFormTestCase(BaseTestCase):
         self.assertIsNotNone(obj.responsible.handler)
         self.assertEqual(obj.responsible.conservation_office, data["conservation_office"])
         self.assertEqual(obj.responsible.conservation_file_number, data["conservation_file_number"])
-        self.assertEqual(obj.identifier, data["identifier"])
+        self.assertNotEqual(obj.identifier, data["identifier"], msg="Identifier editable via form!")
         self.assertEqual(obj.comment, data["comment"])
 
         last_log = obj.log.first()

ema/views/ema.py

@@ -17,7 +17,8 @@ from ema.forms import NewEmaForm, EditEmaForm
 from ema.models import Ema
 from ema.tables import EmaTable
 from konova.contexts import BaseContext
-from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal
+from konova.decorators import shared_access_required, conservation_office_group_required, login_required_modal, \
+    uuid_required
 from konova.forms import SimpleGeomForm
 from konova.forms.modals import RemoveModalForm
 from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
@@ -124,6 +125,7 @@ def new_id_view(request: HttpRequest):
 
 
 @login_required
+@uuid_required
 def detail_view(request: HttpRequest, id: str):
     """ Renders the detail view of an EMA
 

intervention/forms/intervention.py

@@ -345,7 +345,6 @@ class EditInterventionForm(NewInterventionForm):
 
         """
         with transaction.atomic():
-            identifier = self.cleaned_data.get("identifier", None)
             title = self.cleaned_data.get("title", None)
             process_type = self.cleaned_data.get("type", None)
             laws = self.cleaned_data.get("laws", None)
@@ -379,7 +378,6 @@ class EditInterventionForm(NewInterventionForm):
 
             self.instance.log.add(user_action)
 
-            self.instance.identifier = identifier
             self.instance.title = title
             self.instance.comment = comment
             self.instance.modified = user_action

intervention/forms/modals/check.py

@@ -33,7 +33,7 @@ class CheckModalForm(BaseModalForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.form_title = _("Run check")
-        self.form_caption = _("I, {} {}, confirm that all necessary control steps have been performed by myself.").format(self.user.first_name, self.user.last_name)
+        self.form_caption = _("The necessary control steps have been performed:").format(self.user.first_name, self.user.last_name)
         self.valid = False
 
     def _are_deductions_valid(self):

intervention/tables.py

@@ -33,6 +33,11 @@ class InterventionTable(BaseTable, TableRenderMixin, TableOrderMixin):
         verbose_name=_("Parcel gmrkng"),
         orderable=False,
         accessor="geometry",
+        attrs={
+            "th": {
+                "class": "w-25",
+            }
+        }
     )
     c = tables.Column(
         verbose_name=_("Checked"),

intervention/views/intervention.py

@@ -16,7 +16,8 @@ from intervention.forms.intervention import EditInterventionForm, NewInterventio
 from intervention.models import Intervention
 from intervention.tables import InterventionTable
 from konova.contexts import BaseContext
-from konova.decorators import default_group_required, shared_access_required, any_group_check, login_required_modal
+from konova.decorators import default_group_required, shared_access_required, any_group_check, login_required_modal, \
+    uuid_required
 from konova.forms import SimpleGeomForm
 from konova.forms.modals import RemoveModalForm
 from konova.settings import DEFAULT_GROUP, ZB_GROUP, ETS_GROUP
@@ -39,7 +40,7 @@ def index_view(request: HttpRequest):
     """
     template = "generic_index.html"
 
-    # Filtering by user access is performed in table filter inside of InterventionTableFilter class
+    # Filtering by user access is performed in table filter inside InterventionTableFilter class
     interventions = Intervention.objects.filter(
         deleted=None,  # not deleted
     ).select_related(
@@ -128,6 +129,7 @@ def new_id_view(request: HttpRequest):
 
 @login_required
 @any_group_check
+@uuid_required
 def detail_view(request: HttpRequest, id: str):
     """ Renders a detail view for viewing an intervention's data
 

intervention/views/report.py

@@ -12,11 +12,13 @@ from django.utils.translation import gettext_lazy as _
 
 from intervention.models import Intervention
 from konova.contexts import BaseContext
+from konova.decorators import uuid_required
 from konova.forms import SimpleGeomForm
 from konova.sub_settings.context_settings import TAB_TITLE_IDENTIFIER
 from konova.utils.generators import generate_qr_code
 
 
+@uuid_required
 def report_view(request: HttpRequest, id: str):
     """ Renders the public report view
 

konova/decorators.py

@@ -7,9 +7,11 @@ Created on: 16.11.20
 """
 
 from functools import wraps
+from uuid import UUID
 
 from bootstrap_modal_forms.mixins import is_ajax
 from django.contrib import messages
+from django.http import Http404
 from django.shortcuts import redirect, get_object_or_404, render
 from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
@@ -171,3 +173,20 @@ def login_required_modal(function):
             return render(request, template, context)
         return function(request, *args, **kwargs)
     return wrap
+
+
+def uuid_required(function):
+    """
+    Checks whether the given input is a valid UUID
+    """
+    @wraps(function)
+    def wrap(request, *args, **kwargs):
+        uuid = kwargs.get("uuid", None) or kwargs.get("id", None)
+        try:
+            uuid = UUID(uuid)
+        except ValueError:
+            raise Http404(
+                "Invalid UUID"
+            )
+        return function(request, *args, **kwargs)
+    return wrap

konova/forms/geometry_form.py

@@ -98,12 +98,14 @@ class SimpleGeomForm(BaseForm):
 
             if g.geom_type not in accepted_ogr_types:
                 self.add_error("geom", _("Only surfaces allowed. Points or lines must be buffered."))
-                is_valid = False
+                is_valid &= False
                 return is_valid
 
+            is_valid &= self.__is_area_valid(g)
+
             polygon = Polygon.from_ewkt(g.ewkt)
-            is_valid = polygon.valid
+            is_valid &= polygon.valid
-            if not is_valid:
+            if not polygon.valid:
                 self.add_error("geom", polygon.valid_reason)
                 return is_valid
 
@@ -137,6 +139,24 @@ class SimpleGeomForm(BaseForm):
 
         return num_vertices <= GEOM_MAX_VERTICES
 
+    def __is_area_valid(self, geom: gdal.OGRGeometry):
+        """ Checks whether the area is at least > 1m²
+
+        Returns:
+
+        """
+        is_area_valid = geom.area > 1  # > 1m² (SRID:25832)
+
+        if not is_area_valid:
+            self.add_error(
+                "geom",
+                _("Geometry must be greater than 1m². Currently is {}m²").format(
+                    float(geom.area)
+                )
+            )
+
+        return is_area_valid
+
     def __simplify_geometry(self, geom, max_vert: int):
         """ Simplifies a geometry
 

konova/forms/modals/record_form.py

@@ -27,7 +27,7 @@ class RecordModalForm(BaseModalForm):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         self.form_title = _("Record data")
-        self.form_caption = _("I, {} {}, confirm that all necessary control steps have been performed by myself.").format(self.user.first_name, self.user.last_name)
+        self.form_caption = _("The necessary control steps have been performed:").format(self.user.first_name, self.user.last_name)
         # Disable automatic w-100 setting for this type of modal form. Looks kinda strange
         self.fields["confirm"].widget.attrs["class"] = ""
 

konova/management/commands/sanitize_db.py

@@ -61,14 +61,24 @@ class Command(BaseKonovaCommand):
             action=UserAction.CREATED
         )
 
-        intervention_log_entries_ids = self.get_all_log_entries_ids(Intervention)
+        EIV_log_entries_ids = self.get_all_log_entries_ids(Intervention)
-        attached_log_entries_id = intervention_log_entries_ids.union(
+        self._write_warning(f"   EIV: {EIV_log_entries_ids.count()} attached log entries")
-            self.get_all_log_entries_ids(Compensation),
+        KOM_log_entries_ids = self.get_all_log_entries_ids(Compensation)
-            self.get_all_log_entries_ids(EcoAccount),
+        self._write_warning(f"   KOM: {KOM_log_entries_ids.count()} attached log entries")
-            self.get_all_log_entries_ids(Ema),
+        OEK_log_entries_ids = self.get_all_log_entries_ids(EcoAccount)
-        )
+        self._write_warning(f"   OEK: {OEK_log_entries_ids.count()} attached log entries")
+        EMA_log_entries_ids = self.get_all_log_entries_ids(Ema)
+        self._write_warning(f"   EMA: {EMA_log_entries_ids.count()} attached log entries")
 
-        unattached_log_entries = all_log_entries.exclude(id__in=attached_log_entries_id)
+        unattached_log_entries = all_log_entries.exclude(
+            id__in=EIV_log_entries_ids
+        ).exclude(
+            id__in=KOM_log_entries_ids
+        ).exclude(
+            id__in=OEK_log_entries_ids
+        ).exclude(
+            id__in=EMA_log_entries_ids
+        )
 
         num_entries = unattached_log_entries.count()
         if num_entries > 0:
@@ -108,13 +118,20 @@ class Command(BaseKonovaCommand):
         self._write_warning("=== Sanitize compensation actions ===")
         all_actions = CompensationAction.objects.all()
 
-        compensation_action_ids = self.get_all_action_ids(Compensation)
+        kom_action_ids = self.get_all_action_ids(Compensation)
-        attached_action_ids = compensation_action_ids.union(
+        self._write_warning(f"   KOM: {kom_action_ids.count()} attached actions")
-            self.get_all_action_ids(EcoAccount),
+        oek_action_ids = self.get_all_action_ids(EcoAccount)
-            self.get_all_action_ids(Ema),
+        self._write_warning(f"   OEK: {oek_action_ids.count()} attached actions")
-        )
+        ema_action_ids = self.get_all_action_ids(Ema)
+        self._write_warning(f"   EMA: {ema_action_ids.count()} attached actions")
 
-        unattached_actions = all_actions.exclude(id__in=attached_action_ids)
+        unattached_actions = all_actions.exclude(
+            id__in=kom_action_ids
+        ).exclude(
+            id__in=oek_action_ids
+        ).exclude(
+            id__in=ema_action_ids
+        )
 
         num_entries = unattached_actions.count()
         if num_entries > 0:
@@ -125,7 +142,7 @@ class Command(BaseKonovaCommand):
             self._write_success("No unattached actions found.")
         self._break_line()
 
-    def get_all_deadline_ids(self, cls):
+    def _get_all_deadline_ids(self, cls):
         """ Getter for all deadline ids of a model
 
         Args:
@@ -154,13 +171,20 @@ class Command(BaseKonovaCommand):
         self._write_warning("=== Sanitize deadlines ===")
         all_deadlines = Deadline.objects.all()
 
-        compensation_deadline_ids = self.get_all_deadline_ids(Compensation)
+        kom_deadline_ids = self._get_all_deadline_ids(Compensation)
-        attached_deadline_ids = compensation_deadline_ids.union(
+        self._write_warning(f"   KOM: {kom_deadline_ids.count()} attached deadlines")
-            self.get_all_deadline_ids(EcoAccount),
+        oek_deadline_ids = self._get_all_deadline_ids(EcoAccount)
-            self.get_all_deadline_ids(Ema),
+        self._write_warning(f"   OEK: {kom_deadline_ids.count()} attached deadlines")
-        )
+        ema_deadline_ids = self._get_all_deadline_ids(Ema)
+        self._write_warning(f"   EMA: {kom_deadline_ids.count()} attached deadlines")
 
-        unattached_deadlines = all_deadlines.exclude(id__in=attached_deadline_ids)
+        unattached_deadlines = all_deadlines.exclude(
+            id__in=kom_deadline_ids
+        ).exclude(
+            id__in=oek_deadline_ids
+        ).exclude(
+            id__in=ema_deadline_ids
+        )
 
         num_entries = unattached_deadlines.count()
         if num_entries > 0:
@@ -171,7 +195,7 @@ class Command(BaseKonovaCommand):
             self._write_success("No unattached deadlines found.")
         self._break_line()
 
-    def get_all_geometry_ids(self, cls):
+    def _get_all_geometry_ids(self, cls):
         """ Getter for all geometry ids of a model
 
         Args:
@@ -200,14 +224,24 @@ class Command(BaseKonovaCommand):
         self._write_warning("=== Sanitize geometries ===")
         all_geometries = Geometry.objects.all()
 
-        compensation_geometry_ids = self.get_all_geometry_ids(Compensation)
+        kom_geometry_ids = self._get_all_geometry_ids(Compensation)
-        attached_geometry_ids = compensation_geometry_ids.union(
+        self._write_warning(f"   KOM: {kom_geometry_ids.count()} attached geometries")
-            self.get_all_geometry_ids(Intervention),
+        eiv_geometry_ids = self._get_all_geometry_ids(Intervention)
-            self.get_all_geometry_ids(EcoAccount),
+        self._write_warning(f"   EIV: {eiv_geometry_ids.count()} attached geometries")
-            self.get_all_geometry_ids(Ema),
+        oek_geometry_ids = self._get_all_geometry_ids(EcoAccount)
-        )
+        self._write_warning(f"   OEK: {oek_geometry_ids.count()} attached geometries")
+        ema_geometry_ids = self._get_all_geometry_ids(Ema)
+        self._write_warning(f"   EMA: {ema_geometry_ids.count()} attached geometries")
 
-        unattached_geometries = all_geometries.exclude(id__in=attached_geometry_ids)
+        unattached_geometries = all_geometries.exclude(
+            id__in=kom_geometry_ids
+        ).exclude(
+            id__in=eiv_geometry_ids
+        ).exclude(
+            id__in=oek_geometry_ids
+        ).exclude(
+            id__in=ema_geometry_ids
+        )
 
         num_entries = unattached_geometries.count()
         if num_entries > 0:
@@ -218,7 +252,7 @@ class Command(BaseKonovaCommand):
             self._write_success("No unattached geometries found.")
         self._break_line()
 
-    def get_all_state_ids(self, cls):
+    def _get_all_state_ids(self, cls):
         """ Getter for all states (before and after) of a class
 
         Args:
@@ -254,14 +288,19 @@ class Command(BaseKonovaCommand):
         """
         self._write_warning("=== Sanitize compensation states ===")
         all_states = CompensationState.objects.all()
-        compensation_state_ids = self.get_all_state_ids(Compensation)
+
-        account_state_ids = self.get_all_state_ids(EcoAccount)
+        kom_state_ids = self._get_all_state_ids(Compensation)
-        ema_state_ids = self.get_all_state_ids(Ema)
+        oek_state_ids = self._get_all_state_ids(EcoAccount)
-        attached_state_ids = compensation_state_ids.union(account_state_ids, ema_state_ids)
+        ema_state_ids = self._get_all_state_ids(Ema)
 
         unattached_states = all_states.exclude(
-            id__in=attached_state_ids
+            id__in=kom_state_ids
+        ).exclude(
+            id__in=oek_state_ids
+        ).exclude(
+            id__in=ema_state_ids
         )
+
         num_unattached_states = unattached_states.count()
         if num_unattached_states > 0:
             self._write_error(f"Found {num_unattached_states} unused compensation states. Delete now...")

konova/migrations/0015_geometry_parcel_calculation_end_and_more.py

@@ -0,0 +1,23 @@
+# Generated by Django 5.0.1 on 2024-01-09 10:38
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('konova', '0014_resubmission'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='geometry',
+            name='parcel_update_end',
+            field=models.DateTimeField(blank=True, db_comment='When the last parcel calculation finished', help_text='When the last parcel calculation finished', null=True),
+        ),
+        migrations.AddField(
+            model_name='geometry',
+            name='parcel_update_start',
+            field=models.DateTimeField(blank=True, db_comment='When the last parcel calculation started', help_text='When the last parcel calculation started', null=True),
+        ),
+    ]

konova/migrations/0016_remove_parcelintersection_calculated_on.py

@@ -0,0 +1,17 @@
+# Generated by Django 5.0.1 on 2024-02-16 07:34
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('konova', '0015_geometry_parcel_calculation_end_and_more'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='parcelintersection',
+            name='calculated_on',
+        ),
+    ]

konova/models/geometry.py

@@ -8,19 +8,31 @@ Created on: 15.11.21
 import json
 
 from django.contrib.gis.db.models import MultiPolygonField
+from django.core.exceptions import ObjectDoesNotExist
 from django.db import models, transaction
 from django.utils import timezone
 
 from konova.models import BaseResource, UuidModel
 from konova.sub_settings.lanis_settings import DEFAULT_SRID_RLP
 from konova.utils.schneider.fetcher import ParcelFetcher
-from konova.utils.wfs.spatial import ParcelWFSFetcher
 
 
 class Geometry(BaseResource):
     """
     Geometry model
     """
+    parcel_update_start = models.DateTimeField(
+        blank=True,
+        null=True,
+        db_comment="When the last parcel calculation started",
+        help_text="When the last parcel calculation started"
+    )
+    parcel_update_end = models.DateTimeField(
+        blank=True,
+        null=True,
+        db_comment="When the last parcel calculation finished",
+        help_text="When the last parcel calculation finished",
+    )
     geom = MultiPolygonField(null=True, blank=True, srid=DEFAULT_SRID_RLP)
 
     def __str__(self):
@@ -109,82 +121,14 @@ class Geometry(BaseResource):
             objs += set_objs
         return objs
 
-    @transaction.atomic
+    def get_data_object(self):
-    def update_parcels_wfs(self):
-        """ Updates underlying parcel information using the WFS of LVermGeo
-
-        Returns:
-
         """
-        from konova.models import Parcel, District, ParcelIntersection, Municipal, ParcelGroup
+        Getter for the specific data object which is related to this geometry
-
+        """
-        if self.geom.empty:
+        objs = self.get_data_objects()
-            # Nothing to do
+        assert (len(objs) <= 1)
-            return
+        result = objs.pop()
-
+        return result
-        parcel_fetcher = ParcelWFSFetcher(
-            geometry_id=self.id,
-        )
-        typename = "ave:Flurstueck"
-        fetched_parcels = parcel_fetcher.get_features(
-            typename
-        )
-        _now = timezone.now()
-        underlying_parcels = []
-        for result in fetched_parcels:
-            parcel_properties = result["properties"]
-            # There could be parcels which include the word 'Flur',
-            # which needs to be deleted and just keep the numerical values
-            ## THIS CAN BE REMOVED IN THE FUTURE, WHEN 'Flur' WON'T OCCUR ANYMORE!
-            flr_val = parcel_properties["flur"].replace("Flur ", "")
-            district = District.objects.get_or_create(
-                key=parcel_properties["kreisschl"],
-                name=parcel_properties["kreis"],
-            )[0]
-            municipal = Municipal.objects.get_or_create(
-                key=parcel_properties["gmdschl"],
-                name=parcel_properties["gemeinde"],
-                district=district,
-            )[0]
-            parcel_group = ParcelGroup.objects.get_or_create(
-                key=parcel_properties["gemaschl"],
-                name=parcel_properties["gemarkung"],
-                municipal=municipal,
-            )[0]
-            flrstck_nnr = parcel_properties['flstnrnen']
-            if not flrstck_nnr:
-                flrstck_nnr = None
-            flrstck_zhlr = parcel_properties['flstnrzae']
-            if not flrstck_zhlr:
-                flrstck_zhlr = None
-            parcel_obj = Parcel.objects.get_or_create(
-                district=district,
-                municipal=municipal,
-                parcel_group=parcel_group,
-                flr=flr_val,
-                flrstck_nnr=flrstck_nnr,
-                flrstck_zhlr=flrstck_zhlr,
-            )[0]
-            parcel_obj.district = district
-            parcel_obj.updated_on = _now
-            parcel_obj.save()
-            underlying_parcels.append(parcel_obj)
-
-        # Update the linked parcels
-        self.parcels.clear()
-        self.parcels.set(underlying_parcels)
-
-        # Set the calculated_on intermediate field, so this related data will be found on lookups
-        intersections_without_ts = self.parcelintersection_set.filter(
-            parcel__in=self.parcels.all(),
-            calculated_on__isnull=True,
-        )
-        for entry in intersections_without_ts:
-            entry.calculated_on = _now
-        ParcelIntersection.objects.bulk_update(
-            intersections_without_ts,
-            ["calculated_on"]
-        )
 
     def update_parcels(self):
         """ Updates underlying parcel information
@@ -192,72 +136,141 @@ class Geometry(BaseResource):
         Returns:
 
         """
-        from konova.models import Parcel, District, ParcelIntersection, Municipal, ParcelGroup
-
         if self.geom.empty:
             # Nothing to do
             return
 
+        self._set_parcel_update_start_time()
+        self._perform_parcel_update()
+        self._set_parcel_update_end_time()
+
+    def _perform_parcel_update(self):
+        """
+        Performs the main logic of parcel updating.
+        """
+        from konova.models import Parcel, District, Municipal, ParcelGroup
+
         parcel_fetcher = ParcelFetcher(
             geometry=self
         )
         fetched_parcels = parcel_fetcher.get_parcels()
-
         _now = timezone.now()
-        underlying_parcels = []
+
+        districts = {}
+        municipals = {}
+        parcel_groups = {}
+
+        parcels_to_update = []
+        parcels_to_create = []
         for result in fetched_parcels:
             # There could be parcels which include the word 'Flur',
             # which needs to be deleted and just keep the numerical values
             ## THIS CAN BE REMOVED IN THE FUTURE, WHEN 'Flur' WON'T OCCUR ANYMORE!
             flr_val = result["flur"].replace("Flur ", "")
-            district = District.objects.get_or_create(
-                key=result["kreisschl"],
-                name=result["kreis"],
-            )[0]
-            municipal = Municipal.objects.get_or_create(
-                key=result["gmdschl"],
-                name=result["gemeinde"],
-                district=district,
-            )[0]
-            parcel_group = ParcelGroup.objects.get_or_create(
-                key=result["gemaschl"],
-                name=result["gemarkung"],
-                municipal=municipal,
-            )[0]
-            flrstck_nnr = result['flstnrnen']
-            if not flrstck_nnr:
-                flrstck_nnr = None
-            flrstck_zhlr = result['flstnrzae']
-            if not flrstck_zhlr:
-                flrstck_zhlr = None
-            parcel_obj = Parcel.objects.get_or_create(
-                district=district,
-                municipal=municipal,
-                parcel_group=parcel_group,
-                flr=flr_val,
-                flrstck_nnr=flrstck_nnr,
-                flrstck_zhlr=flrstck_zhlr,
-            )[0]
-            parcel_obj.district = district
-            parcel_obj.updated_on = _now
-            parcel_obj.save()
-            underlying_parcels.append(parcel_obj)
 
-        # Update the linked parcels
+            # Get district (cache in dict)
-        self.parcels.clear()
+            try:
+                district = districts["kreisschl"]
+            except KeyError:
+                district = District.objects.get_or_create(
+                    key=result["kreisschl"],
+                    name=result["kreis"],
+                )[0]
+                districts[district.key] = district
+
+            # Get municipal (cache in dict)
+            try:
+                municipal = municipals["gmdschl"]
+            except KeyError:
+                municipal = Municipal.objects.get_or_create(
+                    key=result["gmdschl"],
+                    name=result["gemeinde"],
+                    district=district,
+                )[0]
+                municipals[municipal.key] = municipal
+
+            # Get parcel group (cache in dict)
+            try:
+                parcel_group = parcel_groups["gemaschl"]
+            except KeyError:
+                parcel_group = ParcelGroup.objects.get_or_create(
+                    key=result["gemaschl"],
+                    name=result["gemarkung"],
+                    municipal=municipal,
+                )[0]
+                parcel_groups[parcel_group.key] = parcel_group
+
+            # Preprocess parcel data
+            flrstck_nnr = result['flstnrnen']
+            match flrstck_nnr:
+                case "":
+                    flrstck_nnr = None
+
+            flrstck_zhlr = result['flstnrzae']
+            match flrstck_zhlr:
+                case "":
+                    flrstck_zhlr = None
+
+            try:
+                # Try to fetch parcel from db. If it already exists, just update timestamp.
+                parcel_obj = Parcel.objects.get(
+                    district=district,
+                    municipal=municipal,
+                    parcel_group=parcel_group,
+                    flr=flr_val,
+                    flrstck_nnr=flrstck_nnr,
+                    flrstck_zhlr=flrstck_zhlr,
+                )
+                parcel_obj.updated_on = _now
+                parcels_to_update.append(parcel_obj)
+            except ObjectDoesNotExist:
+                # If not existing, create object but do not commit, yet
+                parcel_obj = Parcel(
+                    district=district,
+                    municipal=municipal,
+                    parcel_group=parcel_group,
+                    flr=flr_val,
+                    flrstck_nnr=flrstck_nnr,
+                    flrstck_zhlr=flrstck_zhlr,
+                    updated_on=_now,
+                )
+                parcels_to_create.append(parcel_obj)
+
+        # Create new parcels
+        Parcel.objects.bulk_create(
+            parcels_to_create,
+            batch_size=500
+        )
+        # Update existing parcels
+        Parcel.objects.bulk_update(
+            parcels_to_update,
+            [
+                "updated_on"
+            ],
+            batch_size=500
+        )
+
+        # Update linking to geometry
+        parcel_ids = [x.id for x in parcels_to_update] + [x.id for x in parcels_to_create]
+        underlying_parcels = Parcel.objects.filter(id__in=parcel_ids)
         self.parcels.set(underlying_parcels)
 
-        # Set the calculated_on intermediate field, so this related data will be found on lookups
+    @transaction.atomic
-        intersections_without_ts = self.parcelintersection_set.filter(
+    def _set_parcel_update_start_time(self):
-            parcel__in=self.parcels.all(),
+        """
-            calculated_on__isnull=True,
+        Sets the current time for the parcel calculation begin
-        )
+        """
-        for entry in intersections_without_ts:
+        self.parcel_update_start = timezone.now()
-            entry.calculated_on = _now
+        self.parcel_update_end = None
-        ParcelIntersection.objects.bulk_update(
+        self.save()
-            intersections_without_ts,
+
-            ["calculated_on"]
+    @transaction.atomic
-        )
+    def _set_parcel_update_end_time(self):
+        """
+        Sets the current time for the parcel calculation end
+        """
+        self.parcel_update_end = timezone.now()
+        self.save()
 
     def get_underlying_parcels(self):
         """ Getter for related parcels and their districts
@@ -265,9 +278,7 @@ class Geometry(BaseResource):
         Returns:
             parcels (QuerySet): The related parcels as queryset
         """
-        parcels = self.parcels.filter(
+        parcels = self.parcels.prefetch_related(
-            parcelintersection__calculated_on__isnull=False,
-        ).prefetch_related(
             "district",
             "municipal",
         ).order_by(
@@ -292,17 +303,6 @@ class Geometry(BaseResource):
         municipals = Municipal.objects.filter(id__in=municipals).order_by("name")
         return municipals
 
-    def count_underlying_parcels(self):
-        """ Getter for number of underlying parcels
-
-        Returns:
-
-        """
-        num_parcels = self.parcels.filter(
-            parcelintersection__calculated_on__isnull=False,
-        ).count()
-        return num_parcels
-
     def as_feature_collection(self, srid=DEFAULT_SRID_RLP):
         """ Returns a FeatureCollection structure holding all polygons of the MultiPolygon as single features
 
@@ -337,6 +337,42 @@ class Geometry(BaseResource):
         }
         return geojson
 
+    @property
+    def complexity_factor(self) -> float:
+        """ Calculates a factor to estimate the complexity of a Geometry
+
+        0 = very low complexity
+        1 = very high complexity
+
+        ASSUMPTION:
+        The envelope is the bounding box of a geometry. If the geometry's area is similar to the area of it's  bounding
+        box, it is considered as rather simple, since it seems to be a closer shape like a simple box.
+        If the geometry has a very big bounding box, but the geometry's own area is rather small,
+        compared to the one of the bounding box, the complexity can be higher.
+
+        Example:
+            geometry area similar to bounding box --> geometry / bounding_box ~ 1
+            geometry area far smaller than bb     --> geometry / bounding_box ~ 0
+
+        Result is being inverted for better understanding of 'low' and 'high' complexity.
+
+        Returns:
+            complexity_factor (float): The estimated complexity
+        """
+        if self.geom.empty:
+            return 0
+
+        geom_envelope = self.geom.envelope
+        diff = geom_envelope - self.geom
+
+        if diff.area == 0:
+            ratio = 1
+        else:
+            ratio = self.geom.area / diff.area
+
+        complexity_factor = 1 - ratio
+        return complexity_factor
+
 
 class GeometryConflict(UuidModel):
     """

konova/models/object.py

@@ -672,17 +672,6 @@ class GeoReferencedMixin(models.Model):
             result = self.geometry.get_underlying_parcels()
         return result
 
-    def count_underlying_parcels(self):
-        """ Getter for number of underlying parcels
-
-        Returns:
-
-        """
-        result = 0
-        if self.geometry is not None:
-            result = self.geometry.count_underlying_parcels()
-        return result
-
     def set_geometry_conflict_message(self, request: HttpRequest):
         if self.geometry is None:
             return request

konova/models/parcel.py

@@ -160,19 +160,9 @@ class Parcel(UuidModel):
 
 
 class ParcelIntersection(UuidModel):
-    """ ParcelIntersection is an intermediary model, which is used to configure the
+    """
+    ParcelIntersection is an intermediary model, which is used to add extras to the
     M2M relation between Parcel and Geometry.
-
-    Based on uuids, we will not have (practically) any problems on outrunning primary keys
-    and extending the model with calculated_on timestamp, we can 'hide' entries while they
-    are being recalculated and keep track on the last time they have been calculated this
-    way.
-
-    Please note: The calculated_on describes when the relation between the Parcel and the Geometry
-    has been established. The updated_on field of Parcel describes when this Parcel has been
-    changed the last time.
-
     """
     parcel = models.ForeignKey(Parcel, on_delete=models.CASCADE)
     geometry = models.ForeignKey("konova.Geometry", on_delete=models.CASCADE)
-    calculated_on = models.DateTimeField(auto_now_add=True, null=True, blank=True)

konova/settings.py

@@ -46,4 +46,8 @@ DEFAULT_GROUP = "Default"
 ZB_GROUP = "Registration office"
 ETS_GROUP = "Conservation office"
 
+# GEOMETRY
+## Max number of allowed vertices. Geometries larger will be simplified until they reach this threshold
 GEOM_MAX_VERTICES = 10000
+## Max seconds to wait for a parcel calculation result before a new request will be started (default: 30 minutes)
+GEOM_THRESHOLD_RECALCULATION_SECONDS = 60 * 30

konova/static/css/konova.css

@@ -275,4 +275,7 @@ Similar to bootstraps 'shadow-lg'
 }
 .tree-label.badge{
     font-size: 90%;
+}
+.alert{
+    margin-bottom: 0 !important;
 }

konova/tasks.py

@@ -10,15 +10,9 @@ def celery_update_parcels(geometry_id: str, recheck: bool = True):
     from konova.models import Geometry, ParcelIntersection
     try:
         geom = Geometry.objects.get(id=geometry_id)
-        objs = geom.parcelintersection_set.all()
+        geom.parcels.clear()
-        for obj in objs:
-            obj.calculated_on = None
-        ParcelIntersection.objects.bulk_update(
-            objs,
-            ["calculated_on"]
-        )
-
         geom.update_parcels()
+
     except ObjectDoesNotExist:
         if recheck:
             sleep(5)

konova/tests/test_views.py

@@ -146,7 +146,6 @@ class BaseTestCase(TestCase):
         geometry = Geometry.objects.create()
         # Finally create main object, holding the other objects
         intervention = Intervention.objects.create(
-            identifier="TEST",
             title="Test_title",
             responsible=responsibility_data,
             legal=legal_data,
@@ -174,7 +173,6 @@ class BaseTestCase(TestCase):
         geometry = Geometry.objects.create()
         # Finally create main object, holding the other objects
         compensation = Compensation.objects.create(
-            identifier="TEST",
             title="Test_title",
             intervention=interv,
             created=action,
@@ -200,10 +198,8 @@ class BaseTestCase(TestCase):
         responsible_data.handler = handler
         responsible_data.save()
 
-        identifier = EcoAccount().generate_new_identifier()
         # Finally create main object, holding the other objects
         eco_account = EcoAccount.objects.create(
-            identifier=identifier,
             title="Test_title",
             deductable_surface=500,
             legal=lega_data,
@@ -230,7 +226,6 @@ class BaseTestCase(TestCase):
         responsible_data.save()
         # Finally create main object, holding the other objects
         ema = Ema.objects.create(
-            identifier="TEST",
             title="Test_title",
             responsible=responsible_data,
             created=action,
@@ -474,7 +469,7 @@ class BaseTestCase(TestCase):
         eco_account.save()
         return eco_account
 
-    def assert_equal_geometries(self, geom1: MultiPolygon, geom2: MultiPolygon):
+    def assert_equal_geometries(self, geom1: MultiPolygon, geom2: MultiPolygon, tolerance = 0.001):
         """ Assert for geometries to be equal
 
         Transforms the geometries to matching srids before checking
@@ -491,7 +486,6 @@ class BaseTestCase(TestCase):
             self.assertTrue(True)
             return
 
-        tolerance = 0.001
         if geom1.srid != geom2.srid:
             # Due to prior possible transformation of any of these geometries, we need to make sure there exists a
             # transformation from one coordinate system into the other, which is valid

konova/tests/unit/test_forms.py

@@ -152,7 +152,7 @@ class RecordModalFormTestCase(BaseTestCase):
         )
         self.assertEqual(form.form_title, str(_("Record data")))
         self.assertEqual(form.form_caption, str(
-            _("I, {} {}, confirm that all necessary control steps have been performed by myself.").format(
+            _("The necessary control steps have been performed:").format(
             self.user.first_name,
             self.user.last_name
             )

konova/utils/schneider/fetcher.py

@@ -28,7 +28,11 @@ class ParcelFetcher:
         self.geometry = geometry
 
         # Reduce size of geometry to avoid "intersections" because of exact border matching
-        geom = geometry.geom.buffer(-0.001)
+        buffer_threshold = 0.001
+        geom = geometry.geom.buffer(-buffer_threshold)
+        if geom.area < buffer_threshold:
+            # Fallback for malicious geometries which are way too small and would disappear on negative buffering
+            geom = geometry.geom
         self.geojson = geom.ewkt
         self.results = []
 

konova/utils/tables.py

@@ -173,9 +173,13 @@ class TableRenderMixin:
         Returns:
 
         """
+        value_orig = value
         max_length = 75
         if len(value) > max_length:
             value = f"{value[:max_length]}..."
+        value = format_html(
+            f'<div title="{value_orig}">{value}</div>'
+        )
         return value
 
     def render_d(self, value, record: GeoReferencedMixin):

konova/utils/wfs/spatial.py

@@ -1,189 +0,0 @@
-"""
-Author: Michel Peltriaux
-Organization: Struktur- und Genehmigungsdirektion Nord, Rhineland-Palatinate, Germany
-Contact: michel.peltriaux@sgdnord.rlp.de
-Created on: 17.12.21
-
-"""
-import json
-from abc import abstractmethod
-from json import JSONDecodeError
-from time import sleep
-
-import requests
-from django.contrib.gis.db.models.functions import AsGML, MakeValid
-from django.db.models import Func, F
-from requests.auth import HTTPDigestAuth
-
-from konova.settings import PARCEL_WFS_USER, PARCEL_WFS_PW, PROXIES
-
-
-class AbstractWFSFetcher:
-    """ Base class for fetching WFS data
-
-    """
-    # base_url represents not the capabilities url but the parameter-free base url
-    base_url = None
-    version = None
-    auth_user = None
-    auth_pw = None
-    auth_digest_obj = None
-
-    class Meta:
-        abstract = True
-
-    def __init__(self, base_url: str, version: str = "1.1.0", auth_user: str = None, auth_pw: str = None, *args, **kwargs):
-        self.base_url = base_url
-        self.version = version
-        self.auth_pw = auth_pw
-        self.auth_user = auth_user
-
-        self._create_auth_obj()
-
-    def _create_auth_obj(self):
-        if self.auth_pw is not None and self.auth_user is not None:
-            self.auth_digest_obj = HTTPDigestAuth(
-                self.auth_user,
-                self.auth_pw
-            )
-
-    @abstractmethod
-    def get_features(self, feature_identifier: str, filter_str: str):
-        raise NotImplementedError
-
-
-class ParcelWFSFetcher(AbstractWFSFetcher):
-    """ Fetches features from a special parcel WFS
-
-    """
-    geometry_id = None
-    geometry_property_name = None
-    count = 100
-
-    def __init__(self, geometry_id: str, geometry_property_name: str = "msGeometry", *args, **kwargs):
-        super().__init__(
-            version="2.0.0",
-            base_url="https://www.geoportal.rlp.de/registry/wfs/519",
-            auth_user=PARCEL_WFS_USER,
-            auth_pw=PARCEL_WFS_PW,
-            *args,
-            **kwargs
-        )
-        self.geometry_id = geometry_id
-        self.geometry_property_name = geometry_property_name
-
-    def _create_spatial_filter(self,
-                               geometry_operation: str):
-        """ Creates a xml spatial filter according to the WFS filter specification
-
-        The geometry needs to be shrinked by a very small factor (-0.01) before a GML can be created for intersection
-        checking. Otherwise perfect parcel outline placement on top of a neighbouring parcel would result in an
-        intersection hit, despite the fact they do not truly intersect just because their vertices match.
-
-        Args:
-            geometry_operation (str): One of the WFS supported spatial filter operations (according to capabilities)
-
-        Returns:
-            spatial_filter (str): The spatial filter element
-        """
-        from konova.models import Geometry
-
-        geom = Geometry.objects.filter(
-            id=self.geometry_id
-        ).annotate(
-            smaller=Func(F('geom'), -0.001, function="ST_Buffer")  # same as geometry.geom_small_buffered but for QuerySet
-        ).annotate(
-            gml=AsGML(MakeValid('smaller'))
-        ).first()
-        geom_gml = geom.gml
-        spatial_filter = f"<Filter><{geometry_operation}><PropertyName>{self.geometry_property_name}</PropertyName>{geom_gml}</{geometry_operation}></Filter>"
-        return spatial_filter
-
-    def _create_post_data(self,
-                          geometry_operation: str,
-                          typenames: str = None,
-                          start_index: int = 0,
-                          ):
-        """ Creates a POST body content for fetching features
-
-        Args:
-            geometry_operation (str): One of the WFS supported spatial filter operations (according to capabilities)
-
-        Returns:
-            _filter (str): A proper xml WFS filter
-        """
-        start_index = str(start_index)
-        spatial_filter = self._create_spatial_filter(
-            geometry_operation
-        )
-        _filter = f'<wfs:GetFeature service="WFS" version="{self.version}" xmlns:wfs="http://www.opengis.net/wfs/2.0" xmlns:fes="http://www.opengis.net/fes/2.0" xmlns:myns="http://www.someserver.com/myns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/wfs/2.0 http://schemas.opengis.net/wfs/2.0.0/wfs.xsd" count="{self.count}" startindex="{start_index}" outputFormat="application/json; subtype=geojson"><wfs:Query typeNames="{typenames}">{spatial_filter}</wfs:Query></wfs:GetFeature>'
-        return _filter
-
-    def get_features(self,
-                     typenames: str,
-                     spatial_operator: str = "Intersects",
-                     filter_srid: str = None,
-                     start_index: int = 0,
-                     rerun_on_exception: bool = True
-                     ):
-        """ Fetches features from the WFS using POST
-
-        POST is required since GET has a character limit around 4000. Having a larger filter would result in errors,
-        which do not occur in case of POST.
-
-        Args:
-            typenames (str): References to parameter 'typenames' in a WFS GetFeature request
-            spatial_operator (str): Defines the spatial operation for filtering
-            filter_srid (str): Defines the spatial reference system, the geometry shall be transformed into for filtering
-            start_index (str): References to parameter 'startindex' in a
-
-        Returns:
-            features (list): A list of returned features
-        """
-        found_features = []
-        while start_index is not None:
-            post_body = self._create_post_data(
-                spatial_operator,
-                typenames,
-                start_index
-            )
-            response = requests.post(
-                url=self.base_url,
-                data=post_body,
-                auth=self.auth_digest_obj,
-                proxies=PROXIES,
-            )
-
-            content = response.content.decode("utf-8")
-            try:
-                # Check if collection is an exception and does not contain the requested data
-                content = json.loads(content)
-            except JSONDecodeError as e:
-                if rerun_on_exception:
-                    # Wait a second before another try
-                    sleep(1)
-                    self.get_features(
-                        typenames,
-                        spatial_operator,
-                        filter_srid,
-                        start_index,
-                        rerun_on_exception=False
-                    )
-                else:
-                    e.msg += content
-                    raise e
-            fetched_features = content.get(
-                "features",
-                {},
-            )
-
-            found_features += fetched_features
-
-            if len(fetched_features) < self.count:
-                # The response was not 'full', so we got everything to fetch
-                start_index = None
-            else:
-                # If a 'full' response returned, there might be more to fetch. Increase the start_index!
-                start_index += self.count
-
-        return found_features

konova/views/geometry.py

@@ -10,13 +10,16 @@ from django.contrib.gis.geos import MultiPolygon
 from django.http import HttpResponse, HttpRequest
 from django.shortcuts import get_object_or_404
 from django.template.loader import render_to_string
+from django.utils import timezone
 from django.views import View
 
 from konova.models import Geometry
+from konova.settings import GEOM_THRESHOLD_RECALCULATION_SECONDS
 from konova.sub_settings.lanis_settings import DEFAULT_SRID_RLP
+from konova.tasks import celery_update_parcels
 
 
-class GeomParcelsView(LoginRequiredMixin, View):
+class GeomParcelsView(View):
 
     def get(self, request: HttpRequest, id: str):
         """ Getter for HTMX
@@ -30,24 +33,43 @@ class GeomParcelsView(LoginRequiredMixin, View):
         Returns:
             A rendered piece of HTML
         """
-        # HTTP code 286 states that the HTMX should stop polling for updates
-        # https://htmx.org/docs/#polling
-        status_code = 286
         template = "konova/includes/parcels/parcel_table_frame.html"
-        geom = get_object_or_404(Geometry, id=id)
-        parcels = geom.get_underlying_parcels()
-        geos_geom = geom.geom or MultiPolygon(srid=DEFAULT_SRID_RLP)
 
-        geometry_exists = not geos_geom.empty
+        geom = get_object_or_404(Geometry, id=id)
-        parcels_are_currently_calculated = geometry_exists and geos_geom.area > 0 and len(parcels) == 0
+        geos_geom = geom.geom or MultiPolygon(srid=DEFAULT_SRID_RLP)
-        parcels_available = len(parcels) > 0
+        geometry_exists = not geos_geom.empty and geos_geom.area > 0
+        geom_parcel_update_started = geom.parcel_update_start is not None
+        geom_parcel_update_finished = geom.parcel_update_end is not None
+
+        parcels = geom.get_underlying_parcels()
+        parcels_are_available = len(parcels) > 0
+
+        waiting_too_long = self._check_waiting_too_long(geom)
+
+        if geometry_exists and not parcels_are_available and waiting_too_long:
+            # Trigger calculation again - process may have failed silently
+            celery_update_parcels.delay(geom.id)
+            parcels_are_currently_calculated = True
+        else:
+            parcels_are_currently_calculated = (
+                    geometry_exists and
+                    not parcels_are_available and
+                    geom_parcel_update_started and
+                    not geom_parcel_update_finished
+            )
 
         if parcels_are_currently_calculated:
             # Parcels are being calculated right now. Change the status code, so polling stays active for fetching
-            # resutls after the calculation
+            # results after the calculation
             status_code = 200
+        else:
+            # HTTP code 286 states that the HTMX should stop polling for updates
+            # https://htmx.org/docs/#polling
+            status_code = 286
 
-        if parcels_available or not geometry_exists:
+        if parcels_are_available or not geometry_exists:
+            # Default case: Parcels are calculated or there is no geometry at all
+            # (so there will be no parcels to expect)
             municipals = geom.get_underlying_municipals(parcels)
 
             rpp = 100
@@ -69,8 +91,25 @@ class GeomParcelsView(LoginRequiredMixin, View):
         else:
             return HttpResponse(None, status=404)
 
+    def _check_waiting_too_long(self, geom: Geometry):
+        """ Check whether the client is waiting too long for a parcel calculation result
 
-class GeomParcelsContentView(LoginRequiredMixin, View):
+        Depending on the geometry's modified attribute
+
+        """
+        # Scale time to wait longer with increasing geometry complexity
+        complexity_factor = geom.complexity_factor + 1
+        wait_for_seconds = int(GEOM_THRESHOLD_RECALCULATION_SECONDS * complexity_factor)
+        try:
+            pcs_diff = (timezone.now() - geom.parcel_update_start).seconds
+        except TypeError:
+            pcs_diff = wait_for_seconds
+
+        waiting_too_long = (pcs_diff >= wait_for_seconds)
+        return waiting_too_long
+
+
+class GeomParcelsContentView(View):
 
     def get(self, request: HttpRequest, id: str, page: int):
         """ Getter for infinite scroll of HTMX

konova/views/map_proxy.py

@@ -93,14 +93,23 @@ class ClientProxyParcelWFS(BaseClientProxyView):
         auth = HTTPDigestAuth(CLIENT_PROXY_AUTH_USER, CLIENT_PROXY_AUTH_PASSWORD)
 
         content, response_code = self.perform_url_call(url, auth=auth)
-        body = json.loads(content)
+        error_detected = response_code != 200
+        error_code = f"response code:{response_code}"
+        try:
+            body = json.loads(content)
+        except JSONDecodeError:
+            body = {}
+            error_code = "json invalid"
+            error_detected = True
+
         body["crs"] = {
             "type": "name",
             "properties": {
-                "name": "urn:ogc:def:crs:EPSG::25832"
+                "name": "urn:ogc:def:crs:EPSG::25832",
             }
         }
-        if response_code != 200:
+        if error_detected:
+            body["crs"]["properties"]["msg"] = f"Error detected ({error_code})"
             return JsonResponse({
                 "status_code": response_code,
                 "content": body,

news/admin.py

@@ -17,6 +17,9 @@ class ServerMessageAdmin(admin.ModelAdmin):
     search_fields = [
         "subject"
     ]
+    ordering = [
+        "-publish_on"
+    ]
 
     def save_model(self, request, obj, form, change):
         obj.save(user=request.user)

requirements.txt

@@ -1,58 +1,58 @@
 amqp==5.2.0
-asgiref==3.7.2
+asgiref==3.8.1
 async-timeout==4.0.3
-beautifulsoup4==4.12.2
+beautifulsoup4==4.13.0b2
 billiard==4.2.0
 cached-property==1.5.2
-celery==5.3.6
+celery==5.4.0rc2
-certifi==2023.11.17
+certifi==2024.2.2
 chardet==5.2.0
 charset-normalizer==3.3.2
 click==8.1.7
-click-didyoumean==0.3.0
+click-didyoumean==0.3.1
 click-plugins==1.1.1
 click-repl==0.3.0
-coverage==7.3.3
+coverage==7.4.4
 Deprecated==1.2.14
-Django==5.0.1
+Django==5.0.4
-django-autocomplete-light==3.10.0rc4
+django-autocomplete-light==3.11.0
 django-bootstrap-modal-forms==3.0.4
-django-bootstrap4==23.2
+django-bootstrap4==24.1
-django-debug-toolbar==4.2.0
+django-debug-toolbar==4.3.0
-django-filter==23.5
+django-environ==0.11.2
+django-filter==24.2
 django-fontawesome-5==1.0.18
 django-simple-sso==1.2.0
 django-tables2==2.7.0
 et-xmlfile==1.1.0
-idna==3.6
+idna==3.7
-importlib-metadata==7.0.0
+importlib_metadata==7.1.0
-itsdangerous==0.24
+itsdangerous==2.1.2
-kombu==5.3.4
+kombu==5.3.7
 openpyxl==3.2.0b1
-packaging==23.2
+packaging==24.0
 pika==1.3.2
 prompt-toolkit==3.0.43
-psycopg==3.1.16
+psycopg==3.1.18
-psycopg-binary==3.1.16
+psycopg-binary==3.1.18
-psycopg2-binary==2.9.9
+pyparsing==3.1.2
-pyparsing==3.1.1
 pypng==0.20220715.0
 pyproj==3.6.1
-python-dateutil==2.8.2
+python-dateutil==2.9.0.post0
-pytz==2023.3.post1
+pytz==2024.1
 PyYAML==6.0.1
-qrcode==7.4.2
+qrcode==7.3.1
-redis==5.1.0a1
+redis==5.1.0b4
 requests==2.31.0
 six==1.16.0
 soupsieve==2.5
 sqlparse==0.4.4
-typing_extensions==4.9.0
+typing_extensions==4.11.0
-tzdata==2023.3
+tzdata==2024.1
-urllib3==2.1.0
+urllib3==2.2.1
 vine==5.1.0
-wcwidth==0.2.12
+wcwidth==0.2.13
 webservices==0.7
 wrapt==1.16.0
 xmltodict==0.13.0
-zipp==3.17.0
+zipp==3.18.1

templates/404.html

@@ -8,6 +8,7 @@
         <hr>
         <p class="lead">
             {% trans 'The requested data does not exist.' %}
+            {% trans 'Make sure the URL is valid (no whitespaces, ...).' %}
         </p>
     </div>
 {% endblock %}

templates/base.html

@@ -27,7 +27,18 @@
     <div class="col">
         {% for message in messages %}
         <div class="row alert alert-{{ message.tags }}">
-            {{ message }}
+            <div>
+                <span class="mr-3">
+                {% if "danger" in message.tags %}
+                    {% fa5_icon 'exclamation' %}
+                {% elif "info" in message.tags %}
+                    {% fa5_icon 'info' %}
+                {% elif "success" in message.tags %}
+                    {% fa5_icon 'check' %}
+                {% endif %}
+                </span>
+                {{ message }}
+            </div>
         </div>
         {% endfor %}
     </div>

templates/navbars/navbar.html

@@ -53,6 +53,9 @@
                     {{ user.username }}
                 </div>
                 <div class="dropdown-menu dropdown-menu-right">
+                    {% if user.is_staff or user.is_superuser %}
+                    <a class="dropdown-item" target="_blank" href="{% url 'admin:index' %}">{% fa5_icon 'tools' %}  {% trans 'Admin' %}</a>
+                    {% endif %}
                     <a class="dropdown-item" href="{% url 'user:index' %}">{% fa5_icon 'cogs' %}  {% trans 'Settings' %}</a>
                     <a class="dropdown-item" href="{% url 'logout' %}">{% fa5_icon 'sign-out-alt' %}  {% trans 'Logout' %}</a>
                 </div>

templates/public_base.html

@@ -23,13 +23,22 @@
         {% endblock %}
     </header>
     <div class="container-fluid mt-3 px-5">
-        <div class="">
         {% for message in messages %}
-            <div class="row alert alert-{{ message.tags }}">
+        <div class="row alert alert-{{ message.tags }}">
+            <div>
+                <span class="mr-3">
+                {% if "danger" in message.tags %}
+                    {% fa5_icon 'exclamation' %}
+                {% elif "info" in message.tags %}
+                    {% fa5_icon 'info' %}
+                {% elif "success" in message.tags %}
+                    {% fa5_icon 'check' %}
+                {% endif %}
+                </span>
                 {{ message }}
             </div>
-        {% endfor %}
         </div>
+        {% endfor %}
 
         {% block body %}