API non existing values #208

New Issue

mpeltriaux · 2022-09-28T09:34:10+02:00

mpeltriaux commented

2022-09-28 09:34:10 +02:00

Status quo

If a KonovaCode is used, which does not exist, the Response looks like this:

{
    "errors": [
        "KonovaCode matching query does not exist."
    ]
}

Enhancement

It would be better if the unresolved atomId would be returned as well, like:

{
    "errors": [
        "KonovaCode matching query does not exist: 12345"
    ]
}

# Status quo If a KonovaCode is used, which does not exist, the Response looks like this: ```json { "errors": [ "KonovaCode matching query does not exist." ] } ``` # Enhancement It would be better if the unresolved atomId would be returned as well, like: ```json { "errors": [ "KonovaCode matching query does not exist: 12345" ] } ```

mpeltriaux added the

enhancement

label 2022-09-28 09:34:10 +02:00

mpeltriaux self-assigned this 2022-09-28 09:34:10 +02:00

mpeltriaux commented

2022-09-29 10:41:22 +02:00

Proper response

The proper response has been implemented and will display the wrong atomId as well as the list identifier to clarify which list has been used as lookup:

{
    "errors": [
        "KonovaCode matching query does not exist. (7101318 not found in official list 907)"
    ]
}

Merged in #212

# Proper response The proper response has been implemented and will display the wrong atomId as well as the list identifier to clarify which list has been used as lookup: ```json { "errors": [ "KonovaCode matching query does not exist. (7101318 not found in official list 907)" ] } ``` # Merged in #212

mpeltriaux referenced this issue from a commit

2022-09-29 10:45:27 +02:00

#208 API non existing atomID

mpeltriaux referenced this issue

2022-09-29 10:45:41 +02:00

#208 API non existing atomID #212

mpeltriaux referenced this issue from a commit

2022-09-29 10:45:45 +02:00

Merge pull request '#208 API non existing atomID' (#212) from 208_API_non_existing_values into master

mpeltriaux closed this issue

2022-09-29 10:46:10 +02:00

btuelek referenced this issue from a commit