IT-Naturschutz/konova
7
0
Fork 0
Code Issues 6 Pull Requests 1 Actions Projects Releases 37 Wiki Activity

Drop deductions of deleted intervention #322

New Issue
Closed
opened 2023-03-30 14:56:49 +02:00 by mpeltriaux · 1 comment
mpeltriaux commented 2023-03-30 14:56:49 +02:00
Owner
Copy Link

Status quo

If an intervention is marked as deleted and therefore hidden for the user, its deductions are still substracted from the related ecoaccount's rest surface.

Solution

At the very moment an intervention is being deleted, it's deductions should be dropped completely from the database. In the end, the recalculation of the ecoaccount's deductable_rest should be performed.

Could we not simply keep the 'removed' deductions and recalculate without them?

No - if the deleted intervention would be recovered, the recalculation of deductable_rest should be run again. At this moment, the ecoaccount balance could suddenly overflow into a negative area, since it already might be at 0 for deductable_rest.

If a once deleted intervention should be recovered, the old deductions should be gone to avoid conflicts with newer deductions from the account.

# Status quo If an intervention is marked as deleted and therefore hidden for the user, its deductions are still substracted from the related ecoaccount's rest surface. # Solution At the very moment an intervention is being deleted, it's deductions should be dropped completely from the database. In the end, the recalculation of the ecoaccount's `deductable_rest` should be performed. #### Could we not simply keep the 'removed' deductions and recalculate without them? No - if the deleted intervention would be recovered, the recalculation of `deductable_rest` should be run again. At this moment, the ecoaccount balance could suddenly overflow into a negative area, since it already might be at 0 for `deductable_rest`. If a once deleted intervention should be recovered, the old deductions should be gone to avoid conflicts with newer deductions from the account.
mpeltriaux added the
bug
enhancement
 labels 2023-03-30 14:56:49 +02:00
mpeltriaux self-assigned this 2023-03-30 14:56:49 +02:00
mpeltriaux commented 2023-03-30 15:13:45 +02:00
Author
Owner
Copy Link

Merged in #323

# Merged in #323
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
backlog
Absolutely no priority, but maybe some day...
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
Idea for existing feature
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
in discussion
invalid
Something is wrong
MAUS - Pacht
Issues für Maus-Pacht / Version processware
priority
1
priority
2
priority
3
priority
4
priority
5
question
More information is needed
wontfix
This won't be fixed
No Label
bug
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
btuelek jhaeder mmannfeld mmueller mpeltriaux sgorell srieder tnette
No Assignees mpeltriaux
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: IT-Naturschutz/konova#322
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?