IT-Naturschutz/konova
7
1
Fork 0
Code Issues 6 Pull Requests 1 Actions Projects Releases 28 Wiki Activity

Refactoring #43

Merged
mpeltriaux merged 13 commits from Refactoring into master 2021-11-16 14:24:11 +01:00
Conversation 0 Commits 13 Files Changed 46 +1558 -1268
mpeltriaux commented 2021-11-16 14:24:04 +01:00
Owner
Copy Link

Restructures parts of the code for better future maintability, e.g.

  • splits large modules into smaller modules, wrapped in a packages, such as models.py -> models/modelA, modelB, modelC, ...
  • introduces more OO logic by moving add-related-elements logic into the model classes directly instead of processing e.g. in forms
Restructures parts of the code for better future maintability, e.g. * splits large modules into smaller modules, wrapped in a packages, such as models.py -> models/modelA, modelB, modelC, ... * introduces more OO logic by moving add-related-elements logic into the model classes directly instead of processing e.g. in forms
mpeltriaux added 13 commits 2021-11-16 14:24:05 +01:00 
* renames model ResponsibilityData into Responsibility
* renames model LegalData into Legal
* moves form->object saving logic into model
* refactors NewDocumentForm into special types for intervention, compensation, eco account and ema
*
* splits intervention/models.py into subpackage
* splits ema/models.py into subpackage
* splits konova/models.py into subpackage
* splits user/models.py into subpackage
* splits compensation/models.py into subpackage
* renames base objects by adding suffix Mixin
* create package from compensation/views
* create package from compensation/urls
* renames modules inside of compensation/urls and compensation/views
* drop SSO message sending for now from the logic
* moves adding of revocation into Intervention model
* moves adding of deduction into Intervention and EcoAccount model
* hardens against circular import issues
* moves updating of shared access users into Intervention
* moves updating of shared access users into ShareableObjectMixin
* renames ShareInterventionModalForm to ShareModalForm since it's used for EMA and eco accounts as well
* adds simple getter methods for UserActionLogEntry
* replaces manual creation of UserActionLogEntry with new methods
* moves add_state from compensation to AbstractCompensation
mpeltriaux merged commit 3db2a156bb into master 2021-11-16 14:24:11 +01:00
mpeltriaux deleted branch Refactoring 2021-11-16 14:24:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog

Absolutely no priority, but maybe some day...

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

Idea for existing feature

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
in discussion

   
invalid

Something is wrong

  
priority
1

  
priority
2

  
priority
3

  
priority
4

  
priority
5

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
backlog
bug
duplicate
enhancement
feature
help wanted
invalid
question
wontfix
bug
duplicate
enhancement
help wanted
in discussion
invalid
priority
1
priority
2
priority
3
priority
4
priority
5
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: IT-Naturschutz/konova#43
No description provided.
Delete Branch "Refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?