[Compensation] Conservation office #5

New Issue

mpeltriaux · 2021-08-26T12:54:24+02:00

mpeltriaux commented

2021-08-26 12:54:24 +02:00

Status quo

The compensation holds a conservation office inside responsible attribute.

Enhancement

Compensations inherit information about responsibilities from their related intervention's responsible attribute. Therefore, consider dropping the whole responsible attribute for Compensation model.

# Status quo The compensation holds a conservation office inside `responsible` attribute. # Enhancement Compensations inherit information about responsibilities from their related intervention's `responsible` attribute. Therefore, consider dropping the whole `responsible` attribute for `Compensation` model.

mpeltriaux added the

enhancement

label 2021-08-26 12:54:24 +02:00

mpeltriaux self-assigned this 2021-08-26 12:54:24 +02:00

mpeltriaux referenced this issue from a commit

2021-08-27 09:44:26 +02:00

[Compensation] Conservation office #5

mpeltriaux referenced this issue from a commit

2021-08-27 15:16:14 +02:00

[Compensation] Conservation office #5

mpeltriaux commented

2021-08-30 09:45:53 +02:00

responsible has not been dropped. responsible ist part of the AbstractCompensation which is the super class for Compensation and EcoAccount. EcoAccounts need the responsible attribute anyway, since they are not linked to any intervention directly. Refactoring responsible from AbstractCompensation into EcoAccount might backfire in the future, when laws can change and compensations would need the responsible attribute again.

We keep it where it is but do not use it for compensations (for now).
Instead, this branch holds a lot of enhancements regarding the KonovaCodes and their usage in the admin backend.

`responsible` has not been dropped. `responsible` ist part of the `AbstractCompensation` which is the super class for `Compensation` and `EcoAccount`. EcoAccounts need the `responsible` attribute anyway, since they are not linked to any intervention directly. Refactoring `responsible` from `AbstractCompensation` into `EcoAccount` might backfire in the future, when laws can change and compensations would need the `responsible` attribute again. We keep it where it is but do not use it for compensations (for now). Instead, this branch holds a lot of enhancements regarding the KonovaCodes and their usage in the admin backend.

mpeltriaux referenced this issue

2021-08-30 09:46:15 +02:00

5_compensation_conservation_office #15

mpeltriaux commented

2021-08-30 09:46:28 +02:00