is_ajax deprecated #73

New Issue

mpeltriaux · 2022-01-19T09:46:35+01:00

mpeltriaux commented

2022-01-19 09:46:35 +01:00

Status quo

Just found out the is_ajax() method, being used in this codebase to recognize an ajax call, has been deprecated due to it's JQuery specific style.

The discussion can be found here:
https://code.djangoproject.com/ticket/30997

Solution

Write own is_ajax() method which performs the http header checking as stated, e.g. here: https://stackoverflow.com/questions/63629935/django-3-1-and-is-ajax

# Status quo Just found out the `is_ajax()` method, being used in this codebase to recognize an ajax call, has been deprecated due to it's JQuery specific style. The discussion can be found here: https://code.djangoproject.com/ticket/30997 # Solution Write own `is_ajax()` method which performs the http header checking as stated, e.g. here: https://stackoverflow.com/questions/63629935/django-3-1-and-is-ajax

mpeltriaux added the

enhancement

label 2022-01-19 09:46:35 +01:00

mpeltriaux self-assigned this 2022-01-19 09:46:35 +01:00

mpeltriaux commented

2022-01-20 10:10:43 +01:00

Update

The is_ajax() method used in django-bootstrap-modal is not the same which is provided by django itself and has been deprecated.

The one we use is this one:
dddf22e78a/bootstrap_modal_forms/utils.py (L1)

So there is nothing to do in here. This issue will be closed now.

# Update The `is_ajax()` method used in `django-bootstrap-modal` is not the same which is provided by django itself and has been deprecated. The one we use is this one: https://github.com/trco/django-bootstrap-modal-forms/blob/dddf22e78aead693fedcabe94961fb1ddebc6db7/bootstrap_modal_forms/utils.py#L1 So there is nothing to do in here. This issue will be closed now.

mpeltriaux closed this issue

2022-01-20 10:10:43 +01:00

Sign in to join this conversation.