IT-Naturschutz
/
konova
7
1
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases 21 Wiki Activity

Labels Milestones

Refactoring #43

Merged
mpeltriaux merged 13 commits from Refactoring into master 3 years ago
Conversation 0 Commits 13 Files Changed 46
mpeltriaux commented 3 years ago
Owner

Restructures parts of the code for better future maintability, e.g.

  • splits large modules into smaller modules, wrapped in a packages, such as models.py -> models/modelA, modelB, modelC, ...
  • introduces more OO logic by moving add-related-elements logic into the model classes directly instead of processing e.g. in forms
Restructures parts of the code for better future maintability, e.g. * splits large modules into smaller modules, wrapped in a packages, such as models.py -> models/modelA, modelB, modelC, ... * introduces more OO logic by moving add-related-elements logic into the model classes directly instead of processing e.g. in forms
mpeltriaux added 13 commits 3 years ago
bcffae4a95 Refactoring 
* renames model ResponsibilityData into Responsibility
* renames model LegalData into Legal
* moves form->object saving logic into model
* refactors NewDocumentForm into special types for intervention, compensation, eco account and ema
*
d78afbfb5c Refactoring 
* splits intervention/models.py into subpackage
6f107ac7a1 Refactoring 
* splits ema/models.py into subpackage
* splits konova/models.py into subpackage
* splits user/models.py into subpackage
78945d648f Refactoring 
* splits compensation/models.py into subpackage
* renames base objects by adding suffix Mixin
899bd28247 Refactoring 
* create package from compensation/views
fd8ce4b2ec Refactoring 
* create package from compensation/urls
* renames modules inside of compensation/urls and compensation/views
60a50b304a Refactoring 
* drop SSO message sending for now from the logic
9b531bc09e Refactoring 
* moves adding of revocation into Intervention model
d8f0db6bd6 Refactoring 
* moves adding of deduction into Intervention and EcoAccount model
* hardens against circular import issues
6ad387daa3 Refactoring 
* moves updating of shared access users into Intervention
71e4aa9a2f Refactoring 
* moves updating of shared access users into ShareableObjectMixin
* renames ShareInterventionModalForm to ShareModalForm since it's used for EMA and eco accounts as well
779065ec91 Refactoring 
* adds simple getter methods for UserActionLogEntry
* replaces manual creation of UserActionLogEntry with new methods
8e1c4446dd Refactoring 
* moves add_state from compensation to AbstractCompensation
mpeltriaux merged commit 3db2a156bb into master 3 years ago
mpeltriaux deleted branch Refactoring 3 years ago
The pull request has been merged as 3db2a156bb.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
backlog

Absolutely no priority, but maybe some day...   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

Idea for existing feature   
feature

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
  
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
in discussion
   
invalid

Something is wrong
  
priority
1
   
priority
2
   
priority
3
   
priority
4
   
priority
5
  
question

More information is needed   
wontfix

This won't be fixed
No Label
backlog
bug
duplicate
enhancement
feature
help wanted
invalid
question
wontfix
bug
duplicate
enhancement
help wanted
in discussion
invalid
priority
1
priority
2
priority
3
priority
4
priority
5
question
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: IT-Naturschutz/konova#43
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Refactoring'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes