IT-Naturschutz/konova
7
0
Fork 0
Code Issues 6 Pull Requests 1 Actions Projects Releases 37 Wiki Activity

WIP: 490_View_refactoring #491

Draft
mpeltriaux wants to merge 36 commits from 490_View_refactoring into master
pull from: 490_View_refactoring
merge into: IT-Naturschutz:master
Conversation 0 Commits 36 Files Changed 102 +3 -2
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fe2ac3d97d - Show all commits

2
konova/tests/test_views.py
View File

@ -543,7 +543,7 @@ class BaseViewTestCase(BaseTestCase):
for url, redirect_to in urls.items(): for url, redirect_to in urls.items():
response = client.get(url, follow=True) response = client.get(url, follow=True)
# Expect redirects to the landing page # Expect redirects to the landing page
self.assertEqual(response.redirect_chain[0], (redirect_to, 302), msg=f"Failed for {url}") self.assertEqual(response.redirect_chain[0], (redirect_to, 302), msg=f"Failed for {url}. Expected {redirect_to}")
def assert_url_fail(self, client: Client, urls: list): def assert_url_fail(self, client: Client, urls: list):
""" Assert for all given urls a direct 302 response """ Assert for all given urls a direct 302 response

3
konova/views/share.py
View File

@ -61,7 +61,8 @@ class AbstractShareByTokenView(LoginRequiredMixin, BaseView):
return redirect("home") return redirect("home")
def _user_has_permission(self, user): def _user_has_permission(self, user):
return user.is_default_user() # No permissions are needed to get shared access via token
return True
def _user_has_shared_access(self, user, **kwargs): def _user_has_shared_access(self, user, **kwargs):
# The user does not need to have shared access to call the endpoint which gives them shared access # The user does not need to have shared access to call the endpoint which gives them shared access