IT-Naturschutz/konova
7
0
Fork 0
Code Issues 6 Pull Requests Actions Projects Releases 44 Wiki Activity

WIP: 490_View_refactoring #491

Closed
mpeltriaux wants to merge 77 commits from 490_View_refactoring into master
pull from: 490_View_refactoring
merge into: IT-Naturschutz:master
Conversation 1 Commits 77 Files Changed 111 +2988 -3576
mpeltriaux commented 2025-10-20 13:41:26 +02:00
Owner
Copy Link

Implements #490

Implements #490
mpeltriaux added 18 commits 2025-10-20 13:41:27 +02:00 
* introduces BaseIndexView class
* refactors index view for interventions
* refactors index view for compensations
* refactors index view for eco account
* refactors index view for ema
* introduces BaseNewIdentifierGeneratorView class
* refactors new identifier generator view for ema
* refactors identifier generator view for interventions
* simplifies same view for ema
* refactors identifier generator view for compensation
* refactors identifier generator view for ecoaccount
* simplifies base identifier generator view even further
* refactors majority of user views into class based views
* introduces BaseModalFormView and BaseView for even more generic usage
* renames url identifier user:index into user:detail for more clarity
* refactors deduction views on interventions and eco accounts from function to class based
* introduces basic checks on shared access and permission on BaseView on dispatching --> checks shall be overwritten on inheriting classes
* refactors function based report views into class based for EIV, OEK, EMA, KOM
* introduces BaseReportView for proper inheritance of shared logic
* refactors generating of qr codes into proper class
* refactors login required from method decorator to mixin inheritance
* introduces BaseDetailView
* refactors detail views for EIV, KOM, OEK, EMA from function based to class based
* refactors already class based HomeView to inherit from new BaseView
* introduces BaseFormView and BaseNewSpatialLocatedObjectFormView
* refactors new intervention view from function to class
* refactors edit intervention view from function to class
* refactors views for new ema and edit ema from function to class based
* moves shared access check to base edit form view to be checked for every inheriting class
* fixes bug where private variables changed on singleton objects
* updates translations
* refactors new and edit compensation views from function to class based
* adds checked property to compensation to return parent-intervention's checked info
* fixes bug where compensation could be added to recorded intervention
* updates translations
* refactors new and edit eco account views from function to class based
* removes info message if checked intervention is altered and loses the current checked state
* updates comments/documentation
* removes code duplicates
* fixes display error where modal form was hidden behind menu bar of map client
* fixes bug where compensation could not be created directly from intervention
mpeltriaux added 2 commits 2025-10-20 16:14:03 +02:00 
* fixes bug where a form error would trigger a wrong error warning
* extends BaseModalFormView to hold general logic for processing GET and POST requests for BaseModalForm endpoints
* refactors uuid check to use a specific parameter instead of kwargs
* fixes css bug where modal form input elements would not be visible
* refactors check view for intervention from function to class
* refactors DeductionViews to inherit from extended BaseModalFormView
mpeltriaux added 1 commit 2025-10-20 16:32:15 +02:00 
* refactors AbstractRecordModalForm
* refactors recording view for ema, intervention and eco account
mpeltriaux added 3 commits 2025-10-21 09:25:01 +02:00 
* refactors AbstractCompensationActionViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for compensation actions
* moves message template strings into message_templates.py
* refactors AbstractDeadlineViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for deadline views
* refactors tests for deadline views to check whether they work properly
mpeltriaux added 3 commits 2025-10-21 14:56:31 +02:00 
* refactors new, edit, get and delete views for eiv, kom, oek and ema
* introduces
* refactors parcel view to inherit from BaseView
* refactors log views to inherit from BaseView
mpeltriaux added 1 commit 2025-10-21 17:03:17 +02:00 
* refactors resubmission view for eiv, kom, oek, ema
* removes unused attributes on BaseModalFormView
mpeltriaux added 4 commits 2025-10-21 21:05:50 +02:00 
* refactors share views for eiv, oek, ema (kom does not have any)
* fixes bug for sharing via token where permission was too tight
* refactors remove view for kom, eiv, oek and ema
* introduces BaseRemoveModalFormView
* moves html blocking logic from BaseModalForm into BaseModalFormView
* refactors compensation state views for kom, ema, oek
* updates tests
* refactors before-after state toggling into initialization of NewCompensationStateModalForm
mpeltriaux added 1 commit 2025-11-04 08:58:52 +01:00 
* refactors views for adding, editing and removing revocations
* refactors view for getting the document of a revocation
* updates tests
mpeltriaux added 2 commits 2025-11-05 10:12:55 +01:00 
* refactors views for adding, editing and removing payments
* refactors team views
* split views.py into users.py and teams.py in users app
* refactors method headers for _user_has_permission()
* adds method and class comments and documentation to base view classes
mpeltriaux added 1 commit 2025-11-05 10:37:34 +01:00 
* refactors API Token view
* updates tests
mpeltriaux added 1 commit 2025-11-08 13:05:21 +01:00 
* refactors removing compensation from intervention view
* drops unused view on api app
mpeltriaux added 38 commits 2025-11-28 11:59:09 +01:00 
* introduces BaseIndexView class
* refactors index view for interventions
* refactors index view for compensations
* refactors index view for eco account
* refactors index view for ema
* introduces BaseNewIdentifierGeneratorView class
* refactors new identifier generator view for ema
* refactors identifier generator view for interventions
* simplifies same view for ema
* refactors identifier generator view for compensation
* refactors identifier generator view for ecoaccount
* simplifies base identifier generator view even further
* refactors majority of user views into class based views
* introduces BaseModalFormView and BaseView for even more generic usage
* renames url identifier user:index into user:detail for more clarity
* refactors deduction views on interventions and eco accounts from function to class based
* introduces basic checks on shared access and permission on BaseView on dispatching --> checks shall be overwritten on inheriting classes
* refactors function based report views into class based for EIV, OEK, EMA, KOM
* introduces BaseReportView for proper inheritance of shared logic
* refactors generating of qr codes into proper class
* refactors login required from method decorator to mixin inheritance
* introduces BaseDetailView
* refactors detail views for EIV, KOM, OEK, EMA from function based to class based
* refactors already class based HomeView to inherit from new BaseView
* introduces BaseFormView and BaseNewSpatialLocatedObjectFormView
* refactors new intervention view from function to class
* refactors edit intervention view from function to class
* refactors views for new ema and edit ema from function to class based
* moves shared access check to base edit form view to be checked for every inheriting class
* fixes bug where private variables changed on singleton objects
* updates translations
* refactors new and edit compensation views from function to class based
* adds checked property to compensation to return parent-intervention's checked info
* fixes bug where compensation could be added to recorded intervention
* updates translations
* refactors new and edit eco account views from function to class based
* removes info message if checked intervention is altered and loses the current checked state
* updates comments/documentation
* removes code duplicates
* fixes display error where modal form was hidden behind menu bar of map client
* fixes bug where compensation could not be created directly from intervention
* fixes bug where a form error would trigger a wrong error warning
* extends BaseModalFormView to hold general logic for processing GET and POST requests for BaseModalForm endpoints
* refactors uuid check to use a specific parameter instead of kwargs
* fixes css bug where modal form input elements would not be visible
* refactors check view for intervention from function to class
* refactors DeductionViews to inherit from extended BaseModalFormView
* refactors AbstractRecordModalForm
* refactors recording view for ema, intervention and eco account
* refactors AbstractCompensationActionViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for compensation actions
* moves message template strings into message_templates.py
* refactors AbstractDeadlineViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for deadline views
* refactors tests for deadline views to check whether they work properly
* refactors new, edit, get and delete views for eiv, kom, oek and ema
* introduces
* refactors parcel view to inherit from BaseView
* refactors log views to inherit from BaseView
* refactors resubmission view for eiv, kom, oek, ema
* removes unused attributes on BaseModalFormView
* refactors share views for eiv, oek, ema (kom does not have any)
* fixes bug for sharing via token where permission was too tight
* refactors remove view for kom, eiv, oek and ema
* introduces BaseRemoveModalFormView
* moves html blocking logic from BaseModalForm into BaseModalFormView
* refactors compensation state views for kom, ema, oek
* updates tests
* refactors before-after state toggling into initialization of NewCompensationStateModalForm
* refactors views for adding, editing and removing revocations
* refactors view for getting the document of a revocation
* updates tests
* refactors views for adding, editing and removing payments
* refactors team views
* split views.py into users.py and teams.py in users app
* refactors method headers for _user_has_permission()
* adds method and class comments and documentation to base view classes
* refactors API Token view
* updates tests
* refactors removing compensation from intervention view
* drops unused view on api app
# Conflicts:
#	konova/static/css/konova.css
mpeltriaux added 1 commit 2025-12-12 14:13:31 +01:00 
* renames certain classes to match their content
* splits larger files into smaller ones
mpeltriaux added 1 commit 2025-12-12 14:14:46 +01:00
mpeltriaux commented 2025-12-17 14:07:45 +01:00
Author
Owner
Copy Link

Refactoring has gone too far. Certain generalizations on the code base created complexity instead of reducing it. There will be another pull request with a far lower complexity in a while.

Refactoring has gone too far. Certain generalizations on the code base created complexity instead of reducing it. There will be another pull request with a far lower complexity in a while.
mpeltriaux closed this pull request 2025-12-17 14:07:45 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backlog
Absolutely no priority, but maybe some day...
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
Idea for existing feature
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
in discussion
invalid
Something is wrong
MAUS - Pacht
Issues für Maus-Pacht / Version processware
priority
1
priority
2
priority
3
priority
4
priority
5
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
btuelek jhaeder mmannfeld mmueller mpeltriaux sgorell srieder tnette
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: IT-Naturschutz/konova#491
No description provided.
Delete Branch "490_View_refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?