WIP: 490_View_refactoring #491

2025-10-20T13:41:26+02:00

mpeltriaux commented

2025-10-20 13:41:26 +02:00

Implements #490

mpeltriaux added 18 commits 2025-10-20 13:41:27 +02:00

# Index Intervention refactoring 1ceffccd40

* introduces BaseIndexView class
* refactors index view for interventions

# Index Compensation refactoring 21bb988d86

* refactors index view for compensations

# Index EcoAccount refactoring 67acddf701

* refactors index view for eco account

# Index Ema refactoring bb71c0fcc8

* refactors index view for ema

# NewId Generator Ema refactoring a44d8658d4

* introduces BaseNewIdentifierGeneratorView class
* refactors new identifier generator view for ema

# Identifier Generator View refactoring c597e1934b

* refactors identifier generator view for interventions
* simplifies same view for ema

# Identifier Generator View Compensation refactoring 80e8925a63

* refactors identifier generator view for compensation

# Identifier Generator View EcoAccount refactoring be9f6f1b7e

* refactors identifier generator view for ecoaccount
* simplifies base identifier generator view even further

# User view refactoring afbdf221c3

* refactors majority of user views into class based views
* introduces BaseModalFormView and BaseView for even more generic usage
* renames url identifier user:index into user:detail for more clarity

# Deduction views 242730435e

* refactors deduction views on interventions and eco accounts from function to class based
* introduces basic checks on shared access and permission on BaseView on dispatching --> checks shall be overwritten on inheriting classes

# Report view refactoring f2baa054bf

* refactors function based report views into class based for EIV, OEK, EMA, KOM
* introduces BaseReportView for proper inheritance of shared logic
* refactors generating of qr codes into proper class

# ClientProxyView 61ec9c8c9b

* refactors login required from method decorator to mixin inheritance

# Detail View a9b402862b

* introduces BaseDetailView
* refactors detail views for EIV, KOM, OEK, EMA from function based to class based
* refactors already class based HomeView to inherit from new BaseView

# NewIntervention view d03b714fb5

* introduces BaseFormView and BaseNewSpatialLocatedObjectFormView
* refactors new intervention view from function to class

# EditIntervention view 9e4a78ec60

* refactors edit intervention view from function to class

# NewEma EditEma views 278a951e92

* refactors views for new ema and edit ema from function to class based
* moves shared access check to base edit form view to be checked for every inheriting class
* fixes bug where private variables changed on singleton objects
* updates translations

# NewCompensation EditCompensation view 73178b3fd2

* refactors new and edit compensation views from function to class based
* adds checked property to compensation to return parent-intervention's checked info
* fixes bug where compensation could be added to recorded intervention
* updates translations

# NewEcoAccount EditEcoAccount view a86d86b731

* refactors new and edit eco account views from function to class based
* removes info message if checked intervention is altered and loses the current checked state
* updates comments/documentation
* removes code duplicates
* fixes display error where modal form was hidden behind menu bar of map client
* fixes bug where compensation could not be created directly from intervention

mpeltriaux added 2 commits 2025-10-20 16:14:03 +02:00

# Bugfix NewCompensationForm ed5d571704

* fixes bug where a form error would trigger a wrong error warning

# BaseModalFormView refactoring 97fbe02742

* extends BaseModalFormView to hold general logic for processing GET and POST requests for BaseModalForm endpoints
* refactors uuid check to use a specific parameter instead of kwargs
* fixes css bug where modal form input elements would not be visible
* refactors check view for intervention from function to class
* refactors DeductionViews to inherit from extended BaseModalFormView

mpeltriaux added 1 commit 2025-10-20 16:32:15 +02:00

# RecordModalForm refactored a7b23935a1

* refactors AbstractRecordModalForm
* refactors recording view for ema, intervention and eco account

mpeltriaux added 3 commits 2025-10-21 09:25:01 +02:00

# CompensationAction views refactored c7a4c309bf

* refactors AbstractCompensationActionViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for compensation actions
* moves message template strings into message_templates.py

# Deadline views refactored 6056a8882d

* refactors AbstractDeadlineViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for deadline views

# Deadline tests refactored d5accb2143

* refactors tests for deadline views to check whether they work properly

mpeltriaux added 3 commits 2025-10-21 14:56:31 +02:00

# Document views refactoring d2a57df080

* refactors new, edit, get and delete views for eiv, kom, oek and ema
* introduces

# Parcel view refactoring 1175fe3b37

* refactors parcel view to inherit from BaseView

# Log view refactoring 1fc1b533cd

* refactors log views to inherit from BaseView

mpeltriaux added 1 commit 2025-10-21 17:03:17 +02:00

# Resubmission view refactoring 3a9c4e13f6

* refactors resubmission view for eiv, kom, oek, ema
* removes unused attributes on BaseModalFormView

mpeltriaux added 4 commits 2025-10-21 21:05:50 +02:00

# Share view refactoring 554ade6794

* refactors share views for eiv, oek, ema (kom does not have any)

# Test update fe2ac3d97d

* fixes bug for sharing via token where permission was too tight

# Remove View refactoring 837c1de938

* refactors remove view for kom, eiv, oek and ema
* introduces BaseRemoveModalFormView
* moves html blocking logic from BaseModalForm into BaseModalFormView

# Compensation State view refactoring d85ebccec8

* refactors compensation state views for kom, ema, oek
* updates tests
* refactors before-after state toggling into initialization of NewCompensationStateModalForm

mpeltriaux added 1 commit 2025-11-04 08:58:52 +01:00

# Refactoring revocation views 4a16727da1

* refactors views for adding, editing and removing revocations
* refactors view for getting the document of a revocation
* updates tests

mpeltriaux added 2 commits 2025-11-05 10:12:55 +01:00

# Refactoring payment view bc2e901ca9

* refactors views for adding, editing and removing payments

# Refactoring team views f122778232

* refactors team views
* split views.py into users.py and teams.py in users app
* refactors method headers for _user_has_permission()
* adds method and class comments and documentation to base view classes

mpeltriaux added 1 commit 2025-11-05 10:37:34 +01:00

# Refactoring APITokenView cf6f188ef3

* refactors API Token view
* updates tests

mpeltriaux added 1 commit 2025-11-08 13:05:21 +01:00

# Refactoring eiv-kom remove view 1b6eea2c9e

* refactors removing compensation from intervention view
* drops unused view on api app

mpeltriaux added 38 commits 2025-11-28 11:59:09 +01:00

# Index Intervention refactoring aec10ee0af

* introduces BaseIndexView class
* refactors index view for interventions

# Index Compensation refactoring 17d817bbe1

* refactors index view for compensations

# Index EcoAccount refactoring dce61c4d7e

* refactors index view for eco account

# Index Ema refactoring 241db2f51d

* refactors index view for ema

# NewId Generator Ema refactoring 43f313a71e

* introduces BaseNewIdentifierGeneratorView class
* refactors new identifier generator view for ema

# Identifier Generator View refactoring ca7411b6c3

* refactors identifier generator view for interventions
* simplifies same view for ema

# Identifier Generator View Compensation refactoring 225d4e8ce1

* refactors identifier generator view for compensation

# Identifier Generator View EcoAccount refactoring 95510cef36

* refactors identifier generator view for ecoaccount
* simplifies base identifier generator view even further

# User view refactoring f4e97db9ac

* refactors majority of user views into class based views
* introduces BaseModalFormView and BaseView for even more generic usage
* renames url identifier user:index into user:detail for more clarity

# Deduction views 8a984d0169

* refactors deduction views on interventions and eco accounts from function to class based
* introduces basic checks on shared access and permission on BaseView on dispatching --> checks shall be overwritten on inheriting classes

# Report view refactoring 00e2178f3c

* refactors function based report views into class based for EIV, OEK, EMA, KOM
* introduces BaseReportView for proper inheritance of shared logic
* refactors generating of qr codes into proper class

# ClientProxyView 478d630d76

* refactors login required from method decorator to mixin inheritance

# Detail View 34a8ea4aec

* introduces BaseDetailView
* refactors detail views for EIV, KOM, OEK, EMA from function based to class based
* refactors already class based HomeView to inherit from new BaseView

# NewIntervention view 53d5e03a3f

* introduces BaseFormView and BaseNewSpatialLocatedObjectFormView
* refactors new intervention view from function to class

# EditIntervention view 7d80875727

* refactors edit intervention view from function to class

# NewEma EditEma views 0d939c9e19

* refactors views for new ema and edit ema from function to class based
* moves shared access check to base edit form view to be checked for every inheriting class
* fixes bug where private variables changed on singleton objects
* updates translations

# NewCompensation EditCompensation view 5b1af04d66

* refactors new and edit compensation views from function to class based
* adds checked property to compensation to return parent-intervention's checked info
* fixes bug where compensation could be added to recorded intervention
* updates translations

# NewEcoAccount EditEcoAccount view 5e01d7ccda

* refactors new and edit eco account views from function to class based
* removes info message if checked intervention is altered and loses the current checked state
* updates comments/documentation
* removes code duplicates
* fixes display error where modal form was hidden behind menu bar of map client
* fixes bug where compensation could not be created directly from intervention

# Bugfix NewCompensationForm 43846e8d2f

* fixes bug where a form error would trigger a wrong error warning

# BaseModalFormView refactoring abfc48d79b

* extends BaseModalFormView to hold general logic for processing GET and POST requests for BaseModalForm endpoints
* refactors uuid check to use a specific parameter instead of kwargs
* fixes css bug where modal form input elements would not be visible
* refactors check view for intervention from function to class
* refactors DeductionViews to inherit from extended BaseModalFormView

# RecordModalForm refactored a407c86dfb

* refactors AbstractRecordModalForm
* refactors recording view for ema, intervention and eco account

# CompensationAction views refactored 0ad0b02f95

* refactors AbstractCompensationActionViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for compensation actions
* moves message template strings into message_templates.py

# Deadline views refactored bfdf82ac46

* refactors AbstractDeadlineViews (new, edit, remove) to inherit from BaseModalFormView
* refactors KOM, OEK, EMA views for deadline views

# Deadline tests refactored e0b8922494

* refactors tests for deadline views to check whether they work properly

# Document views refactoring efb76278b4

* refactors new, edit, get and delete views for eiv, kom, oek and ema
* introduces

# Parcel view refactoring 971e3f20c8

* refactors parcel view to inherit from BaseView

# Log view refactoring 00109b6bfd

* refactors log views to inherit from BaseView

# Resubmission view refactoring 3de97e2f6a

* refactors resubmission view for eiv, kom, oek, ema
* removes unused attributes on BaseModalFormView

# Share view refactoring 00bf03f58d

* refactors share views for eiv, oek, ema (kom does not have any)

# Test update 765356d064

* fixes bug for sharing via token where permission was too tight

# Remove View refactoring 21af4f2c57

* refactors remove view for kom, eiv, oek and ema
* introduces BaseRemoveModalFormView
* moves html blocking logic from BaseModalForm into BaseModalFormView

# Compensation State view refactoring e239736a72

* refactors compensation state views for kom, ema, oek
* updates tests
* refactors before-after state toggling into initialization of NewCompensationStateModalForm

# Refactoring revocation views c14aff771e

* refactors views for adding, editing and removing revocations
* refactors view for getting the document of a revocation
* updates tests

# Refactoring payment view 644aa2e3cd

* refactors views for adding, editing and removing payments

# Refactoring team views a16fc2eb91

* refactors team views
* split views.py into users.py and teams.py in users app
* refactors method headers for _user_has_permission()
* adds method and class comments and documentation to base view classes

# Refactoring APITokenView 1ac73e4bbb

* refactors API Token view
* updates tests

# Refactoring eiv-kom remove view a70434e2cc

* refactors removing compensation from intervention view
* drops unused view on api app

Merge remote-tracking branch 'origin/490_View_refactoring' into 490_View_refactoring c4cd40913d

# Conflicts:
#	konova/static/css/konova.css

mpeltriaux added 1 commit 2025-12-12 14:13:31 +01:00

# Renaming e49eed21da

* renames certain classes to match their content
* splits larger files into smaller ones

mpeltriaux added 1 commit 2025-12-12 14:14:46 +01:00

Merge branch 'master' into 490_View_refactoring b5cf5c4446

mpeltriaux commented

2025-12-17 14:07:45 +01:00

Refactoring has gone too far. Certain generalizations on the code base created complexity instead of reducing it. There will be another pull request with a far lower complexity in a while.

mpeltriaux closed this pull request

2025-12-17 14:07:45 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

This pull request is marked as a work in progress.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: IT-Naturschutz/konova#491